From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Brian Avery <avery.brian@gmail.com>
Cc: toaster@yoctoproject.org
Subject: Re: [PATCH 00/15] Build cancellation
Date: Mon, 21 Mar 2016 12:34:08 +0200 [thread overview]
Message-ID: <20160321103408.GB29533@linux.intel.com> (raw)
In-Reply-To: <CAKV_0eiV5nhib3bRjKwOy+KP2+BMRqWecNjNtGiQ9aE7opbSFQ@mail.gmail.com>
On Sun, Mar 20, 2016 at 10:12:22AM -0700, Brian Avery wrote:
> a couple of other thoughts after looking at it a little more today:
>
> 1) pid of bitbake started in proj builds dir for cleanup? do we want
> to save these?
not until we use them.
> bitbake.lock with lsof might mean we don't need these. however, having
> them might negate the lsof requirement...)
I'll look what I can do. I was planning to reuse what I did in my old
ed/toaster/bec branch: to generate shell script for cloning all repos
and running the build. It would be much more easy to deal with
pid files in the shell script than in current python code.
However, I think it's better not to do right now as we already have
quite a bit of changes and very close to release.
> 2)should poky oe-init be a #!/bin/bash if dash fails?
No, we shouldn't as it works with zsh.
> 3) toasterui event loop should probably check for liveness of server
> connection…. or do we get an error on waitEvent if the server has
> died (segv’d, kill -9 by user, etc)?
We run sever only during the build. We probably need to set build state to
'Failed' if server is killed or crashed.
Regards,
Ed
next prev parent reply other threads:[~2016-03-21 12:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 15:41 [PATCH 00/15] Build cancellation Ed Bartosh
2016-03-17 15:41 ` [PATCH 01/15] toaster: bldcontrol Add forceShutDown function to BitbakeController Ed Bartosh
2016-03-17 15:41 ` [PATCH 02/15] toaster: Move xhr calls for starting and stopping builds Ed Bartosh
2016-03-17 15:41 ` [PATCH 03/15] toaster: xhr Update the implementation of the build cancellation request Ed Bartosh
2016-03-17 15:41 ` [PATCH 04/15] toaster: libtoaster Update implementation of startABuild and cancelABuild Ed Bartosh
2016-03-17 15:41 ` [PATCH 05/15] toaster: update BuildEnvironmentController and BitbakeController Ed Bartosh
2016-03-17 15:41 ` [PATCH 06/15] toaster: models Add cancelled state to build outcome Ed Bartosh
2016-03-17 15:41 ` [PATCH 07/15] toaster: bldcontrol models Add a cancelling state the BuildRequest Ed Bartosh
2016-03-17 15:41 ` [PATCH 08/15] buildinfohelper: Add handler for cancelling a build Ed Bartosh
2016-03-17 15:41 ` [PATCH 09/15] toaster: tables BuildsTable exclude cancelled builds Ed Bartosh
2016-03-17 15:41 ` [PATCH 10/15] toaster: mrb_section template Add build cancel button Ed Bartosh
2016-03-17 15:41 ` [PATCH 11/15] toaster: models Exclude the CANCELLED builds from get_number_of_builds Ed Bartosh
2016-03-17 15:41 ` [PATCH 12/15] toaster: runbuilds Make runbuilds aware of the build CANCELLED state Ed Bartosh
2016-03-17 15:41 ` [PATCH 13/15] toaster: runbuilds Clean up runbuilds Ed Bartosh
2016-03-17 15:41 ` [PATCH 14/15] toaster: fix conflicting migrations Ed Bartosh
2016-03-17 15:41 ` [PATCH 15/15] toaster: use empty token Ed Bartosh
2016-03-19 23:13 ` [PATCH 00/15] Build cancellation Brian Avery
2016-03-20 17:12 ` Brian Avery
2016-03-21 10:34 ` Ed Bartosh [this message]
2016-03-21 18:07 ` Brian Avery
2016-03-21 18:37 ` Barros Pena, Belen
2016-03-21 21:18 ` Brian Avery
2016-03-22 13:45 ` Barros Pena, Belen
2016-03-21 10:14 ` Ed Bartosh
2016-03-21 11:14 ` Smith, Elliot
2016-03-21 11:36 ` Barros Pena, Belen
2016-03-21 18:04 ` Brian Avery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321103408.GB29533@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=avery.brian@gmail.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.