From: Lee Jones <lee.jones@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Milo Kim <milo.kim@ti.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler
Date: Mon, 21 Mar 2016 11:54:57 +0000 [thread overview]
Message-ID: <20160321115457.GH4140@x1> (raw)
In-Reply-To: <20160311081139.GC31887@mwanda>
On Fri, 11 Mar 2016, Dan Carpenter wrote:
> Instead to being true/false, the "handled" is true/uninitialized.
> Presumably this doesn't cause that many problems in real life because
> normally we handle the IRQ.
>
> Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
I've fixed the $SUBJECT line to be more consistent with the subsystem
style for you this time. Please pay more attention to that in the
future.
`git log --oneline -- $SUBSYSTEM` helps with this.
[I think I recall a conversation with you about this before, and you
said it was part of your submission process?]
Patch applied, thanks.
> diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
> index c7a9825..792d51b 100644
> --- a/drivers/mfd/lp8788-irq.c
> +++ b/drivers/mfd/lp8788-irq.c
> @@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
> struct lp8788_irq_data *irqd = ptr;
> struct lp8788 *lp = irqd->lp;
> u8 status[NUM_REGS], addr, mask;
> - bool handled;
> + bool handled = false;
> int i;
>
> if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Milo Kim <milo.kim@ti.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler
Date: Mon, 21 Mar 2016 11:54:57 +0000 [thread overview]
Message-ID: <20160321115457.GH4140@x1> (raw)
In-Reply-To: <20160311081139.GC31887@mwanda>
On Fri, 11 Mar 2016, Dan Carpenter wrote:
> Instead to being true/false, the "handled" is true/uninitialized.
> Presumably this doesn't cause that many problems in real life because
> normally we handle the IRQ.
>
> Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
I've fixed the $SUBJECT line to be more consistent with the subsystem
style for you this time. Please pay more attention to that in the
future.
`git log --oneline -- $SUBSYSTEM` helps with this.
[I think I recall a conversation with you about this before, and you
said it was part of your submission process?]
Patch applied, thanks.
> diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
> index c7a9825..792d51b 100644
> --- a/drivers/mfd/lp8788-irq.c
> +++ b/drivers/mfd/lp8788-irq.c
> @@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
> struct lp8788_irq_data *irqd = ptr;
> struct lp8788 *lp = irqd->lp;
> u8 status[NUM_REGS], addr, mask;
> - bool handled;
> + bool handled = false;
> int i;
>
> if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-03-21 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 8:11 [patch] mfd: lp8788-irq: uninitialized variable in irq handler Dan Carpenter
2016-03-11 8:11 ` Dan Carpenter
2016-03-13 23:08 ` Kim, Milo
2016-03-13 23:08 ` Kim, Milo
2016-03-21 11:54 ` Lee Jones [this message]
2016-03-21 11:54 ` Lee Jones
2016-03-21 12:30 ` Dan Carpenter
2016-03-21 12:30 ` Dan Carpenter
2016-03-21 18:50 ` Lee Jones
2016-03-21 18:50 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321115457.GH4140@x1 \
--to=lee.jones@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.