From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH RFC] nvme: rewrite discard support
Date: Mon, 21 Mar 2016 15:51:39 +0000 [thread overview]
Message-ID: <20160321155138.GA19307@localhost.localdomain> (raw)
In-Reply-To: <20160321144759.GA12934@lst.de>
On Mon, Mar 21, 2016@03:47:59PM +0100, Christoph Hellwig wrote:
> I think we should just do a 16 byte (or rather cache line size) kmalloc,
> as there is no need for a mempool for discards. Would a version of
> that be fine with you? Because discard is currently the only thing
> preventing us from having a split between transport and commanset specific
> setup for NVMe. And as things like Fabrics and LighNVM show I think
> a clean split there would be rather benefitical in the long run.
We only used the mempool for the driver to leverage normal IO clean up
so that discard isn't special.
It looks like SCSI's special handling lead to what the code comments
describe as a "horrible hack", so that's not convincing this is a good
example to follow.
next prev parent reply other threads:[~2016-03-21 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 23:15 [PATCH RFC] nvme: rewrite discard support Ming Lin
2016-03-17 15:33 ` Keith Busch
2016-03-17 17:27 ` Ming Lin
2016-03-21 14:47 ` Christoph Hellwig
2016-03-21 15:51 ` Keith Busch [this message]
2016-03-21 15:57 ` Christoph Hellwig
2016-03-21 16:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321155138.GA19307@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.