From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH RFC] nvme: rewrite discard support
Date: Mon, 21 Mar 2016 16:57:36 +0100 [thread overview]
Message-ID: <20160321155736.GA14643@lst.de> (raw)
In-Reply-To: <20160321155138.GA19307@localhost.localdomain>
On Mon, Mar 21, 2016@03:51:39PM +0000, Keith Busch wrote:
> It looks like SCSI's special handling lead to what the code comments
> describe as a "horrible hack", so that's not convincing this is a good
> example to follow.
Nah, the "horrible hack" is adding a payload to the request. We went
over and over this and everyone but Kent agrees it's the least horrible
option to handle discards in generic code. NVMe side steps this a bit
by not trying to handle this in common code, but that only works as
long as it's a single tightly integrated driver, not for a layer
architecture like SCSI, or what NVMe is increasingly moving to.
next prev parent reply other threads:[~2016-03-21 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 23:15 [PATCH RFC] nvme: rewrite discard support Ming Lin
2016-03-17 15:33 ` Keith Busch
2016-03-17 17:27 ` Ming Lin
2016-03-21 14:47 ` Christoph Hellwig
2016-03-21 15:51 ` Keith Busch
2016-03-21 15:57 ` Christoph Hellwig [this message]
2016-03-21 16:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321155736.GA14643@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.