[PATCH v2] staging: rtl8712: usb_intf: Remove flush_scheduled_work()

[PATCH v2] staging: rtl8712: usb_intf: Remove flush_scheduled_work()

[Bhaktipriya Shridhar]

flush_scheduled_work() flushes out all work items in system_wq.
Since one doesn't know what could be running there, flushing work items
individually is preferred.

Since there are finite number of work items to be flushed,(viz
pwrpriv->SetPSModeWorkItem,pwrpriv->SetPSModeWorkItem,pLed->BlinkWorkItem)
instead of flushing system_wq, each work item is separately flushed.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 Changes in v2:
	-Fixed typo in commit message.

 drivers/staging/rtl8712/usb_intf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index c1a0ca49..32c5798 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -627,7 +627,9 @@ static void r871xu_dev_remove(struct usb_interface *pusb_intf)
 		if (drvpriv.drv_registered)
 			padapter->bSurpriseRemoved = true;
 		unregister_netdev(pnetdev); /* will call netdev_close() */
-		flush_scheduled_work();
+		cancel_delayed_work(&pwrpriv->SetPSModeWorkItem);
+		cancel_delayed_work(&pwrpriv->rpwm_workitem);
+		cancel_delayed_work(&pLed->BlinkWorkItem);
 		udelay(1);
 		/* Stop driver mlme relation timer */
 		r8712_stop_drv_timers(padapter);
--
2.1.4

Re: [Outreachy kernel] [PATCH v2] staging: rtl8712: usb_intf: Remove flush_scheduled_work()

[Greg KH]

On Sun, Mar 13, 2016 at 12:55:16PM +0530, Bhaktipriya Shridhar wrote:
> flush_scheduled_work() flushes out all work items in system_wq.
> Since one doesn't know what could be running there, flushing work items
> individually is preferred.
> 
> Since there are finite number of work items to be flushed,(viz
> pwrpriv->SetPSModeWorkItem,pwrpriv->SetPSModeWorkItem,pLed->BlinkWorkItem)
> instead of flushing system_wq, each work item is separately flushed.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> Acked-by: Tejun Heo <tj@kernel.org>
> ---
>  Changes in v2:
> 	-Fixed typo in commit message.
> 
>  drivers/staging/rtl8712/usb_intf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index c1a0ca49..32c5798 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -627,7 +627,9 @@ static void r871xu_dev_remove(struct usb_interface *pusb_intf)
>  		if (drvpriv.drv_registered)
>  			padapter->bSurpriseRemoved = true;
>  		unregister_netdev(pnetdev); /* will call netdev_close() */
> -		flush_scheduled_work();
> +		cancel_delayed_work(&pwrpriv->SetPSModeWorkItem);
> +		cancel_delayed_work(&pwrpriv->rpwm_workitem);
> +		cancel_delayed_work(&pLed->BlinkWorkItem);
>  		udelay(1);
>  		/* Stop driver mlme relation timer */
>  		r8712_stop_drv_timers(padapter);
> --
> 2.1.4

This patch does not even build!

Please always test build your patches, to not do so makes maintainers
very grumpy...