From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: devel@driverdev.osuosl.org, lidza.louina@gmail.com,
driverdev-devel@linuxdriverproject.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct
Date: Mon, 21 Mar 2016 21:05:06 +0000 [thread overview]
Message-ID: <20160321210506.GD9749@kroah.com> (raw)
In-Reply-To: <20160314042831.GA5760@SEL-JYOUN-D1>
On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote:
> For using tty_alloc_driver, SerialDriver has to be pointer type.
Yes, but you aren't calling tty_alloc_driver, so this patch totally
breaks the working code :(
Please be more careful...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct
Date: Mon, 21 Mar 2016 17:05:06 -0400 [thread overview]
Message-ID: <20160321210506.GD9749@kroah.com> (raw)
In-Reply-To: <20160314042831.GA5760@SEL-JYOUN-D1>
On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote:
> For using tty_alloc_driver, SerialDriver has to be pointer type.
Yes, but you aren't calling tty_alloc_driver, so this patch totally
breaks the working code :(
Please be more careful...
greg k-h
next prev parent reply other threads:[~2016-03-21 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 4:28 [PATCH 2/3] staging: dgnc: use pointer type of tty_struct Daeseok Youn
2016-03-14 4:28 ` Daeseok Youn
2016-03-21 21:05 ` Greg KH [this message]
2016-03-21 21:05 ` Greg KH
2016-03-22 7:17 ` DaeSeok Youn
2016-03-22 7:17 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321210506.GD9749@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.