From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] dlm: config: Fix ENOMEM failures in make_cluster()
Date: Tue, 22 Mar 2016 19:24:39 +0100 [thread overview]
Message-ID: <20160322182437.GB6797@lst.de> (raw)
In-Reply-To: <1458668194-23627-1-git-send-email-anprice@redhat.com>
On Tue, Mar 22, 2016 at 05:36:34PM +0000, Andrew Price wrote:
> Commit 1ae1602de0 "configfs: switch ->default groups to a linked list"
> left the NULL gps pointer behind after removing the kcalloc() call which
> made it non-NULL. It also left the !gps check in place so make_cluster()
> now fails with ENOMEM. Remove the remaining uses of the gps variable to
> fix that.
>
> Reviewed-by: Bob Peterson <rpeterso@redhat.com>
> Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
> Signed-off-by: Andrew Price <anprice@redhat.com>
Oops, sorry. Thanks for fixing this up!
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andrew Price <anprice@redhat.com>
Cc: ccaulfie@redhat.com, teigland@redhat.com,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH] dlm: config: Fix ENOMEM failures in make_cluster()
Date: Tue, 22 Mar 2016 19:24:39 +0100 [thread overview]
Message-ID: <20160322182437.GB6797@lst.de> (raw)
In-Reply-To: <1458668194-23627-1-git-send-email-anprice@redhat.com>
On Tue, Mar 22, 2016 at 05:36:34PM +0000, Andrew Price wrote:
> Commit 1ae1602de0 "configfs: switch ->default groups to a linked list"
> left the NULL gps pointer behind after removing the kcalloc() call which
> made it non-NULL. It also left the !gps check in place so make_cluster()
> now fails with ENOMEM. Remove the remaining uses of the gps variable to
> fix that.
>
> Reviewed-by: Bob Peterson <rpeterso@redhat.com>
> Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
> Signed-off-by: Andrew Price <anprice@redhat.com>
Oops, sorry. Thanks for fixing this up!
next prev parent reply other threads:[~2016-03-22 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 17:36 [Cluster-devel] [PATCH] dlm: config: Fix ENOMEM failures in make_cluster() Andrew Price
2016-03-22 17:36 ` Andrew Price
2016-03-22 18:24 ` Christoph Hellwig [this message]
2016-03-22 18:24 ` Christoph Hellwig
2016-03-29 15:18 ` [Cluster-devel] " Andrew Price
2016-03-29 15:18 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322182437.GB6797@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.