[PATCH] staging: rtl8192e: add more information to Kconfig

[PATCH] staging: rtl8192e: add more information to Kconfig

[Angel Orejel]

[-- Attachment #1: Type: text/plain, Size: 2041 bytes --]

[PATCH] staging: rtl8192e: add more information to Kconfig

The warnings were originating in the Kconfig file and were
essentially, asking for more information to display. A quick google
search returned the patch that separated the rtl driver from 2011 into
several separate drivers in order to comply with a certain IEEE
standard.

Signed-off-by: deutschluz <deutschluz@gmail.com>

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch first-patch
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#       modified:   drivers/staging/rtl8192e/Kconfig
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#       Kconf_warnings.txt
#       comedi_Kconfig_chkpatch.out
#       config
#       config-4.5
diff --git a/drivers/staging/rtl8192e/Kconfig
b/drivers/staging/rtl8192e/Kconfig
index 4602a47..cc800a3 100644
--- a/drivers/staging/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/Kconfig
@@ -17,7 +17,10 @@ config RTLLIB_CRYPTO_CCMP
        select CRYPTO_AES
        default y
        ---help---
-         CCMP crypto driver for rtllib.
+         CCMP crypto driver for rtllib. This makes
+          the driver compliant with the IEEE 80211i
+          standard. Refer to said standard for more
+          details.

          If you enabled RTLLIB, you want this.

@@ -28,7 +31,9 @@ config RTLLIB_CRYPTO_TKIP
        select CRYPTO_MICHAEL_MIC
        default y
        ---help---
-         TKIP crypto driver for rtllib.
+         TKIP crypto driver for rtllib.This makes
+          the driver comply with IEEE 80211i standard.
+          Refer to said standard for further details.

          If you enabled RTLLIB, you want this.

@@ -39,6 +44,8 @@ config RTLLIB_CRYPTO_WEP
        default y
        ---help---
          TKIP crypto driver for rtllib.
+          This makes the driver comply with IEEE
+          80211i standard.

          If you enabled RTLLIB, you want this.

[-- Attachment #2: Type: text/html, Size: 5995 bytes --]

Re: [PATCH] staging: rtl8192e: add more information to Kconfig

[sveta.orlik.code]

[-- Attachment #1.1: Type: text/plain, Size: 258 bytes --]

Seems like HTML email. How did you posted it?
First I made a mistake using Google Groops web interface to post a patch. 
It does not work right!
Have you made it too?

Use plain text email, send to outreachy-kernel@googlegroups.com (use mutt 
from tutorial)

[-- Attachment #1.2: Type: text/html, Size: 292 bytes --]

Re: [PATCH] staging: rtl8192e: add more information to Kconfig

[Alison Schofield]

Angel,
Your plain mutt mail looks good. Looks like you may have skipped a step
in formatting the patch.  What you have sent is what the file looks
like when I am editing a commit.  Try going back thru the tutorial
and recheck the steps...
- if git show HEAD looks good
- then proceed to git format-patch
- and then send the file that git format-patch produces
Hope that helps,
alisons
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/397c302a-e876-4b6b-9e99-fb7f0f946457%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [PATCH] staging: rtl8192e: add more information to Kconfig

[sveta.orlik.code]

[-- Attachment #1.1: Type: text/plain, Size: 137 bytes --]

I've just seen a strange font and so decided it may be HTML.
(I use Google Groups web interface for reading).
Did not get into the text.

[-- Attachment #1.2: Type: text/html, Size: 171 bytes --]

Re: [PATCH] staging: rtl8192e: add more information to Kconfig

[Angel Orejel]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Hello Ladies,
I just fixed my submission. I hope it goes through ok. Thank you for your
precious time :)

On Tue, Mar 22, 2016 at 9:22 AM, <sveta.orlik.code@gmail.com> wrote:

> I've just seen a strange font and so decided it may be HTML.
> (I use Google Groups web interface for reading).
> Did not get into the text.
>

[-- Attachment #2: Type: text/html, Size: 659 bytes --]

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Greg KH]

On Tue, Mar 22, 2016 at 02:48:25AM -0700, Angel Orejel wrote:
> [PATCH] staging: rtl8192e: add more information to Kconfig
> 
> The warnings were originating in the Kconfig file and were
> essentially, asking for more information to display. A quick google
> search returned the patch that separated the rtl driver from 2011 into
> several separate drivers in order to comply with a certain IEEE
> standard.
> 
> Signed-off-by: deutschluz <deutschluz@gmail.com>
> 
> # Please enter the commit message for your changes. Lines starting
> # with '#' will be ignored, and an empty message aborts the commit.
> # On branch first-patch
> # Changes to be committed:
> #� �(use "git reset HEAD <file>..." to unstage)
> #
> #� � � �modified:� �drivers/staging/rtl8192e/Kconfig
> #
> # Untracked files:
> #� �(use "git add <file>..." to include in what will be committed)
> #
> #� � � �Kconf_warnings.txt
> #� � � �comedi_Kconfig_chkpatch.out
> #� � � �config
> #� � � �config-4.5

How did this get here?

And I need a full name for a signed-off-by line, as well as a patch that
is not in html format to be able to apply it.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Angel Orejel]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

I can fix this but I need some clarification about your question. Should I
delete those untracked files? The top two will be gone because I piped the
output of checkpatch to them, but the bottom two might have been put there
after running the command 'make -j2'. Can I just delete those? or use 'git
checkout'. may be I could use 'git stash'?
Also, about the fact that my patch has html in it: I ve been sending the
patch to my gmail from evolution and then from my gmail to whoever. So i
think i ll just skip that part and send from evolution. I think that should
fix that.

On Wed, Mar 23, 2016 at 7:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Mar 23, 2016 at 04:34:28PM -0700, Angel Orejel wrote:
>
> <snip>
>
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list.  I'll be glad to respond if you
> resend it to everyone.
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1313 bytes --]

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1870 bytes --]

On Wed, 23 Mar 2016, Angel Orejel wrote:

> I can fix this but I need some clarification about your question. Should I
> delete those untracked files? The top two will be gone because I piped the
> output of checkpatch to them, but the bottom two might have been put there
> after running the command 'make -j2'. Can I just delete those? or use 'git
> checkout'. may be I could use 'git stash'? 
> Also, about the fact that my patch has html in it: I ve been sending the
> patch to my gmail from evolution and then from my gmail to whoever. So i
> think i ll just skip that part and send from evolution. I think that should
> fix that.

You should probably not be using evolution.  You should use mutt as 
described in the tutorial.

The application period is also over, but you can end your patch to the 
maintainers indicated in the MAINTAINERS file (easily found using 
scripts/get_maintainer.pl).

julia

> 
> On Wed, Mar 23, 2016 at 7:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>       On Wed, Mar 23, 2016 at 04:34:28PM -0700, Angel Orejel wrote:
> 
>       <snip>
> 
>       For some reason you sent this only to me, which is a bit rude to
>       everyone else on the mailing list.  I'll be glad to respond if
>       you
>       resend it to everyone.
> 
>       thanks,
> 
>       greg k-h
> 
> 
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAGLzxAo%3DDPVr5%2BDEFxq
> xdMWRqGEVWkt_9dTHCLEMfrCiSnE9oA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 
> 

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Greg KH]

On Wed, Mar 23, 2016 at 10:09:50PM -0700, Angel Orejel wrote:
> I can fix this but I need some clarification about your question. Should I
> delete those untracked files? The top two will be gone because I piped the
> output of checkpatch to them, but the bottom two might have been put there
> after running the command 'make -j2'. Can I just delete those? or use 'git
> checkout'. may be I could use 'git stash'?�

I don't understand this at all, 'git stash' is not for making a patch,
when you create it, those # lines will not be in the changelog comments,
how they showed up in your patch is very odd.

Try working through the tutorial again to figure out the steps that are
needed for this.

> Also, about the fact that my patch has html in it: I ve been sending the patch
> to my gmail from evolution and then from my gmail to whoever. So i think i ll
> just skip that part and send from evolution. I think that should fix that.

Just use mutt :)

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Angel Orejel]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

I am still very much interested in helping with the linux kernel. I didn't
know about this outreach thing till last saturday. That was part of the
reason I avoided mutt till now. I had to do a lot of googling to get to
work. But whatever, it works.
GREG: So do I still send this patch to you? or is there another maintainer?

On Thu, Mar 24, 2016 at 6:56 AM, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Mar 23, 2016 at 10:09:50PM -0700, Angel Orejel wrote:
> > I can fix this but I need some clarification about your question. Should
> I
> > delete those untracked files? The top two will be gone because I piped
> the
> > output of checkpatch to them, but the bottom two might have been put
> there
> > after running the command 'make -j2'. Can I just delete those? or use
> 'git
> > checkout'. may be I could use 'git stash'?
>
> I don't understand this at all, 'git stash' is not for making a patch,
> when you create it, those # lines will not be in the changelog comments,
> how they showed up in your patch is very odd.
>
> Try working through the tutorial again to figure out the steps that are
> needed for this.
>
> > Also, about the fact that my patch has html in it: I ve been sending the
> patch
> > to my gmail from evolution and then from my gmail to whoever. So i think
> i ll
> > just skip that part and send from evolution. I think that should fix
> that.
>
> Just use mutt :)
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1914 bytes --]

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2497 bytes --]



On Fri, 25 Mar 2016, Angel Orejel wrote:

> I am still very much interested in helping with the linux kernel. I didn't
> know about this outreach thing till last saturday. That was part of the
> reason I avoided mutt till now. I had to do a lot of googling to get to
> work. But whatever, it works. GREG: So do I still send this patch to you? or
> is there another maintainer?

You run scripts/get_maintainer.pl on your patch to see to whom it should 
be sent.  I use the following options to get the most relevant people, not 
just every random person who has sent a patch on the file.

 --nokeywords --nogit --nogit-fallback --norolestats

julia


> 
> On Thu, Mar 24, 2016 at 6:56 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>       On Wed, Mar 23, 2016 at 10:09:50PM -0700, Angel Orejel wrote:
>       > I can fix this but I need some clarification about your
>       question. Should I
>       > delete those untracked files? The top two will be gone because
>       I piped the
>       > output of checkpatch to them, but the bottom two might have
>       been put there
>       > after running the command 'make -j2'. Can I just delete those?
>       or use 'git
>       > checkout'. may be I could use 'git stash'? 
> 
>       I don't understand this at all, 'git stash' is not for making a
>       patch,
>       when you create it, those # lines will not be in the changelog
>       comments,
>       how they showed up in your patch is very odd.
> 
>       Try working through the tutorial again to figure out the steps
>       that are
>       needed for this.
> 
>       > Also, about the fact that my patch has html in it: I ve been
>       sending the patch
>       > to my gmail from evolution and then from my gmail to whoever.
>       So i think i ll
>       > just skip that part and send from evolution. I think that
>       should fix that.
> 
>       Just use mutt :)
> 
>       thanks,
> 
>       greg k-h
> 
> 
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAGLzxAoSgrpMx8Xt7y7uQSJ
> B%3DZWCj059tHYBqqZug%3Dmq-rMPHw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 
> 

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Angel Orejel]

[-- Attachment #1: Type: text/plain, Size: 2910 bytes --]

Ok I just ran the get_maintainer script and Greg's name was in the output
of that. So my second mutt message is incoming to Greg.
Once again, you are so fast Julia. Thank you for your vigilance and
diligence. :)

On Fri, Mar 25, 2016 at 12:45 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Fri, 25 Mar 2016, Angel Orejel wrote:
>
> > I am still very much interested in helping with the linux kernel. I
> didn't
> > know about this outreach thing till last saturday. That was part of the
> > reason I avoided mutt till now. I had to do a lot of googling to get to
> > work. But whatever, it works. GREG: So do I still send this patch to
> you? or
> > is there another maintainer?
>
> You run scripts/get_maintainer.pl on your patch to see to whom it should
> be sent.  I use the following options to get the most relevant people, not
> just every random person who has sent a patch on the file.
>
>  --nokeywords --nogit --nogit-fallback --norolestats
>
> julia
>
>
> >
> > On Thu, Mar 24, 2016 at 6:56 AM, Greg KH <gregkh@linuxfoundation.org>
> wrote:
> >       On Wed, Mar 23, 2016 at 10:09:50PM -0700, Angel Orejel wrote:
> >       > I can fix this but I need some clarification about your
> >       question. Should I
> >       > delete those untracked files? The top two will be gone because
> >       I piped the
> >       > output of checkpatch to them, but the bottom two might have
> >       been put there
> >       > after running the command 'make -j2'. Can I just delete those?
> >       or use 'git
> >       > checkout'. may be I could use 'git stash'?
> >
> >       I don't understand this at all, 'git stash' is not for making a
> >       patch,
> >       when you create it, those # lines will not be in the changelog
> >       comments,
> >       how they showed up in your patch is very odd.
> >
> >       Try working through the tutorial again to figure out the steps
> >       that are
> >       needed for this.
> >
> >       > Also, about the fact that my patch has html in it: I ve been
> >       sending the patch
> >       > to my gmail from evolution and then from my gmail to whoever.
> >       So i think i ll
> >       > just skip that part and send from evolution. I think that
> >       should fix that.
> >
> >       Just use mutt :)
> >
> >       thanks,
> >
> >       greg k-h
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/CAGLzxAoSgrpMx8Xt7y7uQSJ
> > B%3DZWCj059tHYBqqZug%3Dmq-rMPHw%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
>

[-- Attachment #2: Type: text/html, Size: 4408 bytes --]

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: add more information to Kconfig

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 3607 bytes --]



On Fri, 25 Mar 2016, Angel Orejel wrote:

> Ok I just ran the get_maintainer script and Greg's name was in the output of
> that. So my second mutt message is incoming to Greg.Once again, you are so
> fast Julia. Thank you for your vigilance and diligence. :)

The point is to get it to the right list, even if it is the same person :)

julia

> 
> On Fri, Mar 25, 2016 at 12:45 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> 
> 
>       On Fri, 25 Mar 2016, Angel Orejel wrote:
> 
>       > I am still very much interested in helping with the linux
>       kernel. I didn't
>       > know about this outreach thing till last saturday. That was
>       part of the
>       > reason I avoided mutt till now. I had to do a lot of googling
>       to get to
>       > work. But whatever, it works. GREG: So do I still send this
>       patch to you? or
>       > is there another maintainer?
> 
>       You run scripts/get_maintainer.pl on your patch to see to whom
>       it should
>       be sent.  I use the following options to get the most relevant
>       people, not
>       just every random person who has sent a patch on the file.
> 
>        --nokeywords --nogit --nogit-fallback --norolestats
> 
>       julia
> 
> 
>       >
>       > On Thu, Mar 24, 2016 at 6:56 AM, Greg KH
>       <gregkh@linuxfoundation.org> wrote:
>       >       On Wed, Mar 23, 2016 at 10:09:50PM -0700, Angel Orejel
>       wrote:
>       >       > I can fix this but I need some clarification about
>       your
>       >       question. Should I
>       >       > delete those untracked files? The top two will be gone
>       because
>       >       I piped the
>       >       > output of checkpatch to them, but the bottom two might
>       have
>       >       been put there
>       >       > after running the command 'make -j2'. Can I just
>       delete those?
>       >       or use 'git
>       >       > checkout'. may be I could use 'git stash'? 
>       >
>       >       I don't understand this at all, 'git stash' is not for
>       making a
>       >       patch,
>       >       when you create it, those # lines will not be in the
>       changelog
>       >       comments,
>       >       how they showed up in your patch is very odd.
>       >
>       >       Try working through the tutorial again to figure out the
>       steps
>       >       that are
>       >       needed for this.
>       >
>       >       > Also, about the fact that my patch has html in it: I
>       ve been
>       >       sending the patch
>       >       > to my gmail from evolution and then from my gmail to
>       whoever.
>       >       So i think i ll
>       >       > just skip that part and send from evolution. I think
>       that
>       >       should fix that.
>       >
>       >       Just use mutt :)
>       >
>       >       thanks,
>       >
>       >       greg k-h
>       >
>       >
> > --
> > You received this message because you are subscribed to the Google
> Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CAGLzxAoSgrpMx8Xt7y
> 7uQSJ
> > B%3DZWCj059tHYBqqZug%3Dmq-rMPHw%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
> 
> 
> 
>