Re: [Outreachy kernel] [PATCH v3 2/2] staging: wilc1000: Fix lines over 80 characters

Re: [Outreachy kernel] [PATCH v3 2/2] staging: wilc1000: Fix lines over 80 characters

[Julia Lawall]

On Sun, 13 Mar 2016, Anchal Jain wrote:

> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> changes in v3:
>  - Make the commit message more clear

Now there is no commit message.

julia

>  drivers/staging/wilc1000/linux_mon.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
> index fd25116..242f82f 100644
> --- a/drivers/staging/wilc1000/linux_mon.c
> +++ b/drivers/staging/wilc1000/linux_mon.c
> @@ -59,9 +59,10 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
>  
>  	/* Get WILC header */
>  	memcpy(&header, (buff - HOST_HDR_OFFSET), HOST_HDR_OFFSET);
> -
> -	/* The packet offset field conain info about what type of managment frame */
> -	/* we are dealing with and ack status */
> +	/*
> +	 * The packet offset field contain info about what type of management
> +	 * the frame we are dealing with and ack status
> +	 */
>  	pkt_offset = GET_PKT_OFFSET(header);
>  
>  	if (pkt_offset & IS_MANAGMEMENT_CALLBACK) {
> @@ -105,7 +106,7 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
>  		hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
>  		hdr->hdr.it_len = cpu_to_le16(sizeof(struct wilc_wfi_radiotap_hdr));
>  		hdr->hdr.it_present = cpu_to_le32
> -				(1 << IEEE80211_RADIOTAP_RATE);                   /* | */
> +				(1 << IEEE80211_RADIOTAP_RATE); /* | */
>  		hdr->rate = 5; /* txrate->bitrate / 5; */
>  	}
>  
> @@ -127,8 +128,10 @@ struct tx_complete_mon_data {
>  static void mgmt_tx_complete(void *priv, int status)
>  {
>  	struct tx_complete_mon_data *pv_data = priv;
> -
> -	/* incase of fully hosting mode, the freeing will be done in response to the cfg packet */
> +	/*
> +	 * in case of fully hosting mode, the freeing will be done
> +	 * in response to the cfg packet
> +	 */
>  	kfree(pv_data->buff);
>  
>  	kfree(pv_data);
> @@ -255,7 +258,8 @@ static const struct net_device_ops wilc_wfi_netdev_ops = {
>   *  @date	12 JUL 2012
>   *  @version	1.0
>   */
> -struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_device *real_dev)
> +struct net_device *WILC_WFI_init_mon_interface(const char *name,
> +					       struct net_device *real_dev)
>  {
>  	u32 ret = 0;
>  	struct WILC_WFI_mon_priv *priv;
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2872c92d61078c94d0b7475c3900a841a13d72bd.1457882673.git.anchalj109%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

[PATCH v3 0/2] Fix multiple warnings

[Anchal Jain]

This patchset updates the wilc1000 driver in order to fix several
checkpatch issues detected in the source code.

Anchal Jain (2):
  staging: wilc1000: Remove camel case in variable names.
  staging: wilc1000: Fix lines over 80 characters

 drivers/staging/wilc1000/linux_mon.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

-- 
1.9.1

[PATCH v3 1/2] staging: wilc1000: Remove camel case in variable names.

[Anchal Jain]

Remove a problem detect by checkpatch.pl
CHECK: Avoid CamelCase: <srcAdd>

Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
changes in v3: 
- Make commit message more clear
 drivers/staging/wilc1000/linux_mon.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index 7d9e5de..fd25116 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -24,7 +24,7 @@ struct wilc_wfi_radiotap_cb_hdr {
 
 static struct net_device *wilc_wfi_mon; /* global monitor netdev */
 
-static u8 srcAdd[6];
+static u8 srcadd[6];
 static u8 bssid[6];
 static u8 broadcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
 /**
@@ -225,11 +225,11 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
 	skb->dev = mon_priv->real_ndev;
 
 	/* Identify if Ethernet or MAC header (data or mgmt) */
-	memcpy(srcAdd, &skb->data[10], 6);
+	memcpy(srcadd, &skb->data[10], 6);
 	memcpy(bssid, &skb->data[16], 6);
 	/* if source address and bssid fields are equal>>Mac header */
 	/*send it to mgmt frames handler */
-	if (!(memcmp(srcAdd, bssid, 6))) {
+	if (!(memcmp(srcadd, bssid, 6))) {
 		ret = mon_mgmt_tx(mon_priv->real_ndev, skb->data, skb->len);
 		if (ret)
 			netdev_err(dev, "fail to mgmt tx\n");
-- 
1.9.1

[PATCH v3 2/2] staging: wilc1000: Fix lines over 80 characters

[Anchal Jain]

Break lines so that they do not exceed 80
characters. Problem found using checkpatch.


Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
changes in v3:
- Make subject clear 
 drivers/staging/wilc1000/linux_mon.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index fd25116..9f85ff1 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -60,8 +60,9 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 	/* Get WILC header */
 	memcpy(&header, (buff - HOST_HDR_OFFSET), HOST_HDR_OFFSET);
 
-	/* The packet offset field conain info about what type of managment frame */
-	/* we are dealing with and ack status */
+	/* The packet offset field conain info about what type of management
+	 * frame we are dealing with and ack status
+	 */
 	pkt_offset = GET_PKT_OFFSET(header);
 
 	if (pkt_offset & IS_MANAGMEMENT_CALLBACK) {
@@ -105,7 +106,7 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
 		hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
 		hdr->hdr.it_len = cpu_to_le16(sizeof(struct wilc_wfi_radiotap_hdr));
 		hdr->hdr.it_present = cpu_to_le32
-				(1 << IEEE80211_RADIOTAP_RATE);                   /* | */
+				(1 << IEEE80211_RADIOTAP_RATE); /* | */
 		hdr->rate = 5; /* txrate->bitrate / 5; */
 	}
 
@@ -128,7 +129,9 @@ static void mgmt_tx_complete(void *priv, int status)
 {
 	struct tx_complete_mon_data *pv_data = priv;
 
-	/* incase of fully hosting mode, the freeing will be done in response to the cfg packet */
+	/* in case of fully hosting mode, the freeing will be done
+	 * in response to the cfg packet
+	 */
 	kfree(pv_data->buff);
 
 	kfree(pv_data);
@@ -255,7 +258,8 @@ static const struct net_device_ops wilc_wfi_netdev_ops = {
  *  @date	12 JUL 2012
  *  @version	1.0
  */
-struct net_device *WILC_WFI_init_mon_interface(const char *name, struct net_device *real_dev)
+struct net_device *WILC_WFI_init_mon_interface(const char *name,
+					       struct net_device *real_dev)
 {
 	u32 ret = 0;
 	struct WILC_WFI_mon_priv *priv;
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v3 2/2] staging: wilc1000: Fix lines over 80 characters

[Greg KH]

On Tue, Mar 22, 2016 at 06:03:49PM +0530, Anchal Jain wrote:
> Break lines so that they do not exceed 80
> characters. Problem found using checkpatch.
> 
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> changes in v3:
> - Make subject clear 
>  drivers/staging/wilc1000/linux_mon.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

This patch didn't apply at all to my tree :(