All of lore.kernel.org
 help / color / mirror / Atom feed
From: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
To: "Simmons, James A." <simmonsja@ornl.gov>
Cc: 'Joe Perches' <joe@perches.com>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"Drokin, Oleg" <oleg.drokin@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."
Date: Wed, 23 Mar 2016 16:43:39 -0400	[thread overview]
Message-ID: <20160323204339.GA21923@kroah.com> (raw)
In-Reply-To: <7dcad179d49c4535b4f24d3ceb85607a@EXCHCS32.ornl.gov>

On Wed, Mar 23, 2016 at 08:29:49PM +0000, Simmons, James A. wrote:
> 
> >> > > so the right code should be:
> >> > > 
> >> > > ????????sizeof(**net->ibn_tx_ps);
> >> > > and the same for sizeof(**net->ibn_fmr_ps)
> >> > That's a mess, isn't there some other way to fix this up to be more
> >> > "obvious"?
> >> This must have been encountered in the past. How was it handle in those
> >> other cases?
> >
> >I fail to see why it's a mess.  It's just **
> >and someone making a mistake.
> 
> I have no trouble with **.  If we revert it someone else will come along and
> do the same mistake so I think we are stuck with the change to **.

That's fine, but if you do that, just comment it well so that no one
tries to change it again.  That's why I can't accept the original patch
in this email thread.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
To: "Simmons, James A." <simmonsja@ornl.gov>
Cc: "'Joe Perches'" <joe@perches.com>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"Drokin, Oleg" <oleg.drokin@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."
Date: Wed, 23 Mar 2016 16:43:39 -0400	[thread overview]
Message-ID: <20160323204339.GA21923@kroah.com> (raw)
In-Reply-To: <7dcad179d49c4535b4f24d3ceb85607a@EXCHCS32.ornl.gov>

On Wed, Mar 23, 2016 at 08:29:49PM +0000, Simmons, James A. wrote:
> 
> >> > > so the right code should be:
> >> > > 
> >> > >         sizeof(**net->ibn_tx_ps);
> >> > > and the same for sizeof(**net->ibn_fmr_ps)
> >> > That's a mess, isn't there some other way to fix this up to be more
> >> > "obvious"?
> >> This must have been encountered in the past. How was it handle in those
> >> other cases?
> >
> >I fail to see why it's a mess.  It's just **
> >and someone making a mistake.
> 
> I have no trouble with **.  If we revert it someone else will come along and
> do the same mistake so I think we are stuck with the change to **.

That's fine, but if you do that, just comment it well so that no one
tries to change it again.  That's why I can't accept the original patch
in this email thread.

thanks,

greg k-h

  reply	other threads:[~2016-03-23 20:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 22:21 [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type." James Simmons
2016-03-22 22:21 ` James Simmons
2016-03-23  1:49 ` [lustre-devel] " Greg Kroah-Hartman
2016-03-23  1:49   ` Greg Kroah-Hartman
2016-03-23  5:39   ` [lustre-devel] " Dilger, Andreas
2016-03-23  5:39     ` Dilger, Andreas
2016-03-23  6:29     ` Oucharek, Doug S
2016-03-23  6:29       ` Oucharek, Doug S
2016-03-23 13:41     ` Greg Kroah-Hartman
2016-03-23 13:41       ` Greg Kroah-Hartman
2016-03-23 18:31       ` Simmons, James A.
2016-03-23 18:31         ` Simmons, James A.
2016-03-23 18:47         ` Joe Perches
2016-03-23 18:47           ` Joe Perches
2016-03-23 20:29           ` Simmons, James A.
2016-03-23 20:29             ` Simmons, James A.
2016-03-23 20:43             ` 'Greg Kroah-Hartman' [this message]
2016-03-23 20:43               ` 'Greg Kroah-Hartman'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323204339.GA21923@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    --cc=simmonsja@ornl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.