From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes
Date: Thu, 24 Mar 2016 09:17:26 +0100 [thread overview]
Message-ID: <20160324091726.6eaf83ec@free-electrons.com> (raw)
In-Reply-To: <1458771861-12392-5-git-send-email-afaerber@suse.de>
Hello,
On Wed, 23 Mar 2016 23:24:21 +0100, Andreas F?rber wrote:
> Node names should not contain an instance number, the unit address
> serves to distinguish nodes of the same name. So rename the XOR nodes
> to just xor at address, using xorX as label instead.
>
> Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for Armada 7K/8K")
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>
Removing the instance number from the node name is obviously good.
However, I don't think it's really needed to add labels. The XOR
engines are purely "internal" devices, so they are always enabled at
the SoC level.
> "marvell,mv-xor-v2" is not yet referenced from any driver in next-20160323.
Yes. The driver has been submitted, but has received some comments that
I need to address.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes
Date: Thu, 24 Mar 2016 09:17:26 +0100 [thread overview]
Message-ID: <20160324091726.6eaf83ec@free-electrons.com> (raw)
In-Reply-To: <1458771861-12392-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
Hello,
On Wed, 23 Mar 2016 23:24:21 +0100, Andreas Färber wrote:
> Node names should not contain an instance number, the unit address
> serves to distinguish nodes of the same name. So rename the XOR nodes
> to just xor@address, using xorX as label instead.
>
> Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for Armada 7K/8K")
> Cc: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
Removing the instance number from the node name is obviously good.
However, I don't think it's really needed to add labels. The XOR
engines are purely "internal" devices, so they are always enabled at
the SoC level.
> "marvell,mv-xor-v2" is not yet referenced from any driver in next-20160323.
Yes. The driver has been submitted, but has received some comments that
I need to address.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes
Date: Thu, 24 Mar 2016 09:17:26 +0100 [thread overview]
Message-ID: <20160324091726.6eaf83ec@free-electrons.com> (raw)
In-Reply-To: <1458771861-12392-5-git-send-email-afaerber@suse.de>
Hello,
On Wed, 23 Mar 2016 23:24:21 +0100, Andreas Färber wrote:
> Node names should not contain an instance number, the unit address
> serves to distinguish nodes of the same name. So rename the XOR nodes
> to just xor@address, using xorX as label instead.
>
> Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for Armada 7K/8K")
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Removing the instance number from the node name is obviously good.
However, I don't think it's really needed to add labels. The XOR
engines are purely "internal" devices, so they are always enabled at
the SoC level.
> "marvell,mv-xor-v2" is not yet referenced from any driver in next-20160323.
Yes. The driver has been submitted, but has received some comments that
I need to address.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-24 8:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 22:24 [PATCH 0/4] ARM64: mvebu: Armada 3700/7K/8K DT cleanups Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-23 22:24 ` [PATCH 1/4] arm64: dts: marvell: Clean up armada-3720-db Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-24 16:11 ` Gregory CLEMENT
2016-03-24 16:11 ` Gregory CLEMENT
2016-03-24 16:11 ` Gregory CLEMENT
2016-03-24 16:46 ` Andreas Färber
2016-03-24 16:46 ` Andreas Färber
2016-03-24 16:46 ` Andreas Färber
2016-03-25 8:16 ` Gregory CLEMENT
2016-03-25 8:16 ` Gregory CLEMENT
2016-03-25 8:16 ` Gregory CLEMENT
2016-04-07 19:00 ` Gregory CLEMENT
2016-04-07 19:00 ` Gregory CLEMENT
2016-03-23 22:24 ` [PATCH 2/4] arm64: dts: marvell: Rename armada-37xx USB node Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-23 22:24 ` [PATCH 3/4] arm64: dts: marvell: Clean up armada-7040-db Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-24 8:18 ` Thomas Petazzoni
2016-03-24 8:18 ` Thomas Petazzoni
2016-03-24 8:18 ` Thomas Petazzoni
2016-03-24 10:27 ` Gregory CLEMENT
2016-03-24 10:27 ` Gregory CLEMENT
2016-03-24 10:27 ` Gregory CLEMENT
2016-03-24 10:40 ` Thomas Petazzoni
2016-03-24 10:40 ` Thomas Petazzoni
2016-03-24 10:40 ` Thomas Petazzoni
2016-03-24 13:37 ` Andrew Lunn
2016-03-24 13:37 ` Andrew Lunn
2016-03-24 13:37 ` Andrew Lunn
2016-03-24 13:59 ` Jason Cooper
2016-03-24 13:59 ` Jason Cooper
2016-03-23 22:24 ` [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-23 22:24 ` Andreas Färber
2016-03-24 8:17 ` Thomas Petazzoni [this message]
2016-03-24 8:17 ` Thomas Petazzoni
2016-03-24 8:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324091726.6eaf83ec@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.