All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>
Cc: "'Yan, Zheng'" <zyan@redhat.com>,
	'Ceph Development' <ceph-devel@vger.kernel.org>,
	'Sage Weil' <sage@redhat.com>,
	idryomov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]  fs/ceph: make logical calculation functions return bool
Date: Sat, 26 Mar 2016 00:39:36 +0000	[thread overview]
Message-ID: <20160326003936.GL17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <000601d18672$4da04d80$e8e0e880$@cmss.chinamobile.com>

On Fri, Mar 25, 2016 at 04:42:45PM +0800, Zhang Zhuoyu wrote:
> > This one is for ilookup5.  ilookup5() wants function pointer "int (*test)(struct
> > inode *, void *)”.  The rest change looks good.
> > 
> > Regards
> > Yan, Zheng
> > 
> 
> Yes, you are right, I will send another version.

... as long as that another version does not try to switch the callback type
of ilookup5/iget5_locked/etc argument.
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>
Cc: "'Yan, Zheng'" <zyan@redhat.com>,
	"'Ceph Development'" <ceph-devel@vger.kernel.org>,
	"'Sage Weil'" <sage@redhat.com>,
	idryomov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]  fs/ceph: make logical calculation functions return bool
Date: Sat, 26 Mar 2016 00:39:36 +0000	[thread overview]
Message-ID: <20160326003936.GL17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <000601d18672$4da04d80$e8e0e880$@cmss.chinamobile.com>

On Fri, Mar 25, 2016 at 04:42:45PM +0800, Zhang Zhuoyu wrote:
> > This one is for ilookup5.  ilookup5() wants function pointer "int (*test)(struct
> > inode *, void *)”.  The rest change looks good.
> > 
> > Regards
> > Yan, Zheng
> > 
> 
> Yes, you are right, I will send another version.

... as long as that another version does not try to switch the callback type
of ilookup5/iget5_locked/etc argument.

  reply	other threads:[~2016-03-26  0:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25  6:19 [PATCH] fs/ceph: make logical calculation functions return bool Zhang Zhuoyu
2016-03-25  8:31 ` Yan, Zheng
2016-03-25  8:31   ` Yan, Zheng
2016-03-25  8:42   ` Zhang Zhuoyu
2016-03-25  8:42     ` Zhang Zhuoyu
2016-03-26  0:39     ` Al Viro [this message]
2016-03-26  0:39       ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160326003936.GL17997@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sage@redhat.com \
    --cc=zhangzhuoyu@cmss.chinamobile.com \
    --cc=zyan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.