From: Theodore Ts'o <tytso@mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Eric Biggers <ebiggers3@gmail.com>,
Michael Halcrow <mhalcrow@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux F2FS Dev Mailing List
<linux-f2fs-devel@lists.sourceforge.net>,
Linux FS Dev Mailing List <linux-fsdevel@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [GIT PULL] f2fs updates for v4.6
Date: Sat, 26 Mar 2016 16:55:35 -0400 [thread overview]
Message-ID: <20160326205535.GE4539@thunk.org> (raw)
In-Reply-To: <CA+55aFyh6Kjnb+=M5b-V7zY9nakzGfNyNwJf4VZHeQ5cOQRmKw@mail.gmail.com>
On Sat, Mar 26, 2016 at 01:48:23PM -0700, Linus Torvalds wrote:
> > BTW, as far as switching ext4 to use the shared code in fs/crypto ---
> > I'm hoping to get that done for the next merge window. There are a 2
> > or 3 patches to fix some recently discovered bugs that I'll need to
> > push into the fs/crypto code, but I'll take care of that for the next
> > development cycle.
>
> No worries. Considering this mistake (which happily seems to have an
> innocent explanation for it) it would be good to have it verified that
> the shared code does actually work for you, so that we don't end up in
> the unhappy situation that the code got split up in order to be
> shared, but some random detail choice then made it not actually work
> for ext4 after all..
Oh, for sure. One of the things I plan to do is to make sure that a
file system created using the *current* ext4 encryption code is
properly readable using the new fs/crypto code. I'll also run a full
regression test run using xfstests as well.
That's one of the reasons why I wasn't going to even try to get it
done for this merge window (even if you weren't going to be closing
the merge window tomorrow). I just didn't have the time to do a good
job, and it made sense to let the f2fs code go in first, and then
convert ext4 afterwards.
- Ted
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Eric Biggers <ebiggers3@gmail.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS Dev Mailing List <linux-fsdevel@vger.kernel.org>,
Linux F2FS Dev Mailing List
<linux-f2fs-devel@lists.sourceforge.net>,
Michael Halcrow <mhalcrow@google.com>
Subject: Re: [GIT PULL] f2fs updates for v4.6
Date: Sat, 26 Mar 2016 16:55:35 -0400 [thread overview]
Message-ID: <20160326205535.GE4539@thunk.org> (raw)
In-Reply-To: <CA+55aFyh6Kjnb+=M5b-V7zY9nakzGfNyNwJf4VZHeQ5cOQRmKw@mail.gmail.com>
On Sat, Mar 26, 2016 at 01:48:23PM -0700, Linus Torvalds wrote:
> > BTW, as far as switching ext4 to use the shared code in fs/crypto ---
> > I'm hoping to get that done for the next merge window. There are a 2
> > or 3 patches to fix some recently discovered bugs that I'll need to
> > push into the fs/crypto code, but I'll take care of that for the next
> > development cycle.
>
> No worries. Considering this mistake (which happily seems to have an
> innocent explanation for it) it would be good to have it verified that
> the shared code does actually work for you, so that we don't end up in
> the unhappy situation that the code got split up in order to be
> shared, but some random detail choice then made it not actually work
> for ext4 after all..
Oh, for sure. One of the things I plan to do is to make sure that a
file system created using the *current* ext4 encryption code is
properly readable using the new fs/crypto code. I'll also run a full
regression test run using xfstests as well.
That's one of the reasons why I wasn't going to even try to get it
done for this merge window (even if you weren't going to be closing
the merge window tomorrow). I just didn't have the time to do a good
job, and it made sense to let the f2fs code go in first, and then
convert ext4 afterwards.
- Ted
next prev parent reply other threads:[~2016-03-26 20:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 22:58 [GIT PULL] f2fs updates for v4.6 Jaegeuk Kim
2016-03-20 22:58 ` Jaegeuk Kim
2016-03-21 18:09 ` Linus Torvalds
2016-03-21 18:09 ` Linus Torvalds
2016-03-21 18:45 ` Jaegeuk Kim
2016-03-21 18:45 ` Jaegeuk Kim
2016-03-26 6:10 ` Eric Biggers
2016-03-26 6:10 ` Eric Biggers
2016-03-26 8:56 ` Jaegeuk Kim
2016-03-26 13:47 ` Eric Biggers
2016-03-26 17:53 ` Linus Torvalds
2016-03-26 20:00 ` Jaegeuk Kim
2016-03-26 20:04 ` Linus Torvalds
2016-03-26 20:26 ` Jaegeuk Kim
2016-03-26 20:41 ` Theodore Ts'o
2016-03-26 20:48 ` Linus Torvalds
2016-03-26 20:48 ` Linus Torvalds
2016-03-26 20:55 ` Theodore Ts'o [this message]
2016-03-26 20:55 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2016-03-18 0:58 Jaegeuk Kim
2016-03-18 0:58 ` Jaegeuk Kim
2016-03-18 2:32 ` Linus Torvalds
2016-03-18 2:35 ` Linus Torvalds
2016-03-18 5:00 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160326205535.GE4539@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers3@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.