* [PATCH 0/4] STi DT updates
@ 2016-03-25 15:36 ` Peter Griffin
0 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, maxime.coquelin, patrice.chotard,
srinivas.kandagatla
Cc: peter.griffin, lee.jones, devicetree
Hi Maxime,
This series adds some more alternate pin configurations which were missing
upstream, the DT config for SSC12, and also a DT node for the 24c256 eeprom.
regards,
Peter.
Peter Griffin (4):
ARM: DT: STiH407: Add UART RTS/CTS pin configuration
ARM: DT: STiH407: Add i2c12 pin definition
ARM: DT: STiH407: Add node for i2c12 controller
ARM: STi: DT: STiH407: Add DT node for eeprom
arch/arm/boot/dts/stih407-family.dtsi | 13 ++++++
arch/arm/boot/dts/stih407-pinctrl.dtsi | 82 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 ++++
3 files changed, 104 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 0/4] STi DT updates
@ 2016-03-25 15:36 ` Peter Griffin
0 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, maxime.coquelin-qxv4g6HH51o,
patrice.chotard-qxv4g6HH51o,
srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w
Cc: peter.griffin-QSEj5FYQhm4dnm+yROfE0A,
lee.jones-QSEj5FYQhm4dnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA
Hi Maxime,
This series adds some more alternate pin configurations which were missing
upstream, the DT config for SSC12, and also a DT node for the 24c256 eeprom.
regards,
Peter.
Peter Griffin (4):
ARM: DT: STiH407: Add UART RTS/CTS pin configuration
ARM: DT: STiH407: Add i2c12 pin definition
ARM: DT: STiH407: Add node for i2c12 controller
ARM: STi: DT: STiH407: Add DT node for eeprom
arch/arm/boot/dts/stih407-family.dtsi | 13 ++++++
arch/arm/boot/dts/stih407-pinctrl.dtsi | 82 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 ++++
3 files changed, 104 insertions(+)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] ARM: DT: STiH407: Add UART RTS/CTS pin configuration
2016-03-25 15:36 ` Peter Griffin
@ 2016-03-25 15:36 ` Peter Griffin
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel
Add pinctrl definitions of UART RTS/CTS pins.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-pinctrl.dtsi | 73 ++++++++++++++++++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
index a538ae5..87e75bf 100644
--- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
@@ -149,7 +149,20 @@
rx = <&pio3 5 ALT1 IN>;
};
};
+
+ pinctrl_sbc_serial0_rts: sbc_serial0_rts {
+ st,pins {
+ rts = <&pio3 7 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_sbc_serial0_cts: sbc_serial0_cts {
+ st,pins {
+ cts = <&pio3 6 ALT1 IN>;
+ };
+ };
};
+
/* SBC_ASC1 - UART11 */
sbc_serial1 {
pinctrl_sbc_serial1: sbc_serial1-0 {
@@ -158,6 +171,18 @@
rx = <&pio2 7 ALT3 IN>;
};
};
+
+ pinctrl_sbc_serial1_rts: sbc_serial1_rts {
+ st,pins {
+ rts = <&pio3 1 ALT3 OUT>;
+ };
+ };
+
+ pinctrl_sbc_serial1_cts: sbc_serial1_cts {
+ st,pins {
+ cts = <&pio3 0 ALT3 IN>;
+ };
+ };
};
i2c10 {
@@ -478,6 +503,18 @@
rx = <&pio15 1 ALT1 IN>;
};
};
+
+ pinctrl_serial0_rts: serial0_rts {
+ st,pins {
+ rts = <&pio17 3 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial0_cts: serial0_cts {
+ st,pins {
+ cts = <&pio17 2 ALT1 IN>;
+ };
+ };
};
mmc1 {
@@ -495,6 +532,18 @@
sd_wp = <&pio19 1 ALT6 IN>;
};
};
+
+ pinctrl_serial1_rts: serial1_rts {
+ st,pins {
+ rts = <&pio16 3 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial1_cts: serial1_cts {
+ st,pins {
+ cts = <&pio16 2 ALT1 IN>;
+ };
+ };
};
@@ -505,6 +554,18 @@
scl = <&pio10 5 ALT2 BIDIR>;
};
};
+
+ pinctrl_serial2_rts: serial2_rts {
+ st,pins {
+ rts = <&pio15 3 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial2_cts: serial2_cts {
+ st,pins {
+ cts = <&pio15 2 ALT1 IN>;
+ };
+ };
};
i2c1 {
@@ -1074,6 +1135,18 @@
rx = <&pio31 4 ALT1 IN>;
};
};
+
+ pinctrl_serial3_rts: serial3_rts {
+ st,pins {
+ rts = <&pio31 6 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial3_cts: serial3_cts {
+ st,pins {
+ cts = <&pio31 5 ALT1 IN>;
+ };
+ };
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 1/4] ARM: DT: STiH407: Add UART RTS/CTS pin configuration
@ 2016-03-25 15:36 ` Peter Griffin
0 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, maxime.coquelin, patrice.chotard,
srinivas.kandagatla
Cc: peter.griffin, lee.jones, devicetree
Add pinctrl definitions of UART RTS/CTS pins.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-pinctrl.dtsi | 73 ++++++++++++++++++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
index a538ae5..87e75bf 100644
--- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
@@ -149,7 +149,20 @@
rx = <&pio3 5 ALT1 IN>;
};
};
+
+ pinctrl_sbc_serial0_rts: sbc_serial0_rts {
+ st,pins {
+ rts = <&pio3 7 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_sbc_serial0_cts: sbc_serial0_cts {
+ st,pins {
+ cts = <&pio3 6 ALT1 IN>;
+ };
+ };
};
+
/* SBC_ASC1 - UART11 */
sbc_serial1 {
pinctrl_sbc_serial1: sbc_serial1-0 {
@@ -158,6 +171,18 @@
rx = <&pio2 7 ALT3 IN>;
};
};
+
+ pinctrl_sbc_serial1_rts: sbc_serial1_rts {
+ st,pins {
+ rts = <&pio3 1 ALT3 OUT>;
+ };
+ };
+
+ pinctrl_sbc_serial1_cts: sbc_serial1_cts {
+ st,pins {
+ cts = <&pio3 0 ALT3 IN>;
+ };
+ };
};
i2c10 {
@@ -478,6 +503,18 @@
rx = <&pio15 1 ALT1 IN>;
};
};
+
+ pinctrl_serial0_rts: serial0_rts {
+ st,pins {
+ rts = <&pio17 3 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial0_cts: serial0_cts {
+ st,pins {
+ cts = <&pio17 2 ALT1 IN>;
+ };
+ };
};
mmc1 {
@@ -495,6 +532,18 @@
sd_wp = <&pio19 1 ALT6 IN>;
};
};
+
+ pinctrl_serial1_rts: serial1_rts {
+ st,pins {
+ rts = <&pio16 3 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial1_cts: serial1_cts {
+ st,pins {
+ cts = <&pio16 2 ALT1 IN>;
+ };
+ };
};
@@ -505,6 +554,18 @@
scl = <&pio10 5 ALT2 BIDIR>;
};
};
+
+ pinctrl_serial2_rts: serial2_rts {
+ st,pins {
+ rts = <&pio15 3 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial2_cts: serial2_cts {
+ st,pins {
+ cts = <&pio15 2 ALT1 IN>;
+ };
+ };
};
i2c1 {
@@ -1074,6 +1135,18 @@
rx = <&pio31 4 ALT1 IN>;
};
};
+
+ pinctrl_serial3_rts: serial3_rts {
+ st,pins {
+ rts = <&pio31 6 ALT1 OUT>;
+ };
+ };
+
+ pinctrl_serial3_cts: serial3_cts {
+ st,pins {
+ cts = <&pio31 5 ALT1 IN>;
+ };
+ };
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/4] ARM: DT: STiH407: Add i2c12 pin definition
2016-03-25 15:36 ` Peter Griffin
(?)
@ 2016-03-25 15:36 ` Peter Griffin
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel
Add DT pinctrl definitions for SSC12 controller.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-pinctrl.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
index 87e75bf..e647751 100644
--- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
@@ -203,6 +203,15 @@
};
};
+ i2c12 {
+ pinctrl_i2c12_default: i2c12-default {
+ st,pins {
+ sda = <&pio3 6 ALT2 BIDIR>;
+ scl = <&pio3 7 ALT2 BIDIR>;
+ };
+ };
+ };
+
keyscan {
pinctrl_keyscan: keyscan {
st,pins {
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/4] ARM: DT: STiH407: Add i2c12 pin definition
@ 2016-03-25 15:36 ` Peter Griffin
0 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, maxime.coquelin, patrice.chotard,
srinivas.kandagatla
Cc: peter.griffin, lee.jones, devicetree
Add DT pinctrl definitions for SSC12 controller.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-pinctrl.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
index 87e75bf..e647751 100644
--- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
@@ -203,6 +203,15 @@
};
};
+ i2c12 {
+ pinctrl_i2c12_default: i2c12-default {
+ st,pins {
+ sda = <&pio3 6 ALT2 BIDIR>;
+ scl = <&pio3 7 ALT2 BIDIR>;
+ };
+ };
+ };
+
keyscan {
pinctrl_keyscan: keyscan {
st,pins {
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/4] ARM: DT: STiH407: Add i2c12 pin definition
@ 2016-03-25 15:36 ` Peter Griffin
0 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, maxime.coquelin, patrice.chotard,
srinivas.kandagatla
Cc: peter.griffin, devicetree, lee.jones
Add DT pinctrl definitions for SSC12 controller.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-pinctrl.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
index 87e75bf..e647751 100644
--- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
@@ -203,6 +203,15 @@
};
};
+ i2c12 {
+ pinctrl_i2c12_default: i2c12-default {
+ st,pins {
+ sda = <&pio3 6 ALT2 BIDIR>;
+ scl = <&pio3 7 ALT2 BIDIR>;
+ };
+ };
+ };
+
keyscan {
pinctrl_keyscan: keyscan {
st,pins {
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/4] ARM: DT: STiH407: Add node for i2c12 controller
2016-03-25 15:36 ` Peter Griffin
@ 2016-03-25 15:36 ` Peter Griffin
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel
Add DT support for SSC12.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-family.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 81f8121..7785f31 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -327,6 +327,19 @@
status = "disabled";
};
+ i2c at 9542000 {
+ compatible = "st,comms-ssc4-i2c";
+ reg = <0x9542000 0x110>;
+ interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk_sysin>;
+ clock-names = "ssc";
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c12_default>;
+
+ status = "disabled";
+ };
+
usb2_picophy0: phy1 {
compatible = "st,stih407-usb2-phy";
#phy-cells = <0>;
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/4] ARM: DT: STiH407: Add node for i2c12 controller
@ 2016-03-25 15:36 ` Peter Griffin
0 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, maxime.coquelin, patrice.chotard,
srinivas.kandagatla
Cc: peter.griffin, lee.jones, devicetree
Add DT support for SSC12.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-family.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 81f8121..7785f31 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -327,6 +327,19 @@
status = "disabled";
};
+ i2c@9542000 {
+ compatible = "st,comms-ssc4-i2c";
+ reg = <0x9542000 0x110>;
+ interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk_sysin>;
+ clock-names = "ssc";
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c12_default>;
+
+ status = "disabled";
+ };
+
usb2_picophy0: phy1 {
compatible = "st,stih407-usb2-phy";
#phy-cells = <0>;
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/4] ARM: STi: DT: STiH407: Add DT node for eeprom
2016-03-25 15:36 ` Peter Griffin
@ 2016-03-25 15:36 ` Peter Griffin
-1 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 133375b..0d7c6dd 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -58,6 +58,15 @@
i2c at 9845000 {
status = "okay";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eeprom at 50 {
+ compatible = "at,24c256";
+ pagesize = <64>;
+ reg = <0x50>;
+ };
};
i2c at 9540000 {
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 4/4] ARM: STi: DT: STiH407: Add DT node for eeprom
@ 2016-03-25 15:36 ` Peter Griffin
0 siblings, 0 replies; 14+ messages in thread
From: Peter Griffin @ 2016-03-25 15:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, maxime.coquelin, patrice.chotard,
srinivas.kandagatla
Cc: peter.griffin, lee.jones, devicetree
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 133375b..0d7c6dd 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -58,6 +58,15 @@
i2c@9845000 {
status = "okay";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eeprom@50 {
+ compatible = "at,24c256";
+ pagesize = <64>;
+ reg = <0x50>;
+ };
};
i2c@9540000 {
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 4/4] ARM: STi: DT: STiH407: Add DT node for eeprom
2016-03-25 15:36 ` Peter Griffin
@ 2016-03-29 9:12 ` Lee Jones
-1 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2016-03-29 9:12 UTC (permalink / raw)
To: linux-arm-kernel
More information is required in the commit message.
What do we use the EEPROM for? What information is contained within?
What stops working if we don't support it? What starts working if we
do?
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 133375b..0d7c6dd 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -58,6 +58,15 @@
>
> i2c at 9845000 {
> status = "okay";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eeprom at 50 {
> + compatible = "at,24c256";
> + pagesize = <64>;
> + reg = <0x50>;
> + };
> };
>
> i2c at 9540000 {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] ARM: STi: DT: STiH407: Add DT node for eeprom
@ 2016-03-29 9:12 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2016-03-29 9:12 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-arm-kernel, linux-kernel, maxime.coquelin, patrice.chotard,
srinivas.kandagatla, devicetree
More information is required in the commit message.
What do we use the EEPROM for? What information is contained within?
What stops working if we don't support it? What starts working if we
do?
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 133375b..0d7c6dd 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -58,6 +58,15 @@
>
> i2c@9845000 {
> status = "okay";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eeprom@50 {
> + compatible = "at,24c256";
> + pagesize = <64>;
> + reg = <0x50>;
> + };
> };
>
> i2c@9540000 {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread