All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm2835: add CPU node for ARM core
Date: Tue, 29 Mar 2016 11:13:51 +0100	[thread overview]
Message-ID: <20160329101351.GC26574@leverpostej> (raw)
In-Reply-To: <56FA5332.4050707@i2se.com>

On Tue, Mar 29, 2016 at 12:04:34PM +0200, Stefan Wahren wrote:
> Am 29.03.2016 um 11:41 schrieb Mark Rutland:
> > On Mon, Mar 28, 2016 at 04:21:20PM +0000, Stefan Wahren wrote:
> >> This patch adds the CPU node of the BCM2835 into the DT.
> >>
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> >> ---
> >>  arch/arm/boot/dts/bcm2835.dtsi |   11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> >> index b83b326..e87aba1 100644
> >> --- a/arch/arm/boot/dts/bcm2835.dtsi
> >> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> >> @@ -3,6 +3,17 @@
> >>  / {
> >>  	compatible = "brcm,bcm2835";
> >>  
> >> +	cpus {
> >> +		#address-cells = <1>;
> >> +		#size-cells = <0>;
> >> +
> >> +		cpu at 0 {
> >> +			device_type = "cpu";
> >> +			compatible = "arm,arm1176jzf-s", "arm,arm1176";
> >> +			reg = <0x0>;
> >> +		};
> >> +	};
> > Minor nit: the "arm,arm1176" fallback isn't documented, nor used
> > elsewhere, so it can/should be dropped.
> 
> This fallback came from arch/arm/boot/dts/s3c64xx.dtsi

Ah, indeed. I failed to spot that when grepping. For consistency, we
should probably clean that up.

> I will send a V2 without the fallback.

Cheers!

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: bcm2835: add CPU node for ARM core
Date: Tue, 29 Mar 2016 11:13:51 +0100	[thread overview]
Message-ID: <20160329101351.GC26574@leverpostej> (raw)
In-Reply-To: <56FA5332.4050707-eS4NqCHxEME@public.gmane.org>

On Tue, Mar 29, 2016 at 12:04:34PM +0200, Stefan Wahren wrote:
> Am 29.03.2016 um 11:41 schrieb Mark Rutland:
> > On Mon, Mar 28, 2016 at 04:21:20PM +0000, Stefan Wahren wrote:
> >> This patch adds the CPU node of the BCM2835 into the DT.
> >>
> >> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> >> ---
> >>  arch/arm/boot/dts/bcm2835.dtsi |   11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> >> index b83b326..e87aba1 100644
> >> --- a/arch/arm/boot/dts/bcm2835.dtsi
> >> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> >> @@ -3,6 +3,17 @@
> >>  / {
> >>  	compatible = "brcm,bcm2835";
> >>  
> >> +	cpus {
> >> +		#address-cells = <1>;
> >> +		#size-cells = <0>;
> >> +
> >> +		cpu@0 {
> >> +			device_type = "cpu";
> >> +			compatible = "arm,arm1176jzf-s", "arm,arm1176";
> >> +			reg = <0x0>;
> >> +		};
> >> +	};
> > Minor nit: the "arm,arm1176" fallback isn't documented, nor used
> > elsewhere, so it can/should be dropped.
> 
> This fallback came from arch/arm/boot/dts/s3c64xx.dtsi

Ah, indeed. I failed to spot that when grepping. For consistency, we
should probably clean that up.

> I will send a V2 without the fallback.

Cheers!

Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-03-29 10:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-28 16:21 [PATCH] ARM: bcm2835: add CPU node for ARM core Stefan Wahren
2016-03-28 16:21 ` Stefan Wahren
2016-03-28 19:36 ` Eric Anholt
2016-03-28 19:36   ` Eric Anholt
2016-03-29  9:41 ` Mark Rutland
2016-03-29  9:41   ` Mark Rutland
2016-03-29 10:04   ` Stefan Wahren
2016-03-29 10:04     ` Stefan Wahren
2016-03-29 10:13     ` Mark Rutland [this message]
2016-03-29 10:13       ` Mark Rutland
2016-03-30 14:17 ` Stephen Warren
2016-03-30 14:17   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160329101351.GC26574@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.