All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Vishal Verma <vishal@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Vishal Verma <vishal.l.verma@intel.com>,
	linux-block@vger.kernel.org, Jan Kara <jack@suse.cz>,
	linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com, Jens Axboe <axboe@fb.com>,
	linux-mm@kvack.org, Matthew Wilcox <matthew.r.wilcox@intel.com>,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-ext4@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Tue, 29 Mar 2016 23:56:46 -0700	[thread overview]
Message-ID: <20160330065646.GA13123@infradead.org> (raw)
In-Reply-To: <1459320877.4102.3.camel@kernel.org>

On Wed, Mar 30, 2016 at 12:54:37AM -0600, Vishal Verma wrote:
> On Tue, 2016-03-29 at 23:34 -0700, Christoph Hellwig wrote:
> > Hi Vishal,
> > 
> > still NAK to calling the direct I/O code directly from the dax code.
> 
> Hm, I thought this was what you meant -- do the fallback/retry attempts
> at the callers of dax_do_io instead of the new dax wrapper function..
> Did I misunderstand you?

Sorry, it is.  I misread fs/block_dev.c as fs/dax.c before my first
coffee this morning.  I'll properly review the series in the afternoon..

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Vishal Verma <vishal@kernel.org>
Cc: linux-block@vger.kernel.org, Jan Kara <jack@suse.cz>,
	Jens Axboe <axboe@fb.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	linux-mm@kvack.org, Matthew Wilcox <matthew.r.wilcox@intel.com>,
	linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-ext4@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Tue, 29 Mar 2016 23:56:46 -0700	[thread overview]
Message-ID: <20160330065646.GA13123@infradead.org> (raw)
In-Reply-To: <1459320877.4102.3.camel@kernel.org>

On Wed, Mar 30, 2016 at 12:54:37AM -0600, Vishal Verma wrote:
> On Tue, 2016-03-29 at 23:34 -0700, Christoph Hellwig wrote:
> > Hi Vishal,
> > 
> > still NAK to calling the direct I/O code directly from the dax code.
> 
> Hm, I thought this was what you meant -- do the fallback/retry attempts
> at the callers of dax_do_io instead of the new dax wrapper function..
> Did I misunderstand you?

Sorry, it is.  I misread fs/block_dev.c as fs/dax.c before my first
coffee this morning.  I'll properly review the series in the afternoon..

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Vishal Verma <vishal@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Vishal Verma <vishal.l.verma@intel.com>,
	linux-block@vger.kernel.org, Jan Kara <jack@suse.cz>,
	linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com, Jens Axboe <axboe@fb.com>,
	linux-mm@kvack.org, Matthew Wilcox <matthew.r.wilcox@intel.com>,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-ext4@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Date: Tue, 29 Mar 2016 23:56:46 -0700	[thread overview]
Message-ID: <20160330065646.GA13123@infradead.org> (raw)
In-Reply-To: <1459320877.4102.3.camel@kernel.org>

On Wed, Mar 30, 2016 at 12:54:37AM -0600, Vishal Verma wrote:
> On Tue, 2016-03-29 at 23:34 -0700, Christoph Hellwig wrote:
> > Hi Vishal,
> > 
> > still NAK to calling the direct I/O code directly from the dax code.
> 
> Hm, I thought this was what you meant -- do the fallback/retry attempts
> at the callers of dax_do_io instead of the new dax wrapper function..
> Did I misunderstand you?

Sorry, it is.  I misread fs/block_dev.c as fs/dax.c before my first
coffee this morning.  I'll properly review the series in the afternoon..

  reply	other threads:[~2016-03-30  6:56 UTC|newest]

Thread overview: 216+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  1:59 [PATCH v2 0/5] dax: handling of media errors Vishal Verma
2016-03-30  1:59 ` Vishal Verma
2016-03-30  1:59 ` Vishal Verma
2016-03-30  1:59 ` Vishal Verma
2016-03-30  1:59 ` [PATCH v2 1/5] block, dax: pass blk_dax_ctl through to drivers Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  4:19   ` kbuild test robot
2016-03-30  4:19     ` kbuild test robot
2016-03-30  4:19     ` kbuild test robot
2016-03-30  4:19     ` kbuild test robot
2016-04-15 14:55   ` Jeff Moyer
2016-04-15 14:55     ` Jeff Moyer
2016-04-15 14:55     ` Jeff Moyer
2016-03-30  1:59 ` [PATCH v2 2/5] dax: fallback from pmd to pte on error Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-04-15 14:55   ` Jeff Moyer
2016-04-15 14:55     ` Jeff Moyer
2016-04-15 14:55     ` Jeff Moyer
2016-03-30  1:59 ` [PATCH v2 3/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-04-15 14:56   ` Jeff Moyer
2016-04-15 14:56     ` Jeff Moyer
2016-04-15 14:56     ` Jeff Moyer
2016-03-30  1:59 ` [PATCH v2 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-04-15 15:18   ` Jeff Moyer
2016-04-15 15:18     ` Jeff Moyer
2016-04-15 15:18     ` Jeff Moyer
2016-03-30  1:59 ` [PATCH v2 5/5] dax: handle media errors in dax_do_io Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  1:59   ` Vishal Verma
2016-03-30  3:00   ` kbuild test robot
2016-03-30  3:00     ` kbuild test robot
2016-03-30  3:00     ` kbuild test robot
2016-03-30  3:00     ` kbuild test robot
2016-03-30  3:00     ` kbuild test robot
2016-03-30  3:00     ` kbuild test robot
2016-03-30  6:34   ` Christoph Hellwig
2016-03-30  6:34     ` Christoph Hellwig
2016-03-30  6:34     ` Christoph Hellwig
2016-03-30  6:54     ` Vishal Verma
2016-03-30  6:54       ` Vishal Verma
2016-03-30  6:54       ` Vishal Verma
2016-03-30  6:56       ` Christoph Hellwig [this message]
2016-03-30  6:56         ` Christoph Hellwig
2016-03-30  6:56         ` Christoph Hellwig
2016-04-15 16:11   ` Jeff Moyer
2016-04-15 16:11     ` Jeff Moyer
2016-04-15 16:11     ` Jeff Moyer
2016-04-15 16:54     ` Verma, Vishal L
2016-04-15 16:54       ` Verma, Vishal L
2016-04-15 16:54       ` Verma, Vishal L
2016-04-15 17:11       ` Jeff Moyer
2016-04-15 17:11         ` Jeff Moyer
2016-04-15 17:11         ` Jeff Moyer
2016-04-15 17:11         ` Jeff Moyer
2016-04-15 17:37         ` Verma, Vishal L
2016-04-15 17:37           ` Verma, Vishal L
2016-04-15 17:57           ` Dan Williams
2016-04-15 17:57             ` Dan Williams
2016-04-15 17:57             ` Dan Williams
2016-04-15 18:06             ` Jeff Moyer
2016-04-15 18:06               ` Jeff Moyer
2016-04-15 18:06               ` Jeff Moyer
2016-04-15 18:06               ` Jeff Moyer
2016-04-15 18:17               ` Dan Williams
2016-04-15 18:17                 ` Dan Williams
2016-04-15 18:17                 ` Dan Williams
2016-04-15 18:24                 ` Jeff Moyer
2016-04-15 18:24                   ` Jeff Moyer
2016-04-15 18:24                   ` Jeff Moyer
2016-04-15 18:24                   ` Jeff Moyer
2016-04-15 18:56                   ` Dan Williams
2016-04-15 18:56                     ` Dan Williams
2016-04-15 18:56                     ` Dan Williams
2016-04-15 19:13                     ` Jeff Moyer
2016-04-15 19:13                       ` Jeff Moyer
2016-04-15 19:13                       ` Jeff Moyer
2016-04-15 19:13                       ` Jeff Moyer
2016-04-15 19:01                 ` Toshi Kani
2016-04-15 19:01                   ` Toshi Kani
2016-04-15 19:01                   ` Toshi Kani
2016-04-15 19:01                   ` Toshi Kani
2016-04-15 19:08                   ` Toshi Kani
2016-04-15 19:08                     ` Toshi Kani
2016-04-15 19:08                     ` Toshi Kani
2016-04-15 19:08                     ` Toshi Kani
2016-04-20 20:59     ` Christoph Hellwig
2016-04-20 20:59       ` Christoph Hellwig
2016-04-20 20:59       ` Christoph Hellwig
2016-04-23 18:08       ` Verma, Vishal L
2016-04-23 18:08         ` Verma, Vishal L
2016-04-25  8:31         ` hch
2016-04-25  8:31           ` hch
2016-04-25  8:31           ` hch
2016-04-25 15:32           ` Jeff Moyer
2016-04-25 15:32             ` Jeff Moyer
2016-04-25 15:32             ` Jeff Moyer
2016-04-25 15:32             ` Jeff Moyer
2016-04-26  8:32             ` hch
2016-04-26  8:32               ` hch
2016-04-26  8:32               ` hch
2016-04-25 17:14           ` Verma, Vishal L
2016-04-25 17:14             ` Verma, Vishal L
2016-04-25 17:21             ` Dan Williams
2016-04-25 17:21               ` Dan Williams
2016-04-25 17:21               ` Dan Williams
2016-04-25 23:25             ` Dave Chinner
2016-04-25 23:25               ` Dave Chinner
2016-04-25 23:25               ` Dave Chinner
2016-04-25 23:25               ` Dave Chinner
2016-04-25 23:25               ` Dave Chinner
2016-04-25 23:34               ` Darrick J. Wong
2016-04-25 23:34                 ` Darrick J. Wong
2016-04-25 23:34                 ` Darrick J. Wong
2016-04-25 23:34                 ` Darrick J. Wong
2016-04-25 23:34                 ` Darrick J. Wong
2016-04-25 23:43               ` Dan Williams
2016-04-25 23:43                 ` Dan Williams
2016-04-25 23:43                 ` Dan Williams
2016-04-26  0:11                 ` Dave Chinner
2016-04-26  0:11                   ` Dave Chinner
2016-04-26  0:11                   ` Dave Chinner
2016-04-26  1:45                   ` Dan Williams
2016-04-26  1:45                     ` Dan Williams
2016-04-26  1:45                     ` Dan Williams
2016-04-26  2:56                     ` Dave Chinner
2016-04-26  2:56                       ` Dave Chinner
2016-04-26  2:56                       ` Dave Chinner
2016-04-26  4:18                       ` Dan Williams
2016-04-26  4:18                         ` Dan Williams
2016-04-26  4:18                         ` Dan Williams
2016-04-26  8:27                         ` Dave Chinner
2016-04-26  8:27                           ` Dave Chinner
2016-04-26  8:27                           ` Dave Chinner
2016-04-26 14:59                           ` Dan Williams
2016-04-26 14:59                             ` Dan Williams
2016-04-26 14:59                             ` Dan Williams
2016-04-26 15:31                             ` Jan Kara
2016-04-26 15:31                               ` Jan Kara
2016-04-26 15:31                               ` Jan Kara
2016-04-26 17:16                               ` Dan Williams
2016-04-26 17:16                                 ` Dan Williams
2016-04-26 17:16                                 ` Dan Williams
2016-04-25 23:53               ` Verma, Vishal L
2016-04-25 23:53                 ` Verma, Vishal L
2016-04-25 23:53                 ` Verma, Vishal L
2016-04-26  0:41                 ` Dave Chinner
2016-04-26  0:41                   ` Dave Chinner
2016-04-26  0:41                   ` Dave Chinner
2016-04-26  0:41                   ` Dave Chinner
2016-04-26  0:41                   ` Dave Chinner
2016-04-26 14:58                   ` Vishal Verma
2016-04-26 14:58                     ` Vishal Verma
2016-04-26 14:58                     ` Vishal Verma
2016-04-26 14:58                     ` Vishal Verma
2016-05-02 15:18                   ` Jeff Moyer
2016-05-02 15:18                     ` Jeff Moyer
2016-05-02 15:18                     ` Jeff Moyer
2016-05-02 15:18                     ` Jeff Moyer
2016-05-02 17:53                     ` Dan Williams
2016-05-02 17:53                       ` Dan Williams
2016-05-02 17:53                       ` Dan Williams
2016-05-03  0:42                       ` Dave Chinner
2016-05-03  0:42                         ` Dave Chinner
2016-05-03  0:42                         ` Dave Chinner
2016-05-03  1:26                         ` Rudoff, Andy
2016-05-03  1:26                           ` Rudoff, Andy
2016-05-03  2:49                           ` Dave Chinner
2016-05-03  2:49                             ` Dave Chinner
2016-05-03  2:49                             ` Dave Chinner
2016-05-03 18:30                             ` Rudoff, Andy
2016-05-03 18:30                               ` Rudoff, Andy
2016-05-03 18:30                               ` Rudoff, Andy
2016-05-04  1:36                               ` Dave Chinner
2016-05-04  1:36                                 ` Dave Chinner
2016-05-04  1:36                                 ` Dave Chinner
2016-05-02 23:04                     ` Dave Chinner
2016-05-02 23:04                       ` Dave Chinner
2016-05-02 23:04                       ` Dave Chinner
2016-05-02 23:04                       ` Dave Chinner
2016-05-02 23:04                       ` Dave Chinner
2016-05-02 23:17                       ` Verma, Vishal L
2016-05-02 23:17                         ` Verma, Vishal L
2016-05-02 23:25                       ` Dan Williams
2016-05-02 23:25                         ` Dan Williams
2016-05-02 23:25                         ` Dan Williams
2016-05-03  1:51                         ` Dave Chinner
2016-05-03  1:51                           ` Dave Chinner
2016-05-03  1:51                           ` Dave Chinner
2016-05-03 17:28                           ` Dan Williams
2016-05-03 17:28                             ` Dan Williams
2016-05-03 17:28                             ` Dan Williams
2016-05-04  3:18                             ` Dave Chinner
2016-05-04  3:18                               ` Dave Chinner
2016-05-04  3:18                               ` Dave Chinner
2016-05-04  5:05                               ` Dan Williams
2016-05-04  5:05                                 ` Dan Williams
2016-05-04  5:05                                 ` Dan Williams
2016-04-26  8:33             ` hch
2016-04-26  8:33               ` hch
2016-04-26  8:33               ` hch
2016-04-26 15:01               ` Vishal Verma
2016-04-26 15:01                 ` Vishal Verma
2016-04-26 15:01                 ` Vishal Verma
2016-04-26 15:01                 ` Vishal Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330065646.GA13123@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@fb.com \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=matthew.r.wilcox@intel.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vishal.l.verma@intel.com \
    --cc=vishal@kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.