From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap@vger.kernel.org, Vishal Mahaveer <vishalm@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: DRA722: Add ID detect for Silicon Rev 2.0
Date: Wed, 30 Mar 2016 13:56:45 -0700 [thread overview]
Message-ID: <20160330205644.GB9329@atomide.com> (raw)
In-Reply-To: <56E1F8C6.4020906@ti.com>
* Nishanth Menon <nm@ti.com> [160310 14:44]:
> On 03/09/2016 02:56 PM, Vishal Mahaveer wrote:
> > From: Vishal Mahaveer <vishalm@ti.com>
> >
> > Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision
> > with various fixes including the following:
> > - Reset logic fixes
> > - Few asymetric aging logic fixes
> minor:
> s/asymetric/asymmetric/
I'll update that while applying.
> > - Ethernet speed fixes
> > - EDMA fixes for McASP
> >
> > Signed-off-by: Vishal Mahaveer <vishalm@ti.com>
> > ---
> > arch/arm/mach-omap2/id.c | 4 ++--
> > arch/arm/mach-omap2/soc.h | 1 +
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index 8a2ae82..84ee602 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -667,9 +667,9 @@ void __init dra7xxx_check_revision(void)
> > case 0:
> > omap_revision = DRA722_REV_ES1_0;
> > break;
> > + case 1:
> > default:
> > - /* If we have no new revisions */
> > - omap_revision = DRA722_REV_ES1_0;
> > + omap_revision = DRA722_REV_ES2_0;
> > break;
> > }
> > break;
> > diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h
> > index 83d3547..464e73f 100644
> > --- a/arch/arm/mach-omap2/soc.h
> > +++ b/arch/arm/mach-omap2/soc.h
> > @@ -471,6 +471,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> > #define DRA752_REV_ES1_1 (DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
> > #define DRA752_REV_ES2_0 (DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
> > #define DRA722_REV_ES1_0 (DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
> > +#define DRA722_REV_ES2_0 (DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
> >
> > void omap2xxx_check_revision(void);
> > void omap3xxx_check_revision(void);
> >
> otherwise,
> for me:
> Acked-by: Nishanth Menon <nm@ti.com>
Applying into omap-for-v4.6/fixes thanks.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DRA722: Add ID detect for Silicon Rev 2.0
Date: Wed, 30 Mar 2016 13:56:45 -0700 [thread overview]
Message-ID: <20160330205644.GB9329@atomide.com> (raw)
In-Reply-To: <56E1F8C6.4020906@ti.com>
* Nishanth Menon <nm@ti.com> [160310 14:44]:
> On 03/09/2016 02:56 PM, Vishal Mahaveer wrote:
> > From: Vishal Mahaveer <vishalm@ti.com>
> >
> > Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision
> > with various fixes including the following:
> > - Reset logic fixes
> > - Few asymetric aging logic fixes
> minor:
> s/asymetric/asymmetric/
I'll update that while applying.
> > - Ethernet speed fixes
> > - EDMA fixes for McASP
> >
> > Signed-off-by: Vishal Mahaveer <vishalm@ti.com>
> > ---
> > arch/arm/mach-omap2/id.c | 4 ++--
> > arch/arm/mach-omap2/soc.h | 1 +
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index 8a2ae82..84ee602 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -667,9 +667,9 @@ void __init dra7xxx_check_revision(void)
> > case 0:
> > omap_revision = DRA722_REV_ES1_0;
> > break;
> > + case 1:
> > default:
> > - /* If we have no new revisions */
> > - omap_revision = DRA722_REV_ES1_0;
> > + omap_revision = DRA722_REV_ES2_0;
> > break;
> > }
> > break;
> > diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h
> > index 83d3547..464e73f 100644
> > --- a/arch/arm/mach-omap2/soc.h
> > +++ b/arch/arm/mach-omap2/soc.h
> > @@ -471,6 +471,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> > #define DRA752_REV_ES1_1 (DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
> > #define DRA752_REV_ES2_0 (DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
> > #define DRA722_REV_ES1_0 (DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
> > +#define DRA722_REV_ES2_0 (DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
> >
> > void omap2xxx_check_revision(void);
> > void omap3xxx_check_revision(void);
> >
> otherwise,
> for me:
> Acked-by: Nishanth Menon <nm@ti.com>
Applying into omap-for-v4.6/fixes thanks.
Tony
next prev parent reply other threads:[~2016-03-30 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 20:56 [PATCH] ARM: DRA722: Add ID detect for Silicon Rev 2.0 Vishal Mahaveer
2016-03-09 20:56 ` Vishal Mahaveer
2016-03-10 22:44 ` Nishanth Menon
2016-03-10 22:44 ` Nishanth Menon
2016-03-30 20:56 ` Tony Lindgren [this message]
2016-03-30 20:56 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330205644.GB9329@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.