From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: "moderated list:TPM DEVICE DRIVER"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tpm: remove redundant code from self-test functions
Date: Thu, 31 Mar 2016 09:37:56 +0300 [thread overview]
Message-ID: <20160331063756.GA6393@intel.com> (raw)
In-Reply-To: <20160331054623.GB20504-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote:
> On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote:
>
> > - rc = be32_to_cpu(cmd.header.out.return_code);
> > if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) {
>
> This line is the entire reason it is open coded, I see it being
> removed, but I don't see how the functionality is maintained?
When tpm_trance_cmd() returns a positive number it is the TPM error code
that it returns. tpm_pcr_read() does pass through whatever
tpm_trace_cmd() returns so the above condition should still work as
expected.
> Jason
/Jarkko
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: remove redundant code from self-test functions
Date: Thu, 31 Mar 2016 09:37:56 +0300 [thread overview]
Message-ID: <20160331063756.GA6393@intel.com> (raw)
In-Reply-To: <20160331054623.GB20504@obsidianresearch.com>
On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote:
> On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote:
>
> > - rc = be32_to_cpu(cmd.header.out.return_code);
> > if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) {
>
> This line is the entire reason it is open coded, I see it being
> removed, but I don't see how the functionality is maintained?
When tpm_trance_cmd() returns a positive number it is the TPM error code
that it returns. tpm_pcr_read() does pass through whatever
tpm_trace_cmd() returns so the above condition should still work as
expected.
> Jason
/Jarkko
next prev parent reply other threads:[~2016-03-31 6:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 13:20 [PATCH] tpm: remove redundant code from self-test functions Jarkko Sakkinen
2016-03-30 13:20 ` Jarkko Sakkinen
2016-03-30 13:25 ` Jarkko Sakkinen
[not found] ` <1459344045-21602-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-03-31 5:46 ` Jason Gunthorpe
2016-03-31 5:46 ` Jason Gunthorpe
[not found] ` <20160331054623.GB20504-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-03-31 6:37 ` Jarkko Sakkinen [this message]
2016-03-31 6:37 ` Jarkko Sakkinen
[not found] ` <20160331063756.GA6393-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-02 3:16 ` Jason Gunthorpe
2016-04-02 3:16 ` Jason Gunthorpe
2016-04-05 9:42 ` Jarkko Sakkinen
[not found] ` <20160405094221.GA12672-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-06 14:03 ` Christophe Ricard
[not found] ` <CALD+uuwQnvKL7TsiBXme=P8NKEX2gD1mOx-AxV7OHiBgmi4ykw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-07 11:30 ` Jarkko Sakkinen
2016-04-07 11:30 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2016-03-30 5:37 Jarkko Sakkinen
2016-03-30 5:37 ` Jarkko Sakkinen
[not found] ` <1459316279-32532-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-03-30 6:22 ` kbuild test robot
2016-03-30 6:22 ` kbuild test robot
2016-03-30 6:37 ` Jarkko Sakkinen
2016-03-30 6:37 ` Jarkko Sakkinen
2016-03-30 6:50 ` kbuild test robot
2016-03-30 6:50 ` kbuild test robot
2016-03-30 12:59 ` kbuild test robot
2016-03-30 12:59 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331063756.GA6393@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.