From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip/mxs: fix error check of of_io_request_and_map()
Date: Thu, 31 Mar 2016 14:39:53 +0800 [thread overview]
Message-ID: <20160331063953.GS28207@tiger> (raw)
In-Reply-To: <1457486500-10237-1-git-send-email-vz@mleia.com>
On Wed, Mar 09, 2016 at 03:21:40AM +0200, Vladimir Zapolskiy wrote:
> The of_io_request_and_map() returns a valid pointer in iomem region or
> ERR_PTR(), check for NULL always fails and may cause a NULL pointer
> dereference on error path.
>
> Fixes: 25e34b44313b ("irqchip/mxs: Prepare driver for hardware with different offsets")
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/mxs: fix error check of of_io_request_and_map()
Date: Thu, 31 Mar 2016 14:39:53 +0800 [thread overview]
Message-ID: <20160331063953.GS28207@tiger> (raw)
In-Reply-To: <1457486500-10237-1-git-send-email-vz@mleia.com>
On Wed, Mar 09, 2016 at 03:21:40AM +0200, Vladimir Zapolskiy wrote:
> The of_io_request_and_map() returns a valid pointer in iomem region or
> ERR_PTR(), check for NULL always fails and may cause a NULL pointer
> dereference on error path.
>
> Fixes: 25e34b44313b ("irqchip/mxs: Prepare driver for hardware with different offsets")
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
next prev parent reply other threads:[~2016-03-31 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 1:21 [PATCH] irqchip/mxs: fix error check of of_io_request_and_map() Vladimir Zapolskiy
2016-03-09 1:21 ` Vladimir Zapolskiy
2016-03-10 15:06 ` [tip:irq/core] irqchip/mxs: Fix " tip-bot for Vladimir Zapolskiy
2016-03-31 6:39 ` Shawn Guo [this message]
2016-03-31 6:39 ` [PATCH] irqchip/mxs: fix " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331063953.GS28207@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.