All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
Cc: "moderated list:TPM DEVICE DRIVER"
	<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tpm: cleanup tpm_tis_remove()
Date: Thu, 31 Mar 2016 13:17:13 +0300	[thread overview]
Message-ID: <20160331101713.GB20686@intel.com> (raw)
In-Reply-To: <20160331101536.GA20686-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote:
> Christophe,
> 
> On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote:
> > Created a local variable for the register in order to clean up
> > experession where TPM_GLOBAL_INT_ENABLE is cleared. This expression is
> > horrible to read and makes changing the function uncomfortable because
> > like easily surpass 80 characters.
> 
> Can you test this patch your hardware and reply with Tested-by tag if it
> does? I can then update your iobase patch to apply on top of this.
> 
> I thought it was better idea to simplify the expression a little bit
> than make it even worse mess.

And yes  I'll fix all the typos in the commit msg in this patch before
applying it :)

/Jarkko

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Christophe Ricard <christophe-h.ricard@st.com>
Cc: Marcel Selhorst <tpmdd@selhorst.net>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	"moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@lists.sourceforge.net>,
	open list <linux-kernel@vger.kernel.org>,
	Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH] tpm: cleanup tpm_tis_remove()
Date: Thu, 31 Mar 2016 13:17:13 +0300	[thread overview]
Message-ID: <20160331101713.GB20686@intel.com> (raw)
In-Reply-To: <20160331101536.GA20686@intel.com>

On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote:
> Christophe,
> 
> On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote:
> > Created a local variable for the register in order to clean up
> > experession where TPM_GLOBAL_INT_ENABLE is cleared. This expression is
> > horrible to read and makes changing the function uncomfortable because
> > like easily surpass 80 characters.
> 
> Can you test this patch your hardware and reply with Tested-by tag if it
> does? I can then update your iobase patch to apply on top of this.
> 
> I thought it was better idea to simplify the expression a little bit
> than make it even worse mess.

And yes  I'll fix all the typos in the commit msg in this patch before
applying it :)

/Jarkko

  parent reply	other threads:[~2016-03-31 10:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 10:11 [PATCH] tpm: cleanup tpm_tis_remove() Jarkko Sakkinen
2016-03-31 10:11 ` Jarkko Sakkinen
2016-03-31 10:15 ` Jarkko Sakkinen
     [not found]   ` <20160331101536.GA20686-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-31 10:17     ` Jarkko Sakkinen [this message]
2016-03-31 10:17       ` Jarkko Sakkinen
     [not found]       ` <20160331101713.GB20686-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-31 10:29         ` Jarkko Sakkinen
2016-03-31 10:29           ` Jarkko Sakkinen
     [not found]           ` <20160331102958.GA22364-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-31 10:33             ` Christophe Henri RICARD
2016-03-31 10:33               ` Christophe Henri RICARD
2016-03-31 14:55             ` Christophe Henri RICARD
2016-03-31 14:55               ` Christophe Henri RICARD
     [not found]               ` <8646C2A85C5D44419E1B33F16B0BD501024AFA6B6E-+EwDPpWUVoThJTuQ9jeba9BPR1lH4CV8@public.gmane.org>
2016-03-31 16:19                 ` Jarkko Sakkinen
2016-03-31 16:19                   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331101713.GB20686@intel.com \
    --to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.