From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
kernel@pengutronix.de, sergeimir@emcraft.com, tglx@linutronix.de,
jason@lakedaemon.net, marc.zyngier@arm.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 15/18] ARM: vf610: PM: initial suspend/resume support
Date: Fri, 1 Apr 2016 10:25:07 +0800 [thread overview]
Message-ID: <20160401022507.GF18833@tiger> (raw)
In-Reply-To: <1457576219-7971-16-git-send-email-stefan@agner.ch>
On Wed, Mar 09, 2016 at 06:16:56PM -0800, Stefan Agner wrote:
> Add system suspend and resume support for Vybrid SoC. The standby
> sleep state puts the SoC in STOP mode. The SoC can be woken through
> an interrupt from GPC (Global Power Controller). The GPC can use any
> interrupt as wake-up source. To save power the main PLL1 is bypassed
> and uses the 24MHz on-chip oscillator. However, memory clock need to
> be at full speed, hence the PLL2 needs to be on to keep the memory
> clocked. The mode is completely implemented in C since we can access
> the full memory at all times. The mode provides most power saving
> while being able to be woken by any IRQ as wake-up source.
>
> The mem sleep state (Suspend-to-RAM) uses Vybrid's LPSTOP2 mode. This
> mode powergates most parts of the SoC expect some peripherials such as
> Wake-Up controller (WKPU) or LP RTC. Parts of the internal SRAM is
> retained too. The suspend code written in assembly runs from this SRAM.
> The code puts the main memory (DDR3) into self-refresh mode and takes
> it out of self-refresh mode on resume. Verified with Colibri VF50/VF61
> V1.2A.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/mach-imx/Makefile | 3 +
> arch/arm/mach-imx/common.h | 10 +
> arch/arm/mach-imx/mach-vf610.c | 8 +
> arch/arm/mach-imx/pm-vf610.c | 634 ++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-imx/suspend-vf610.S | 437 ++++++++++++++++++++++++++
> drivers/clk/imx/clk-vf610.c | 17 +
> 6 files changed, 1109 insertions(+)
> create mode 100644 arch/arm/mach-imx/pm-vf610.c
> create mode 100644 arch/arm/mach-imx/suspend-vf610.S
I know this is how we implemented suspend for i.MX6. But this is not
the direction moving forward. When people was pushing a pile of code
adding suspend for i.MX7D, I refused to take it and asked them to push
those hardware details into firmware and use PSCI to implement suspend.
I would like to suggest the same for Vybrid.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/18] ARM: vf610: PM: initial suspend/resume support
Date: Fri, 1 Apr 2016 10:25:07 +0800 [thread overview]
Message-ID: <20160401022507.GF18833@tiger> (raw)
In-Reply-To: <1457576219-7971-16-git-send-email-stefan@agner.ch>
On Wed, Mar 09, 2016 at 06:16:56PM -0800, Stefan Agner wrote:
> Add system suspend and resume support for Vybrid SoC. The standby
> sleep state puts the SoC in STOP mode. The SoC can be woken through
> an interrupt from GPC (Global Power Controller). The GPC can use any
> interrupt as wake-up source. To save power the main PLL1 is bypassed
> and uses the 24MHz on-chip oscillator. However, memory clock need to
> be at full speed, hence the PLL2 needs to be on to keep the memory
> clocked. The mode is completely implemented in C since we can access
> the full memory at all times. The mode provides most power saving
> while being able to be woken by any IRQ as wake-up source.
>
> The mem sleep state (Suspend-to-RAM) uses Vybrid's LPSTOP2 mode. This
> mode powergates most parts of the SoC expect some peripherials such as
> Wake-Up controller (WKPU) or LP RTC. Parts of the internal SRAM is
> retained too. The suspend code written in assembly runs from this SRAM.
> The code puts the main memory (DDR3) into self-refresh mode and takes
> it out of self-refresh mode on resume. Verified with Colibri VF50/VF61
> V1.2A.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/mach-imx/Makefile | 3 +
> arch/arm/mach-imx/common.h | 10 +
> arch/arm/mach-imx/mach-vf610.c | 8 +
> arch/arm/mach-imx/pm-vf610.c | 634 ++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-imx/suspend-vf610.S | 437 ++++++++++++++++++++++++++
> drivers/clk/imx/clk-vf610.c | 17 +
> 6 files changed, 1109 insertions(+)
> create mode 100644 arch/arm/mach-imx/pm-vf610.c
> create mode 100644 arch/arm/mach-imx/suspend-vf610.S
I know this is how we implemented suspend for i.MX6. But this is not
the direction moving forward. When people was pushing a pile of code
adding suspend for i.MX7D, I refused to take it and asked them to push
those hardware details into firmware and use PSCI to implement suspend.
I would like to suggest the same for Vybrid.
Shawn
next prev parent reply other threads:[~2016-04-01 2:25 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 2:16 [PATCH 00/18] ARM: vf610: Suspend/resume with self-refresh mode Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 01/18] irqchip: vf610-gpc: add Vybrid GPC IRQ controller Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-11 3:41 ` Marc Zyngier
2016-03-11 3:41 ` Marc Zyngier
2016-03-11 3:41 ` Marc Zyngier
2016-03-11 18:11 ` Stefan Agner
2016-03-11 18:11 ` Stefan Agner
2016-03-11 18:11 ` Stefan Agner
2016-03-12 0:21 ` Marc Zyngier
2016-03-12 0:21 ` Marc Zyngier
2016-03-31 8:07 ` Shawn Guo
2016-03-31 8:07 ` Shawn Guo
2016-03-10 2:16 ` [PATCH 02/18] ARM: dts: vf610: add GPC as new interrupt parent Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-31 8:21 ` Shawn Guo
2016-03-31 8:21 ` Shawn Guo
2016-03-31 17:53 ` Stefan Agner
2016-03-31 17:53 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 03/18] ARM: dts: vf610-colibri: GPIO wakeup key Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-31 8:19 ` Shawn Guo
2016-03-31 8:19 ` Shawn Guo
2016-03-31 17:55 ` Stefan Agner
2016-03-31 17:55 ` Stefan Agner
2016-03-31 17:55 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 04/18] ARM: dts: vf610: add on-chip SRAM Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-31 8:33 ` Shawn Guo
2016-03-31 8:33 ` Shawn Guo
2016-03-31 17:57 ` Stefan Agner
2016-03-31 17:57 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 05/18] ARM: dts: vf610: add modules required for PM Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-31 8:34 ` Shawn Guo
2016-03-31 8:34 ` Shawn Guo
2016-03-31 8:34 ` Shawn Guo
2016-03-10 2:16 ` [PATCH 06/18] ARM: imx: clk-gate2: allow custom gate configuration Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-31 11:37 ` Shawn Guo
2016-03-31 11:37 ` Shawn Guo
2016-03-31 17:59 ` Stefan Agner
2016-03-31 17:59 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 07/18] ARM: imx: clk-vf610: leave DDR clock on Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 08/18] ARM: clk: add WKPU unit Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-16 1:13 ` Stephen Boyd
2016-03-16 1:13 ` Stephen Boyd
2016-03-10 2:16 ` [PATCH 09/18] ARM: vf610: clk: add suspend/resume support Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-31 11:39 ` Shawn Guo
2016-03-31 11:39 ` Shawn Guo
2016-03-10 2:16 ` [PATCH 10/18] tty: serial: fsl_lpuart: support suspend/resume Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-31 11:41 ` Shawn Guo
2016-03-31 11:41 ` Shawn Guo
2016-03-10 2:16 ` [PATCH 11/18] pinctrl: pinctrl-imx: implement suspend/resume Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 12/18] gpio: vf610: add system PM suspend/resume Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 13/18] ARM: dts: vf610: add WKPU connection to GPIO Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 14/18] gpio: vf610: add support for WKPU unit Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-17 20:00 ` Rob Herring
2016-03-17 20:00 ` Rob Herring
2016-03-17 22:12 ` Stefan Agner
2016-03-17 22:12 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 15/18] ARM: vf610: PM: initial suspend/resume support Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 21:19 ` kbuild test robot
2016-03-10 21:19 ` kbuild test robot
2016-03-10 21:19 ` kbuild test robot
2016-04-01 2:25 ` Shawn Guo [this message]
2016-04-01 2:25 ` Shawn Guo
2016-04-01 6:40 ` Stefan Agner
2016-04-01 6:40 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 16/18] ARM: vf610: PM: enable Suspend-to-RAM only if hardware fixes are in place Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` [PATCH 17/18] Documentation: dt: add Vybrid DDR memory controller bindings Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-10 2:16 ` Stefan Agner
2016-03-18 16:10 ` Rob Herring
2016-03-18 16:10 ` Rob Herring
2016-03-10 2:16 ` [PATCH 18/18] ARM: vf610: PM: enable SNVS access Stefan Agner
2016-03-10 2:16 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401022507.GF18833@tiger \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sergeimir@emcraft.com \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.