From: Heiko Carstens <heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: Sudip Mukherjee
<sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Martin Schwidefsky
<schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matt Redfearn
<matt.redfearn-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] s390: fix build failure
Date: Fri, 1 Apr 2016 16:02:38 +0200 [thread overview]
Message-ID: <20160401140238.GC3965@osiris> (raw)
In-Reply-To: <1459514116-24505-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Fri, Apr 01, 2016 at 01:35:16PM +0100, Sudip Mukherjee wrote:
> s390 defconfig and allmodconfig fails with the error:
> kernel/seccomp.c: In function '__secure_computing_strict':
> kernel/seccomp.c:526:3: error: implicit declaration of function
> 'get_compat_mode1_syscalls'
>
> The retrieval of compat syscall numbers were moved into inline function
> defined in asm-generic header but the asm-generic header was not being
> used by s390.
>
> Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header")
> Cc: Matt Redfearn <matt.redfearn-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
> ---
>
> Tested with s390 defconfig and allmodconfig build.
> Build logs of next-20160401 are at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983952 (allmodconfig)
> and
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983909 (defconfig)
>
> arch/s390/include/asm/seccomp.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/s390/include/asm/seccomp.h b/arch/s390/include/asm/seccomp.h
> index 781a9cf..e10f833 100644
> --- a/arch/s390/include/asm/seccomp.h
> +++ b/arch/s390/include/asm/seccomp.h
> @@ -13,4 +13,6 @@
> #define __NR_seccomp_exit_32 __NR_exit
> #define __NR_seccomp_sigreturn_32 __NR_sigreturn
>
> +#include <asm-generic/seccomp.h>
> +
> #endif /* _ASM_S390_SECCOMP_H */
Applied with a modified changelog, since it makes sense anyway to include
the generic header file.
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
linux-s390@vger.kernel.org,
Matt Redfearn <matt.redfearn@imgtec.com>
Subject: Re: [PATCH] s390: fix build failure
Date: Fri, 1 Apr 2016 16:02:38 +0200 [thread overview]
Message-ID: <20160401140238.GC3965@osiris> (raw)
In-Reply-To: <1459514116-24505-1-git-send-email-sudipm.mukherjee@gmail.com>
On Fri, Apr 01, 2016 at 01:35:16PM +0100, Sudip Mukherjee wrote:
> s390 defconfig and allmodconfig fails with the error:
> kernel/seccomp.c: In function '__secure_computing_strict':
> kernel/seccomp.c:526:3: error: implicit declaration of function
> 'get_compat_mode1_syscalls'
>
> The retrieval of compat syscall numbers were moved into inline function
> defined in asm-generic header but the asm-generic header was not being
> used by s390.
>
> Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header")
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>
> Tested with s390 defconfig and allmodconfig build.
> Build logs of next-20160401 are at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983952 (allmodconfig)
> and
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983909 (defconfig)
>
> arch/s390/include/asm/seccomp.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/s390/include/asm/seccomp.h b/arch/s390/include/asm/seccomp.h
> index 781a9cf..e10f833 100644
> --- a/arch/s390/include/asm/seccomp.h
> +++ b/arch/s390/include/asm/seccomp.h
> @@ -13,4 +13,6 @@
> #define __NR_seccomp_exit_32 __NR_exit
> #define __NR_seccomp_sigreturn_32 __NR_sigreturn
>
> +#include <asm-generic/seccomp.h>
> +
> #endif /* _ASM_S390_SECCOMP_H */
Applied with a modified changelog, since it makes sense anyway to include
the generic header file.
next prev parent reply other threads:[~2016-04-01 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 12:35 [PATCH] s390: fix build failure Sudip Mukherjee
2016-04-01 12:35 ` Sudip Mukherjee
[not found] ` <1459514116-24505-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-01 14:02 ` Heiko Carstens [this message]
2016-04-01 14:02 ` Heiko Carstens
-- strict thread matches above, loose matches on Subject: below --
2015-12-22 6:40 Sudip Mukherjee
2015-12-22 6:51 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401140238.GC3965@osiris \
--to=heiko.carstens-ta70fqpds9bqt0dzr+alfa@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.redfearn-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org \
--cc=schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.