From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Helen Mae Koike Fornazier <helen.koike@collabora.co.uk>
Cc: <linux-media@vger.kernel.org>,
<laurent.pinchart@ideasonboard.com>, <hverkuil@xs4all.nl>
Subject: Re: [PATCH v2] [media] tpg: Export the tpg code from vivid as a module
Date: Fri, 1 Apr 2016 15:22:34 -0300 [thread overview]
Message-ID: <20160401152234.4803ad11@recife.lan> (raw)
In-Reply-To: <1459531093-7071-1-git-send-email-helen.koike@collabora.co.uk>
Hi Helen,
This is just a quick look on it. See below.
Em Fri, 1 Apr 2016 14:18:13 -0300
Helen Mae Koike Fornazier <helen.koike@collabora.co.uk> escreveu:
> The test pattern generator will be used by other drivers as the virtual
> media controller (vimc)
>
> Signed-off-by: Helen Mae Koike Fornazier <helen.koike@collabora.co.uk>
> ---
>
> The patch is based on 'media/master' branch and available at
> https://github.com/helen-fornazier/opw-staging tpg/review/vivid
>
> Changes since last version:
> * module name: tpg -> video-tpg
> * header ifdef/define:
> _TPG_H_ -> _MEDIA_TPG_H_
> _TPG_COLORS_H_ -> _MEDIA_TPG_COLORS_H_
>
> drivers/media/platform/Kconfig | 2 +
> drivers/media/platform/Makefile | 2 +
> drivers/media/platform/tpg/Kconfig | 5 +
> drivers/media/platform/tpg/Makefile | 3 +
> drivers/media/platform/tpg/tpg-colors.c | 1415 ++++++++++++++
> drivers/media/platform/tpg/tpg-core.c | 2334 +++++++++++++++++++++++
> drivers/media/platform/vivid/Kconfig | 1 +
> drivers/media/platform/vivid/Makefile | 2 +-
> drivers/media/platform/vivid/vivid-core.h | 2 +-
> drivers/media/platform/vivid/vivid-tpg-colors.c | 1416 --------------
> drivers/media/platform/vivid/vivid-tpg-colors.h | 68 -
> drivers/media/platform/vivid/vivid-tpg.c | 2314 ----------------------
> drivers/media/platform/vivid/vivid-tpg.h | 598 ------
> include/media/tpg-colors.h | 68 +
> include/media/tpg.h | 597 ++++++
> 15 files changed, 4429 insertions(+), 4398 deletions(-)
> create mode 100644 drivers/media/platform/tpg/Kconfig
> create mode 100644 drivers/media/platform/tpg/Makefile
> create mode 100644 drivers/media/platform/tpg/tpg-colors.c
> create mode 100644 drivers/media/platform/tpg/tpg-core.c
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg-colors.c
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg-colors.h
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg.c
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg.h
> create mode 100644 include/media/tpg-colors.h
> create mode 100644 include/media/tpg.h
Please, generate the patch with -M, for us to see what was changed,
instead of seeing a big diff where (I suspect that) 99% of the code
didn't change.
That helps a lot for us to know what actually changed, without needing
to compare everything line per line.
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 201f5c2..8f7cf86 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -284,6 +284,8 @@ menuconfig V4L_TEST_DRIVERS
>
> if V4L_TEST_DRIVERS
>
> +source "drivers/media/platform/tpg/Kconfig"
> +
> source "drivers/media/platform/vivid/Kconfig"
>
> config VIDEO_VIM2M
> diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
> index bbb7bd1..569dd1a 100644
> --- a/drivers/media/platform/Makefile
> +++ b/drivers/media/platform/Makefile
> @@ -12,6 +12,8 @@ obj-$(CONFIG_VIDEO_OMAP3) += omap3isp/
>
> obj-$(CONFIG_VIDEO_VIU) += fsl-viu.o
>
> +obj-$(CONFIG_VIDEO_TPG) += tpg/
> +obj-$(CONFIG_VIDEO_VIMC) += vimc/
> obj-$(CONFIG_VIDEO_VIVID) += vivid/
> obj-$(CONFIG_VIDEO_VIM2M) += vim2m.o
>
> diff --git a/drivers/media/platform/tpg/Kconfig b/drivers/media/platform/tpg/Kconfig
> new file mode 100644
> index 0000000..1b6b19c0
> --- /dev/null
> +++ b/drivers/media/platform/tpg/Kconfig
> @@ -0,0 +1,5 @@
> +config VIDEO_TPG
> + tristate "Test Pattern Generator (TPG)"
> + default n
> + ---help---
> + Export functions to generate image patterns used in vivid and vimc drivers
No need to have a menu for this. The best would be to do define it as:
config VIDEO_TPG
tristate
depends on VIDEO_VIVID || VIDEO_VIMC
This way, it will be automatically selected if the driver(s) that
needs it is selected, without forcing the user to manually guess the
reverse dependency. It also makes life easier for distros that have
VIDEO_VIVID already enabled.
Regards,
Mauro
next prev parent reply other threads:[~2016-04-01 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1459531093-7071-1-git-send-email-helen.koike@collabora.co.uk>
2016-04-01 17:41 ` [PATCH v2] [media] tpg: Export the tpg code from vivid as a module Hans Verkuil
2016-04-01 18:22 ` Mauro Carvalho Chehab [this message]
2016-04-06 22:16 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401152234.4803ad11@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=helen.koike@collabora.co.uk \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.