From: Hans Verkuil <hverkuil@xs4all.nl>
To: Helen Mae Koike Fornazier <helen.koike@collabora.co.uk>,
linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
mchehab@osg.samsung.com
Subject: Re: [PATCH v2] [media] tpg: Export the tpg code from vivid as a module
Date: Fri, 1 Apr 2016 10:41:24 -0700 [thread overview]
Message-ID: <56FEB2C4.6060308@xs4all.nl> (raw)
In-Reply-To: <1459531093-7071-1-git-send-email-helen.koike@collabora.co.uk>
Hi Helen,
On 04/01/2016 10:18 AM, Helen Mae Koike Fornazier wrote:
> The test pattern generator will be used by other drivers as the virtual
> media controller (vimc)
>
> Signed-off-by: Helen Mae Koike Fornazier <helen.koike@collabora.co.uk>
> ---
>
> The patch is based on 'media/master' branch and available at
> https://github.com/helen-fornazier/opw-staging tpg/review/vivid
>
> Changes since last version:
> * module name: tpg -> video-tpg
> * header ifdef/define:
> _TPG_H_ -> _MEDIA_TPG_H_
> _TPG_COLORS_H_ -> _MEDIA_TPG_COLORS_H_
>
> drivers/media/platform/Kconfig | 2 +
> drivers/media/platform/Makefile | 2 +
> drivers/media/platform/tpg/Kconfig | 5 +
> drivers/media/platform/tpg/Makefile | 3 +
> drivers/media/platform/tpg/tpg-colors.c | 1415 ++++++++++++++
> drivers/media/platform/tpg/tpg-core.c | 2334 +++++++++++++++++++++++
> drivers/media/platform/vivid/Kconfig | 1 +
> drivers/media/platform/vivid/Makefile | 2 +-
> drivers/media/platform/vivid/vivid-core.h | 2 +-
> drivers/media/platform/vivid/vivid-tpg-colors.c | 1416 --------------
> drivers/media/platform/vivid/vivid-tpg-colors.h | 68 -
> drivers/media/platform/vivid/vivid-tpg.c | 2314 ----------------------
> drivers/media/platform/vivid/vivid-tpg.h | 598 ------
> include/media/tpg-colors.h | 68 +
> include/media/tpg.h | 597 ++++++
> 15 files changed, 4429 insertions(+), 4398 deletions(-)
> create mode 100644 drivers/media/platform/tpg/Kconfig
> create mode 100644 drivers/media/platform/tpg/Makefile
> create mode 100644 drivers/media/platform/tpg/tpg-colors.c
> create mode 100644 drivers/media/platform/tpg/tpg-core.c
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg-colors.c
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg-colors.h
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg.c
> delete mode 100644 drivers/media/platform/vivid/vivid-tpg.h
> create mode 100644 include/media/tpg-colors.h
> create mode 100644 include/media/tpg.h
I think this is a good idea, but I would move the module to drivers/media/common and rename it v4l2-tpg.
It is currently closely tied to V4L2, so v4l2-tpg seems a better choice than just plain tpg.
Regards,
Hans
next parent reply other threads:[~2016-04-01 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1459531093-7071-1-git-send-email-helen.koike@collabora.co.uk>
2016-04-01 17:41 ` Hans Verkuil [this message]
2016-04-01 18:22 ` [PATCH v2] [media] tpg: Export the tpg code from vivid as a module Mauro Carvalho Chehab
2016-04-06 22:16 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FEB2C4.6060308@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=helen.koike@collabora.co.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.