From: Kent Overstreet <kent.overstreet@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: Real pagecache iterators
Date: Fri, 1 Apr 2016 15:20:21 -0800 [thread overview]
Message-ID: <20160401232021.GA16071@kmo-pixel> (raw)
In-Reply-To: <20160401155747.249e0f8ed89e00fbb24111d2@linux-foundation.org>
On Fri, Apr 01, 2016 at 03:57:47PM -0700, Andrew Morton wrote:
> On Thu, 31 Mar 2016 18:38:11 -0800 Kent Overstreet <kent.overstreet@gmail.com> wrote:
>
> > Introduce for_each_pagecache_page() and related macros, with the goal of
> > replacing most/all uses of pagevec_lookup().
> >
> > For the most part this shouldn't be a functional change. The one functional
> > difference with the new macros is that they now take an @end parameter, so we're
> > able to avoid grabbing pages in __find_get_pages() that we'll never use.
> >
> > This patch only does some of the conversions, the ones I was able to easily test
> > myself - the conversions are mechanical but tricky enough they generally warrent
> > testing.
>
> What is the reason for this change?
I just got tired of code being hard to follow when I was trying to work on some
pagecache invalidation stuff.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Kent Overstreet <kent.overstreet@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: Real pagecache iterators
Date: Fri, 1 Apr 2016 15:20:21 -0800 [thread overview]
Message-ID: <20160401232021.GA16071@kmo-pixel> (raw)
In-Reply-To: <20160401155747.249e0f8ed89e00fbb24111d2@linux-foundation.org>
On Fri, Apr 01, 2016 at 03:57:47PM -0700, Andrew Morton wrote:
> On Thu, 31 Mar 2016 18:38:11 -0800 Kent Overstreet <kent.overstreet@gmail.com> wrote:
>
> > Introduce for_each_pagecache_page() and related macros, with the goal of
> > replacing most/all uses of pagevec_lookup().
> >
> > For the most part this shouldn't be a functional change. The one functional
> > difference with the new macros is that they now take an @end parameter, so we're
> > able to avoid grabbing pages in __find_get_pages() that we'll never use.
> >
> > This patch only does some of the conversions, the ones I was able to easily test
> > myself - the conversions are mechanical but tricky enough they generally warrent
> > testing.
>
> What is the reason for this change?
I just got tired of code being hard to follow when I was trying to work on some
pagecache invalidation stuff.
next prev parent reply other threads:[~2016-04-01 23:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 1:16 [PATCH] mm: Refactor find_get_pages() & friends Kent Overstreet
2016-03-09 1:16 ` Kent Overstreet
2016-03-29 21:29 ` Andrew Morton
2016-03-29 21:29 ` Andrew Morton
2016-04-01 2:35 ` Kent Overstreet
2016-04-01 2:35 ` Kent Overstreet
2016-04-01 2:38 ` [PATCH 1/2] " Kent Overstreet
2016-04-01 2:38 ` Kent Overstreet
2016-04-01 2:38 ` [PATCH 2/2] mm: Real pagecache iterators Kent Overstreet
2016-04-01 2:38 ` Kent Overstreet
2016-04-01 22:57 ` Andrew Morton
2016-04-01 22:57 ` Andrew Morton
2016-04-01 23:20 ` Kent Overstreet [this message]
2016-04-01 23:20 ` Kent Overstreet
2016-04-27 21:27 ` Andrew Morton
2016-04-27 21:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401232021.GA16071@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.