All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: thermal: tegra: add thermtrip function
Date: Sat, 2 Apr 2016 08:50:45 +0300	[thread overview]
Message-ID: <20160402055045.GA23902@mwanda> (raw)

Hello Wei Ni,

This is a semi-automatic email about new static checker warnings.

The patch ee6d79f202a4: "thermal: tegra: add thermtrip function" from 
Mar 29, 2016, leads to the following Smatch complaint:

drivers/thermal/tegra/soctherm.c:226 thermtrip_program()
	 warn: variable dereferenced before check 'dev' (see line 222)

drivers/thermal/tegra/soctherm.c
   221	{
   222		struct tegra_soctherm *ts = dev_get_drvdata(dev);
                                            ^^^^^^^^^^^^^^^^^^^
Dereference inside function.

   223		int temp;
   224		u32 r;
   225	
   226		if (!dev || !sg)
                    ^^^^
Too late.

   227			return -EINVAL;
   228	

regards,
dan carpenter

             reply	other threads:[~2016-04-02  5:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02  5:50 Dan Carpenter [this message]
2016-04-06  9:01 ` thermal: tegra: add thermtrip function Wei Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160402055045.GA23902@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.