Re: thermal: tegra: add thermtrip function

[Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

Thanks for your check, I will send out patch to fix it.

Thanks.
Wei.


On 2016年04月02日 13:50, Dan Carpenter wrote:
> Hello Wei Ni,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch ee6d79f202a4: "thermal: tegra: add thermtrip function" from 
> Mar 29, 2016, leads to the following Smatch complaint:
> 
> drivers/thermal/tegra/soctherm.c:226 thermtrip_program()
> 	 warn: variable dereferenced before check 'dev' (see line 222)
> 
> drivers/thermal/tegra/soctherm.c
>    221	{
>    222		struct tegra_soctherm *ts = dev_get_drvdata(dev);
>                                             ^^^^^^^^^^^^^^^^^^^
> Dereference inside function.
> 
>    223		int temp;
>    224		u32 r;
>    225	
>    226		if (!dev || !sg)
>                     ^^^^
> Too late.
> 
>    227			return -EINVAL;
>    228	
> 
> regards,
> dan carpenter
>