From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500
Date: Sat, 2 Apr 2016 18:26:56 +0200 [thread overview]
Message-ID: <20160402162656.GG32554@lunn.ch> (raw)
In-Reply-To: <1459601753-31193-1-git-send-email-bert@biot.com>
> + button at 15 {
> + label = "WPS Button";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
> + };
> +
> + button at 16 {
> + label = "Reset Button";
> + linux,code = <KEY_RESTART>;
> + gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> + };
> + };
I'm looking at the warnings the new DT compiler produces....
Buttons should not have a @15, etc, since they don't have a register
property.
If you can, it would be good it you can compile your .dts file using
the dtc compile in linux-next and pass W=1.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Bert Vermeulen <bert-Nh2F35Ii2RQ@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"moderated list:ARM/Marvell Kirkwood and Armada 370, 375,
38x,..."
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500
Date: Sat, 2 Apr 2016 18:26:56 +0200 [thread overview]
Message-ID: <20160402162656.GG32554@lunn.ch> (raw)
In-Reply-To: <1459601753-31193-1-git-send-email-bert-Nh2F35Ii2RQ@public.gmane.org>
> + button@15 {
> + label = "WPS Button";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
> + };
> +
> + button@16 {
> + label = "Reset Button";
> + linux,code = <KEY_RESTART>;
> + gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> + };
> + };
I'm looking at the warnings the new DT compiler produces....
Buttons should not have a @15, etc, since they don't have a register
property.
If you can, it would be good it you can compile your .dts file using
the dtc compile in linux-next and pass W=1.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Bert Vermeulen <bert@biot.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"moderated list:ARM/Marvell Kirkwood and Armada 370, 375,
38x,..." <linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500
Date: Sat, 2 Apr 2016 18:26:56 +0200 [thread overview]
Message-ID: <20160402162656.GG32554@lunn.ch> (raw)
In-Reply-To: <1459601753-31193-1-git-send-email-bert@biot.com>
> + button@15 {
> + label = "WPS Button";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
> + };
> +
> + button@16 {
> + label = "Reset Button";
> + linux,code = <KEY_RESTART>;
> + gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> + };
> + };
I'm looking at the warnings the new DT compiler produces....
Buttons should not have a @15, etc, since they don't have a register
property.
If you can, it would be good it you can compile your .dts file using
the dtc compile in linux-next and pass W=1.
Andrew
next prev parent reply other threads:[~2016-04-02 16:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 12:55 [PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500 Bert Vermeulen
2016-04-02 12:55 ` Bert Vermeulen
2016-04-02 12:55 ` Bert Vermeulen
2016-04-02 16:16 ` Andrew Lunn
2016-04-02 16:16 ` Andrew Lunn
2016-04-02 16:16 ` Andrew Lunn
2016-04-04 11:51 ` Bert Vermeulen
2016-04-04 11:51 ` Bert Vermeulen
2016-04-04 11:51 ` Bert Vermeulen
2016-04-04 12:15 ` Andrew Lunn
2016-04-04 12:15 ` Andrew Lunn
2016-04-02 16:26 ` Andrew Lunn [this message]
2016-04-02 16:26 ` Andrew Lunn
2016-04-02 16:26 ` Andrew Lunn
2016-04-03 9:56 ` Imre Kaloz
2016-04-03 9:56 ` Imre Kaloz
2016-04-03 9:56 ` Imre Kaloz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160402162656.GG32554@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.