[PATCH] unmodified_drivers: enable use of register_oldmem_pfn_is_ram() API

[PATCH] unmodified_drivers: enable use of register_oldmem_pfn_is_ram() API

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

From: Mike Meyer <mike.meyer@teradata.com>

During the investigation of very slow dump times of guest images in
Amazon EC2 instance, it was discovered that the
register_oldmem_pfn_is_ram() API implemented by the upstream kernel
commit 997c136f518c5debd63847e78e2a8694f56dcf90:

        fs/proc/vmcore.c: add hook to read_from_oldmem() to check
                           for non-ram pages

was not being called.  This was due to the PV driver with the call
to register_oldmem_pfn_is_ram() API was not including the
kernel header file that is used to communicate support of the API in the
kernel.  Fix the issue by including the required header file.

Signed-off-by: Mike Meyer <mike.meyer@teradata.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>

--- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c
+++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c
@@ -23,6 +23,7 @@
 #include <linux/kernel.h>
 #include <linux/sched.h>
 #include <linux/errno.h>
+#include <linux/crash_dump.h>
 #include <linux/pci.h>
 #include <linux/init.h>
 #include <linux/version.h>




[-- Attachment #2: pvdrv-include-crash-dump.patch --]
[-- Type: text/plain, Size: 1132 bytes --]

unmodified_drivers: enable use of register_oldmem_pfn_is_ram() API

During the investigation of very slow dump times of guest images in
Amazon EC2 instance, it was discovered that the
register_oldmem_pfn_is_ram() API implemented by the upstream kernel
commit 997c136f518c5debd63847e78e2a8694f56dcf90:

        fs/proc/vmcore.c: add hook to read_from_oldmem() to check
                           for non-ram pages

was not being called.  This was due to the PV driver with the call
to register_oldmem_pfn_is_ram() API was not including the
kernel header file that is used to communicate support of the API in the
kernel.  Fix the issue by including the required header file.

Signed-off-by: Mike Meyer <mike.meyer@teradata.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>

--- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c
+++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c
@@ -23,6 +23,7 @@
 #include <linux/kernel.h>
 #include <linux/sched.h>
 #include <linux/errno.h>
+#include <linux/crash_dump.h>
 #include <linux/pci.h>
 #include <linux/init.h>
 #include <linux/version.h>

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] unmodified_drivers: enable use of register_oldmem_pfn_is_ram() API

[Olaf Hering]

On Mon, Apr 04, Jan Beulich wrote:

> From: Mike Meyer <mike.meyer@teradata.com>
> 
> During the investigation of very slow dump times of guest images in
> Amazon EC2 instance, it was discovered that the
> register_oldmem_pfn_is_ram() API implemented by the upstream kernel
> commit 997c136f518c5debd63847e78e2a8694f56dcf90:
> 
>         fs/proc/vmcore.c: add hook to read_from_oldmem() to check
>                            for non-ram pages
> 
> was not being called.  This was due to the PV driver with the call
> to register_oldmem_pfn_is_ram() API was not including the
> kernel header file that is used to communicate support of the API in the
> kernel.  Fix the issue by including the required header file.
> 
> Signed-off-by: Mike Meyer <mike.meyer@teradata.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Olaf Hering <olaf@aepfle.de>

I'm sure I have tested it at that time, not sure why it used to work a
few years ago.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel