* [PATCH] drm/edid: Fix DMT 1024x768@43Hz (interlaced) timings
@ 2016-04-04 19:36 Paul Parsons
2016-04-05 9:27 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Paul Parsons @ 2016-04-04 19:36 UTC (permalink / raw)
To: dri-devel
One of the VESA DMT timings in drm_dmt_modes[] is slightly off.
1024x768@43Hz (interlaced) vsync_end should be 776, not 772.
This brings it into line with the identical timings in edid_est_modes[].
Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
---
diff -ru a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
--- a/drivers/gpu/drm/drm_edid.c 2016-03-14 04:28:54.000000000 +0000
+++ b/drivers/gpu/drm/drm_edid.c 2016-04-04 20:19:41.113104549 +0100
@@ -204,7 +204,7 @@
DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
/* 0x0f - 1024x768@43Hz, interlace */
{ DRM_MODE("1024x768i", DRM_MODE_TYPE_DRIVER, 44900, 1024, 1032,
- 1208, 1264, 0, 768, 768, 772, 817, 0,
+ 1208, 1264, 0, 768, 768, 776, 817, 0,
DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC |
DRM_MODE_FLAG_INTERLACE) },
/* 0x10 - 1024x768@60Hz */
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/edid: Fix DMT 1024x768@43Hz (interlaced) timings
2016-04-04 19:36 [PATCH] drm/edid: Fix DMT 1024x768@43Hz (interlaced) timings Paul Parsons
@ 2016-04-05 9:27 ` Ville Syrjälä
2016-04-05 10:26 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjälä @ 2016-04-05 9:27 UTC (permalink / raw)
To: Paul Parsons; +Cc: dri-devel
On Mon, Apr 04, 2016 at 08:36:34PM +0100, Paul Parsons wrote:
> One of the VESA DMT timings in drm_dmt_modes[] is slightly off.
> 1024x768@43Hz (interlaced) vsync_end should be 776, not 772.
> This brings it into line with the identical timings in edid_est_modes[].
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>
> diff -ru a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> --- a/drivers/gpu/drm/drm_edid.c 2016-03-14 04:28:54.000000000 +0000
> +++ b/drivers/gpu/drm/drm_edid.c 2016-04-04 20:19:41.113104549 +0100
> @@ -204,7 +204,7 @@
> DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
> /* 0x0f - 1024x768@43Hz, interlace */
> { DRM_MODE("1024x768i", DRM_MODE_TYPE_DRIVER, 44900, 1024, 1032,
> - 1208, 1264, 0, 768, 768, 772, 817, 0,
> + 1208, 1264, 0, 768, 768, 776, 817, 0,
> DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC |
> DRM_MODE_FLAG_INTERLACE) },
> /* 0x10 - 1024x768@60Hz */
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/edid: Fix DMT 1024x768@43Hz (interlaced) timings
2016-04-05 9:27 ` Ville Syrjälä
@ 2016-04-05 10:26 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2016-04-05 10:26 UTC (permalink / raw)
To: Ville Syrjälä, Paul Parsons; +Cc: dri-devel
On Tue, 05 Apr 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Apr 04, 2016 at 08:36:34PM +0100, Paul Parsons wrote:
>> One of the VESA DMT timings in drm_dmt_modes[] is slightly off.
>> 1024x768@43Hz (interlaced) vsync_end should be 776, not 772.
>> This brings it into line with the identical timings in edid_est_modes[].
>>
>> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to our topic/drm-fixes, thanks for the patch and review.
BR,
Jani.
>
>> ---
>>
>> diff -ru a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> --- a/drivers/gpu/drm/drm_edid.c 2016-03-14 04:28:54.000000000 +0000
>> +++ b/drivers/gpu/drm/drm_edid.c 2016-04-04 20:19:41.113104549 +0100
>> @@ -204,7 +204,7 @@
>> DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
>> /* 0x0f - 1024x768@43Hz, interlace */
>> { DRM_MODE("1024x768i", DRM_MODE_TYPE_DRIVER, 44900, 1024, 1032,
>> - 1208, 1264, 0, 768, 768, 772, 817, 0,
>> + 1208, 1264, 0, 768, 768, 776, 817, 0,
>> DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC |
>> DRM_MODE_FLAG_INTERLACE) },
>> /* 0x10 - 1024x768@60Hz */
>>
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-05 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-04 19:36 [PATCH] drm/edid: Fix DMT 1024x768@43Hz (interlaced) timings Paul Parsons
2016-04-05 9:27 ` Ville Syrjälä
2016-04-05 10:26 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.