* [PATCH] intel-iommu: fix up comment
@ 2016-03-23 18:34 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2016-03-23 18:34 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: David Woodhouse, Jiang Liu,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
dma_pte_free_pagetable no longer depends on
last level ptes being clear, it clears them itself.
Fix up the comment to match.
Cc: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Suggested-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
drivers/iommu/intel-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index a2e1b7f..0100553 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -1143,7 +1143,7 @@ next:
} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
}
-/* free page table pages. last level pte should already be cleared */
+/* clear last level (leaf) ptes and free page table pages. */
static void dma_pte_free_pagetable(struct dmar_domain *domain,
unsigned long start_pfn,
unsigned long last_pfn)
--
MST
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] intel-iommu: fix up comment
@ 2016-03-23 18:34 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2016-03-23 18:34 UTC (permalink / raw)
To: linux-kernel
Cc: Jiang Liu, Alex Williamson, David Woodhouse, Joerg Roedel, iommu
dma_pte_free_pagetable no longer depends on
last level ptes being clear, it clears them itself.
Fix up the comment to match.
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Suggested-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/iommu/intel-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index a2e1b7f..0100553 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -1143,7 +1143,7 @@ next:
} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
}
-/* free page table pages. last level pte should already be cleared */
+/* clear last level (leaf) ptes and free page table pages. */
static void dma_pte_free_pagetable(struct dmar_domain *domain,
unsigned long start_pfn,
unsigned long last_pfn)
--
MST
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1458757421-4058-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] intel-iommu: fix up comment
2016-03-23 18:34 ` Michael S. Tsirkin
@ 2016-04-05 8:38 ` Michael S. Tsirkin
-1 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2016-04-05 8:38 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: David Woodhouse, Jiang Liu,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
>
> Cc: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Suggested-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Anyone?
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index a2e1b7f..0100553 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -1143,7 +1143,7 @@ next:
> } while (!first_pte_in_page(++pte) && pfn <= last_pfn);
> }
>
> -/* free page table pages. last level pte should already be cleared */
> +/* clear last level (leaf) ptes and free page table pages. */
> static void dma_pte_free_pagetable(struct dmar_domain *domain,
> unsigned long start_pfn,
> unsigned long last_pfn)
> --
> MST
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] intel-iommu: fix up comment
@ 2016-04-05 8:38 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2016-04-05 8:38 UTC (permalink / raw)
To: linux-kernel
Cc: Jiang Liu, Alex Williamson, David Woodhouse, Joerg Roedel, iommu
On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
>
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Anyone?
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index a2e1b7f..0100553 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -1143,7 +1143,7 @@ next:
> } while (!first_pte_in_page(++pte) && pfn <= last_pfn);
> }
>
> -/* free page table pages. last level pte should already be cleared */
> +/* clear last level (leaf) ptes and free page table pages. */
> static void dma_pte_free_pagetable(struct dmar_domain *domain,
> unsigned long start_pfn,
> unsigned long last_pfn)
> --
> MST
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] intel-iommu: fix up comment
2016-03-23 18:34 ` Michael S. Tsirkin
@ 2016-04-05 15:01 ` Joerg Roedel
-1 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2016-04-05 15:01 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: David Woodhouse, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Jiang Liu
On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
>
> Cc: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Suggested-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied. I changed the subject to:
x86/vt-d: Fix comment for dma_pte_free_pagetable()
Please use similar format for iommu-patches in the future.
Thanks,
Joerg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] intel-iommu: fix up comment
@ 2016-04-05 15:01 ` Joerg Roedel
0 siblings, 0 replies; 6+ messages in thread
From: Joerg Roedel @ 2016-04-05 15:01 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Jiang Liu, Alex Williamson, David Woodhouse, iommu
On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
>
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied. I changed the subject to:
x86/vt-d: Fix comment for dma_pte_free_pagetable()
Please use similar format for iommu-patches in the future.
Thanks,
Joerg
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-05 15:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-23 18:34 [PATCH] intel-iommu: fix up comment Michael S. Tsirkin
2016-03-23 18:34 ` Michael S. Tsirkin
[not found] ` <1458757421-4058-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-04-05 8:38 ` Michael S. Tsirkin
2016-04-05 8:38 ` Michael S. Tsirkin
2016-04-05 15:01 ` Joerg Roedel
2016-04-05 15:01 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.