From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: cn_wyl2003-KN7UnAbNpbg@public.gmane.org
Cc: will.deacon-5wv7dgnIgG8@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yalin.wang2010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org,
renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org
Subject: Re: [PATCH] iommu: change generic_device_group function
Date: Tue, 5 Apr 2016 17:04:08 +0200 [thread overview]
Message-ID: <20160405150408.GF11519@8bytes.org> (raw)
In-Reply-To: <1458907611-19694-1-git-send-email-cn_wyl2003-KN7UnAbNpbg@public.gmane.org>
On Fri, Mar 25, 2016 at 08:06:51PM +0800, cn_wyl2003-KN7UnAbNpbg@public.gmane.org wrote:
> From: yalin wang <yalin.wang2010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> change this function to return only iommu_group* pointer or
> PTR_ERR(), never return NULL when failed.
> The caller of this function only check IS_ERR() for its return value.
>
> Signed-off-by: yalin wang <yalin.wang2010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
You are right, thanks for catching this. But please leave the
generic_device_group function in iommu.c. It is assigned to a function
pointer by drivers, so inlining it doesn't make sense anyway.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: cn_wyl2003@126.com
Cc: will.deacon@arm.com, alex.williamson@redhat.com,
renesas@opensource.se, yalin.wang2010@gmail.com,
nicolas.iooss_linux@m4x.org, robin.murphy@arm.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: change generic_device_group function
Date: Tue, 5 Apr 2016 17:04:08 +0200 [thread overview]
Message-ID: <20160405150408.GF11519@8bytes.org> (raw)
In-Reply-To: <1458907611-19694-1-git-send-email-cn_wyl2003@126.com>
On Fri, Mar 25, 2016 at 08:06:51PM +0800, cn_wyl2003@126.com wrote:
> From: yalin wang <yalin.wang2010@gmail.com>
>
> change this function to return only iommu_group* pointer or
> PTR_ERR(), never return NULL when failed.
> The caller of this function only check IS_ERR() for its return value.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
You are right, thanks for catching this. But please leave the
generic_device_group function in iommu.c. It is assigned to a function
pointer by drivers, so inlining it doesn't make sense anyway.
Joerg
next prev parent reply other threads:[~2016-04-05 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 12:06 [PATCH] iommu: change generic_device_group function cn_wyl2003
[not found] ` <1458907611-19694-1-git-send-email-cn_wyl2003-KN7UnAbNpbg@public.gmane.org>
2016-04-05 15:04 ` Joerg Roedel [this message]
2016-04-05 15:04 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405150408.GF11519@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=cn_wyl2003-KN7UnAbNpbg@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org \
--cc=renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=yalin.wang2010-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.