From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: imx6: rework GPC to support multiple power domains
Date: Thu, 7 Apr 2016 10:48:57 +0800 [thread overview]
Message-ID: <20160407024857.GA3111@x250> (raw)
In-Reply-To: <1458128514-9560-2-git-send-email-l.stach@pengutronix.de>
On Wed, Mar 16, 2016 at 12:41:53PM +0100, Lucas Stach wrote:
> This largely reworks the GPC driver to better accommodate multiple
> power domains. This allows to extend the driver to support more domains
> (like present on i.MX6SX) easily later on.
>
> Compatibility to the old DT bindings is provided to keep the currently
> supported i.MX6 devices working with the same feature level as before.
> New DTs and SoC support should only use the new binding from now on.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2: correct spelling in commit message
> ---
> arch/arm/mach-imx/gpc.c | 435 ++++++++++++++++++++++++++++++++++++------------
> 1 file changed, 329 insertions(+), 106 deletions(-)
There are too many changes in this single patch. It makes the review
quite difficult. Is it possible to split it a bit into some incremental
patches?
Also please rebase against v4.6-rc1, which has the commit eaa2d73ef998
(ARM: imx6: pm: declare pm domain latency on power_state struct)
conflicting with your changes.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
patchwork-lst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v2 2/3] ARM: imx6: rework GPC to support multiple power domains
Date: Thu, 7 Apr 2016 10:48:57 +0800 [thread overview]
Message-ID: <20160407024857.GA3111@x250> (raw)
In-Reply-To: <1458128514-9560-2-git-send-email-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, Mar 16, 2016 at 12:41:53PM +0100, Lucas Stach wrote:
> This largely reworks the GPC driver to better accommodate multiple
> power domains. This allows to extend the driver to support more domains
> (like present on i.MX6SX) easily later on.
>
> Compatibility to the old DT bindings is provided to keep the currently
> supported i.MX6 devices working with the same feature level as before.
> New DTs and SoC support should only use the new binding from now on.
>
> Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
> v2: correct spelling in commit message
> ---
> arch/arm/mach-imx/gpc.c | 435 ++++++++++++++++++++++++++++++++++++------------
> 1 file changed, 329 insertions(+), 106 deletions(-)
There are too many changes in this single patch. It makes the review
quite difficult. Is it possible to split it a bit into some incremental
patches?
Also please rebase against v4.6-rc1, which has the commit eaa2d73ef998
(ARM: imx6: pm: declare pm domain latency on power_state struct)
conflicting with your changes.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-07 2:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 11:41 [PATCH v2 1/3] dt-bindings: add multidomain support to i.MX GPC DT binding Lucas Stach
2016-03-16 11:41 ` Lucas Stach
2016-03-16 11:41 ` [PATCH v2 2/3] ARM: imx6: rework GPC to support multiple power domains Lucas Stach
2016-03-16 11:41 ` Lucas Stach
2016-04-07 2:48 ` Shawn Guo [this message]
2016-04-07 2:48 ` Shawn Guo
2016-04-29 12:43 ` Lucas Stach
2016-04-29 12:43 ` Lucas Stach
2016-03-16 11:41 ` [PATCH v2 3/3] ARM: imx6: adopt DT to new GPC binding Lucas Stach
2016-03-16 11:41 ` Lucas Stach
2016-04-07 2:50 ` Shawn Guo
2016-04-07 2:50 ` Shawn Guo
2016-03-18 21:25 ` [PATCH v2 1/3] dt-bindings: add multidomain support to i.MX GPC DT binding Rob Herring
2016-03-18 21:25 ` Rob Herring
2016-03-22 13:02 ` Lucas Stach
2016-03-22 13:02 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407024857.GA3111@x250 \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.