From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com,
gregkh@linuxfoundation.org, eunb.song@samsung.com,
minchan@kernel.org, chanho.min@lge.com, kyungsik.lee@lge.com
Subject: Re: [PATCH v2 2/2] lib: lz4: cleanup unaligned access efficiency detection
Date: Sun, 10 Apr 2016 11:40:06 +0900 [thread overview]
Message-ID: <20160410024006.GA695@swordfish> (raw)
In-Reply-To: <1460235935-1003-3-git-send-email-rsalvaterra@gmail.com>
On (04/09/16 22:05), Rui Salvaterra wrote:
> These identifiers are bogus. The interested architectures should define
> HAVE_EFFICIENT_UNALIGNED_ACCESS whenever relevant to do so. If this
> isn't true for some arch, it should be fixed in the arch definition.
yes, besides ARM_EFFICIENT_UNALIGNED_ACCESS exists only in lib/lz4/lz4defs.h
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> ---
> lib/lz4/lz4defs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h
> index 0710a62..c79d7ea 100644
> --- a/lib/lz4/lz4defs.h
> +++ b/lib/lz4/lz4defs.h
> @@ -24,9 +24,7 @@
> typedef struct _U16_S { u16 v; } U16_S;
> typedef struct _U32_S { u32 v; } U32_S;
> typedef struct _U64_S { u64 v; } U64_S;
> -#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) \
> - || defined(CONFIG_ARM) && __LINUX_ARM_ARCH__ >= 6 \
> - && defined(ARM_EFFICIENT_UNALIGNED_ACCESS)
> +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
>
> #define A16(x) (((U16_S *)(x))->v)
> #define A32(x) (((U32_S *)(x))->v)
> --
> 2.7.4
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com,
gregkh@linuxfoundation.org, eunb.song@samsung.com,
minchan@kernel.org, chanho.min@lge.com, kyungsik.lee@lge.com
Subject: Re: [PATCH v2 2/2] lib: lz4: cleanup unaligned access efficiency detection
Date: Sun, 10 Apr 2016 11:40:06 +0900 [thread overview]
Message-ID: <20160410024006.GA695@swordfish> (raw)
In-Reply-To: <1460235935-1003-3-git-send-email-rsalvaterra@gmail.com>
On (04/09/16 22:05), Rui Salvaterra wrote:
> These identifiers are bogus. The interested architectures should define
> HAVE_EFFICIENT_UNALIGNED_ACCESS whenever relevant to do so. If this
> isn't true for some arch, it should be fixed in the arch definition.
yes, besides ARM_EFFICIENT_UNALIGNED_ACCESS exists only in lib/lz4/lz4defs.h
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> ---
> lib/lz4/lz4defs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h
> index 0710a62..c79d7ea 100644
> --- a/lib/lz4/lz4defs.h
> +++ b/lib/lz4/lz4defs.h
> @@ -24,9 +24,7 @@
> typedef struct _U16_S { u16 v; } U16_S;
> typedef struct _U32_S { u32 v; } U32_S;
> typedef struct _U64_S { u64 v; } U64_S;
> -#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) \
> - || defined(CONFIG_ARM) && __LINUX_ARM_ARCH__ >= 6 \
> - && defined(ARM_EFFICIENT_UNALIGNED_ACCESS)
> +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
>
> #define A16(x) (((U16_S *)(x))->v)
> #define A32(x) (((U32_S *)(x))->v)
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-04-10 1:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 21:05 [PATCH v2 0/2] lib: lz4: fix for big endian and cleanup Rui Salvaterra
2016-04-09 21:05 ` Rui Salvaterra
2016-04-09 21:05 ` [PATCH v2 1/2] lib: lz4: fixed zram with lz4 on big endian machines Rui Salvaterra
2016-04-09 21:05 ` Rui Salvaterra
2016-04-10 2:41 ` Sergey Senozhatsky
2016-04-10 2:41 ` Sergey Senozhatsky
2016-04-09 21:05 ` [PATCH v2 2/2] lib: lz4: cleanup unaligned access efficiency detection Rui Salvaterra
2016-04-09 21:05 ` Rui Salvaterra
2016-04-10 2:40 ` Sergey Senozhatsky [this message]
2016-04-10 2:40 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160410024006.GA695@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=chanho.min@lge.com \
--cc=eunb.song@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyungsik.lee@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.