From: Lee Jones <lee.jones@linaro.org>
To: Henry Chen <henryc.chen@mediatek.com>, tglx@linutronix.de
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
John Crispin <blogic@openwrt.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Flora Fu <flora.fu@mediatek.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove.
Date: Mon, 11 Apr 2016 09:53:23 +0100 [thread overview]
Message-ID: <20160411085323.GM4592@x1> (raw)
In-Reply-To: <1460098729-25549-2-git-send-email-henryc.chen@mediatek.com>
FAO Thomas,
On Fri, 08 Apr 2016, Henry Chen wrote:
> It is possible that pmic->irq_domain will be NULL in fail_irq error handling.
> Check before calling irq_domain_remove.
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> drivers/mfd/mt6397-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index a879223..15050cb 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -312,7 +312,8 @@ static int mt6397_probe(struct platform_device *pdev)
>
> fail_irq:
> if (ret) {
> - irq_domain_remove(pmic->irq_domain);
> + if (pmic->irq_domain)
> + irq_domain_remove(pmic->irq_domain);
You might be better off making this change in the framework.
Just get irq_domain_remove() to harmlessly return if !irq_domain.
> dev_err(&pdev->dev, "failed to add child devices: %d\n", ret);
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove.
Date: Mon, 11 Apr 2016 09:53:23 +0100 [thread overview]
Message-ID: <20160411085323.GM4592@x1> (raw)
In-Reply-To: <1460098729-25549-2-git-send-email-henryc.chen@mediatek.com>
FAO Thomas,
On Fri, 08 Apr 2016, Henry Chen wrote:
> It is possible that pmic->irq_domain will be NULL in fail_irq error handling.
> Check before calling irq_domain_remove.
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> drivers/mfd/mt6397-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index a879223..15050cb 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -312,7 +312,8 @@ static int mt6397_probe(struct platform_device *pdev)
>
> fail_irq:
> if (ret) {
> - irq_domain_remove(pmic->irq_domain);
> + if (pmic->irq_domain)
> + irq_domain_remove(pmic->irq_domain);
You might be better off making this change in the framework.
Just get irq_domain_remove() to harmlessly return if !irq_domain.
> dev_err(&pdev->dev, "failed to add child devices: %d\n", ret);
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-04-11 8:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 6:58 [PATCH v2 1/3] mfd: mt6397: irq domain should initialize before mfd_add_devices() Henry Chen
2016-04-08 6:58 ` Henry Chen
2016-04-08 6:58 ` Henry Chen
2016-04-08 6:58 ` [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove Henry Chen
2016-04-08 6:58 ` Henry Chen
2016-04-08 6:58 ` Henry Chen
2016-04-11 8:53 ` Lee Jones [this message]
2016-04-11 8:53 ` Lee Jones
2016-04-08 6:58 ` [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq Henry Chen
2016-04-08 6:58 ` Henry Chen
2016-04-08 6:58 ` Henry Chen
2016-04-11 8:50 ` Lee Jones
2016-04-11 8:50 ` Lee Jones
2016-04-13 5:48 ` Henry Chen
2016-04-13 5:48 ` Henry Chen
2016-04-13 5:48 ` Henry Chen
2016-04-11 8:56 ` [PATCH v2 1/3] mfd: mt6397: irq domain should initialize before mfd_add_devices() Lee Jones
2016-04-11 8:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411085323.GM4592@x1 \
--to=lee.jones@linaro.org \
--cc=blogic@openwrt.org \
--cc=flora.fu@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.