From: Mark Rutland <mark.rutland@arm.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Hauke Mehrtens <hauke@hauke-m.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: iproc: Support DT property for ignoring aborts when probing
Date: Mon, 11 Apr 2016 09:57:59 +0100 [thread overview]
Message-ID: <20160411085759.GA7088@leverpostej> (raw)
In-Reply-To: <1460238624-2086-1-git-send-email-zajec5@gmail.com>
Please Cc the device tree mailing list (devicetree@vger.kernel.org) when
sending device tree patches.
On Sat, Apr 09, 2016 at 11:50:23PM +0200, Rafał Miłecki wrote:
> Some devices (e.g. Northstar ones) may have bridges that forward
> harmless errors to the ARM core. In such case we need an option to
> add a handler ignoring them.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> .../devicetree/bindings/pci/brcm,iproc-pcie.txt | 6 ++++++
> drivers/pci/host/pcie-iproc-platform.c | 2 ++
> drivers/pci/host/pcie-iproc.c | 17 +++++++++++++++++
> drivers/pci/host/pcie-iproc.h | 1 +
> 4 files changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> index 01b88f4..c91b20a 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> @@ -22,6 +22,12 @@ Optional properties:
>
> - brcm,pcie-ob: Some iProc SoCs do not have the outbound address mapping done
> by the ASIC after power on reset. In this case, SW needs to configure it
> +- brcm,pcie-hook-abort-handler: During PCI bus probing (device enumeration)
> + there can be errors that are expected and harmless. Unfortunately some bridges
> + can't be configured to ignore them and they forward them to the ARM core
> + triggering die().
> + This property should be set in such case, it will make driver add its own
> + handler ignoring such errors.
Rather than describing what the kernel should do, this should describe
the property of the hardware (e.g. this should be named something like
brcm,spurious-probing-abort).
Is there absolutely no mechanism to disable this, even if
board-specific?
Are the aborts synchronous or asynchronous?
When specifically do they actually occur?
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] PCI: iproc: Support DT property for ignoring aborts when probing
Date: Mon, 11 Apr 2016 09:57:59 +0100 [thread overview]
Message-ID: <20160411085759.GA7088@leverpostej> (raw)
In-Reply-To: <1460238624-2086-1-git-send-email-zajec5@gmail.com>
Please Cc the device tree mailing list (devicetree at vger.kernel.org) when
sending device tree patches.
On Sat, Apr 09, 2016 at 11:50:23PM +0200, Rafa? Mi?ecki wrote:
> Some devices (e.g. Northstar ones) may have bridges that forward
> harmless errors to the ARM core. In such case we need an option to
> add a handler ignoring them.
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
> .../devicetree/bindings/pci/brcm,iproc-pcie.txt | 6 ++++++
> drivers/pci/host/pcie-iproc-platform.c | 2 ++
> drivers/pci/host/pcie-iproc.c | 17 +++++++++++++++++
> drivers/pci/host/pcie-iproc.h | 1 +
> 4 files changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> index 01b88f4..c91b20a 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> @@ -22,6 +22,12 @@ Optional properties:
>
> - brcm,pcie-ob: Some iProc SoCs do not have the outbound address mapping done
> by the ASIC after power on reset. In this case, SW needs to configure it
> +- brcm,pcie-hook-abort-handler: During PCI bus probing (device enumeration)
> + there can be errors that are expected and harmless. Unfortunately some bridges
> + can't be configured to ignore them and they forward them to the ARM core
> + triggering die().
> + This property should be set in such case, it will make driver add its own
> + handler ignoring such errors.
Rather than describing what the kernel should do, this should describe
the property of the hardware (e.g. this should be named something like
brcm,spurious-probing-abort).
Is there absolutely no mechanism to disable this, even if
board-specific?
Are the aborts synchronous or asynchronous?
When specifically do they actually occur?
Thanks,
Mark.
next prev parent reply other threads:[~2016-04-11 8:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 21:50 [PATCH 1/2] PCI: iproc: Support DT property for ignoring aborts when probing Rafał Miłecki
2016-04-09 21:50 ` Rafał Miłecki
2016-04-09 21:50 ` [PATCH 2/2] PCI: iproc: Enable hooking abort handler on devices with bcma Rafał Miłecki
2016-04-09 21:50 ` Rafał Miłecki
2016-04-10 2:59 ` [PATCH 1/2] PCI: iproc: Support DT property for ignoring aborts when probing kbuild test robot
2016-04-10 2:59 ` kbuild test robot
2016-04-10 10:54 ` Rafał Miłecki
2016-04-10 10:54 ` Rafał Miłecki
2016-04-11 1:43 ` Florian Fainelli
2016-04-11 1:43 ` Florian Fainelli
2016-04-11 20:06 ` Ray Jui
2016-04-11 21:55 ` Florian Fainelli
2016-04-11 21:55 ` Florian Fainelli
2016-04-11 22:24 ` Ray Jui
2016-04-11 22:26 ` Scott Branden
2016-04-11 22:34 ` Ray Jui
2016-04-11 22:41 ` Florian Fainelli
2016-04-11 22:41 ` Florian Fainelli
2016-04-11 22:51 ` Ray Jui
2016-04-11 22:51 ` Florian Fainelli
2016-04-11 22:51 ` Florian Fainelli
2016-04-17 15:54 ` Rafał Miłecki
2016-04-17 15:54 ` Rafał Miłecki
2016-04-17 14:02 ` Arnd Bergmann
2016-04-17 14:02 ` Arnd Bergmann
2016-04-18 17:47 ` Ray Jui
2016-04-20 18:18 ` Ray Jui
2016-10-28 15:31 ` Rafał Miłecki
2016-10-28 15:31 ` Rafał Miłecki
2016-10-28 16:58 ` Ray Jui
2016-10-28 17:04 ` Florian Fainelli
2016-10-28 17:04 ` Florian Fainelli
2016-10-29 6:14 ` Rafał Miłecki
2016-10-29 6:14 ` Rafał Miłecki
2016-04-11 8:57 ` Mark Rutland [this message]
2016-04-11 8:57 ` Mark Rutland
2016-04-17 15:43 ` Rafał Miłecki
2016-04-17 15:43 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411085759.GA7088@leverpostej \
--to=mark.rutland@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.