Re: [PATCH 1/5] regulator: core: Resolve supply earlier

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Mon, Apr 11, 2016 at 03:03:00PM +0100, Mark Brown wrote:
> On Thu, Apr 07, 2016 at 04:22:35PM +0200, Thierry Reding wrote:
> 
> > +	/*
> > +	 * set_machine_constraints() needs the supply to be resolved in order
> > +	 * to support querying the current voltage in bypass mode. Resolve it
> > +	 * here to more easily handle deferred probing.
> > +	 */
> > +	ret = regulator_resolve_supply(rdev);
> > +	if (ret < 0)
> > +		goto scrub;
> 
> This shouldn't be a hard dependency: most regulators won't be in bypass
> mode or otherwise depend on their parents enough to need this.

I had initially proposed to resolve the supply only when necessary
during regulator_get_voltage() when checking for bypass, perhaps that
would after all be more appropriate here?

Alternatively I guess we could conditionalize on bypass mode before
resolving the supply early here, but I'm not sure how well that would
work given how early in the regulator setup we are at this point.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]