From: Michal Hocko <mhocko@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: mmotm woes, mainly compaction
Date: Tue, 12 Apr 2016 16:51:37 +0200 [thread overview]
Message-ID: <20160412145136.GA4387@dhcp22.suse.cz> (raw)
In-Reply-To: <20160412121020.GC10771@dhcp22.suse.cz>
On Tue 12-04-16 14:10:20, Michal Hocko wrote:
[...]
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6d1da0ceaf1e..d80c9755ffc7 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3030,8 +3030,8 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags,
> * failure could be caused by weak migration mode.
> */
> if (compaction_failed(compact_result)) {
> - if (*migrate_mode == MIGRATE_ASYNC) {
> - *migrate_mode = MIGRATE_SYNC_LIGHT;
> + if (*migrate_mode < MIGRATE_SYNC) {
> + *migrate_mode++;
> return true;
this should be (*migrate_mode)++ of course.
> }
> return false;
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: mmotm woes, mainly compaction
Date: Tue, 12 Apr 2016 16:51:37 +0200 [thread overview]
Message-ID: <20160412145136.GA4387@dhcp22.suse.cz> (raw)
In-Reply-To: <20160412121020.GC10771@dhcp22.suse.cz>
On Tue 12-04-16 14:10:20, Michal Hocko wrote:
[...]
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6d1da0ceaf1e..d80c9755ffc7 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3030,8 +3030,8 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags,
> * failure could be caused by weak migration mode.
> */
> if (compaction_failed(compact_result)) {
> - if (*migrate_mode == MIGRATE_ASYNC) {
> - *migrate_mode = MIGRATE_SYNC_LIGHT;
> + if (*migrate_mode < MIGRATE_SYNC) {
> + *migrate_mode++;
> return true;
this should be (*migrate_mode)++ of course.
> }
> return false;
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-04-12 14:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 7:18 mmotm woes, mainly compaction Hugh Dickins
2016-04-12 7:18 ` Hugh Dickins
2016-04-12 8:03 ` Vlastimil Babka
2016-04-12 8:03 ` Vlastimil Babka
2016-04-12 9:03 ` Vlastimil Babka
2016-04-12 9:03 ` Vlastimil Babka
2016-04-12 9:14 ` Vlastimil Babka
2016-04-12 9:14 ` Vlastimil Babka
2016-04-12 9:31 ` Vlastimil Babka
2016-04-12 9:31 ` Vlastimil Babka
2016-04-12 9:38 ` Vlastimil Babka
2016-04-12 9:38 ` Vlastimil Babka
2016-04-12 12:10 ` Michal Hocko
2016-04-12 12:10 ` Michal Hocko
2016-04-12 14:51 ` Michal Hocko [this message]
2016-04-12 14:51 ` Michal Hocko
2016-04-14 20:15 ` Hugh Dickins
2016-04-14 20:15 ` Hugh Dickins
2016-04-14 23:24 ` Vlastimil Babka
2016-04-14 23:24 ` Vlastimil Babka
2016-04-15 1:00 ` Hugh Dickins
2016-04-15 1:00 ` Hugh Dickins
2016-04-18 19:14 ` Vlastimil Babka
2016-04-18 19:14 ` Vlastimil Babka
2016-04-15 8:42 ` Michal Hocko
2016-04-15 8:42 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412145136.GA4387@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.