From: Matthew Wilcox <willy@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings
Date: Tue, 12 Apr 2016 23:01:56 -0400 [thread overview]
Message-ID: <20160413030156.GN2781@linux.intel.com> (raw)
In-Reply-To: <1460493572-31667-1-git-send-email-toshi.kani@hpe.com>
On Tue, Apr 12, 2016 at 02:39:29PM -0600, Toshi Kani wrote:
> To support DAX pmd mappings with unmodified applications,
> filesystems need to align an mmap address by the pmd size.
> @@ -708,6 +708,9 @@ const struct file_operations ext4_file_operations = {
> .open = ext4_file_open,
> .release = ext4_release_file,
> .fsync = ext4_sync_file,
> +#ifdef CONFIG_FS_DAX
> + .get_unmapped_area = dax_get_unmapped_area,
> +#endif
> .splice_read = generic_file_splice_read,
> .splice_write = iter_file_splice_write,
> .fallocate = ext4_fallocate,
Could you do something like:
#ifdef CONFIG_FS_DAX
struct page *read_dax_sector(struct block_device *bdev, sector_t n);
+unsigned long dax_get_unmapped_area(struct file *filp, unsigned long addr,
+ unsigned long len, unsigned long pgoff, unsigned long flags);
#else
static inline struct page *read_dax_sector(struct block_device *bdev,
sector_t n)
{
return ERR_PTR(-ENXIO);
}
+#define dax_get_unmapped_area NULL
#endif
in patch 1/5. Then there's no need for the ifdefs in each filesystem.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings
Date: Tue, 12 Apr 2016 23:01:56 -0400 [thread overview]
Message-ID: <20160413030156.GN2781@linux.intel.com> (raw)
In-Reply-To: <1460493572-31667-1-git-send-email-toshi.kani@hpe.com>
On Tue, Apr 12, 2016 at 02:39:29PM -0600, Toshi Kani wrote:
> To support DAX pmd mappings with unmodified applications,
> filesystems need to align an mmap address by the pmd size.
> @@ -708,6 +708,9 @@ const struct file_operations ext4_file_operations = {
> .open = ext4_file_open,
> .release = ext4_release_file,
> .fsync = ext4_sync_file,
> +#ifdef CONFIG_FS_DAX
> + .get_unmapped_area = dax_get_unmapped_area,
> +#endif
> .splice_read = generic_file_splice_read,
> .splice_write = iter_file_splice_write,
> .fallocate = ext4_fallocate,
Could you do something like:
#ifdef CONFIG_FS_DAX
struct page *read_dax_sector(struct block_device *bdev, sector_t n);
+unsigned long dax_get_unmapped_area(struct file *filp, unsigned long addr,
+ unsigned long len, unsigned long pgoff, unsigned long flags);
#else
static inline struct page *read_dax_sector(struct block_device *bdev,
sector_t n)
{
return ERR_PTR(-ENXIO);
}
+#define dax_get_unmapped_area NULL
#endif
in patch 1/5. Then there's no need for the ifdefs in each filesystem.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings
Date: Tue, 12 Apr 2016 23:01:56 -0400 [thread overview]
Message-ID: <20160413030156.GN2781@linux.intel.com> (raw)
In-Reply-To: <1460493572-31667-1-git-send-email-toshi.kani@hpe.com>
On Tue, Apr 12, 2016 at 02:39:29PM -0600, Toshi Kani wrote:
> To support DAX pmd mappings with unmodified applications,
> filesystems need to align an mmap address by the pmd size.
> @@ -708,6 +708,9 @@ const struct file_operations ext4_file_operations = {
> .open = ext4_file_open,
> .release = ext4_release_file,
> .fsync = ext4_sync_file,
> +#ifdef CONFIG_FS_DAX
> + .get_unmapped_area = dax_get_unmapped_area,
> +#endif
> .splice_read = generic_file_splice_read,
> .splice_write = iter_file_splice_write,
> .fallocate = ext4_fallocate,
Could you do something like:
#ifdef CONFIG_FS_DAX
struct page *read_dax_sector(struct block_device *bdev, sector_t n);
+unsigned long dax_get_unmapped_area(struct file *filp, unsigned long addr,
+ unsigned long len, unsigned long pgoff, unsigned long flags);
#else
static inline struct page *read_dax_sector(struct block_device *bdev,
sector_t n)
{
return ERR_PTR(-ENXIO);
}
+#define dax_get_unmapped_area NULL
#endif
in patch 1/5. Then there's no need for the ifdefs in each filesystem.
next prev parent reply other threads:[~2016-04-13 3:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 20:39 [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` [PATCH v2 3/5] xfs: " Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` [PATCH v2 4/5] ext2: " Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` [PATCH v2 5/5] block: " Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-12 20:39 ` Toshi Kani
2016-04-13 3:01 ` Matthew Wilcox [this message]
2016-04-13 3:01 ` [PATCH v2 2/5] ext4: " Matthew Wilcox
2016-04-13 3:01 ` Matthew Wilcox
2016-04-13 15:08 ` Toshi Kani
2016-04-13 15:08 ` Toshi Kani
2016-04-13 15:08 ` Toshi Kani
2016-04-13 18:22 ` Matthew Wilcox
2016-04-13 18:22 ` Matthew Wilcox
2016-04-13 18:22 ` Matthew Wilcox
2016-04-13 18:22 ` Matthew Wilcox
2016-04-13 18:52 ` Toshi Kani
2016-04-13 18:52 ` Toshi Kani
2016-04-13 18:52 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413030156.GN2781@linux.intel.com \
--to=willy@linux.intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=toshi.kani@hpe.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.