From: Cyrill Gorcunov <gorcunov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Florian Weimer <fw-d32yF4oPJVt0XxTmqZlbVQ@public.gmane.org>,
"Richard W.M. Jones"
<rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org,
zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
emunson-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org,
paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org,
xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org,
sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org,
milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org,
rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
iulia.manda21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
mguzik-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] vfs: Define new syscall getumask.
Date: Wed, 13 Apr 2016 15:40:34 +0300 [thread overview]
Message-ID: <20160413124034.GI2000@uranus.lan> (raw)
In-Reply-To: <87inzlg0mo.fsf-ZqZwdwZz9NfTBotR3TxKnbNAH6kLmebB@public.gmane.org>
On Wed, Apr 13, 2016 at 02:21:35PM +0200, Florian Weimer wrote:
> * Richard W. M. Jones:
>
> > +SYSCALL_DEFINE0(getumask)
> > +{
> > + return current->fs->umask;
> > +}
>
> The convention seems to be to call current_umask(), instead of
> inlining its contents.
Yes, please use existing.
WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Florian Weimer <fw@deneb.enyo.de>,
"Richard W.M. Jones" <rjones@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org,
luto@kernel.org, viro@zeniv.linux.org.uk,
mathieu.desnoyers@efficios.com, zab@redhat.com,
emunson@akamai.com, paulmck@linux.vnet.ibm.com,
aarcange@redhat.com, josh@joshtriplett.org, xemul@parallels.com,
sfr@canb.auug.org.au, milosz@adfin.com, rostedt@goodmis.org,
arnd@arndb.de, ebiederm@xmission.com, iulia.manda21@gmail.com,
dave.hansen@linux.intel.com, mguzik@redhat.com,
adobriyan@gmail.com, dave@stgolabs.net,
linux-api@vger.kernel.org
Subject: Re: [PATCH 1/2] vfs: Define new syscall getumask.
Date: Wed, 13 Apr 2016 15:40:34 +0300 [thread overview]
Message-ID: <20160413124034.GI2000@uranus.lan> (raw)
In-Reply-To: <87inzlg0mo.fsf@mid.deneb.enyo.de>
On Wed, Apr 13, 2016 at 02:21:35PM +0200, Florian Weimer wrote:
> * Richard W. M. Jones:
>
> > +SYSCALL_DEFINE0(getumask)
> > +{
> > + return current->fs->umask;
> > +}
>
> The convention seems to be to call current_umask(), instead of
> inlining its contents.
Yes, please use existing.
next prev parent reply other threads:[~2016-04-13 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:43 [PATCH 0/2] vfs: Define new syscall getumask Richard W.M. Jones
2016-04-13 11:43 ` Richard W.M. Jones
2016-04-13 11:43 ` [PATCH 1/2] " Richard W.M. Jones
[not found] ` <1460547786-16766-2-git-send-email-rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-04-13 12:21 ` Florian Weimer
2016-04-13 12:21 ` Florian Weimer
[not found] ` <87inzlg0mo.fsf-ZqZwdwZz9NfTBotR3TxKnbNAH6kLmebB@public.gmane.org>
2016-04-13 12:40 ` Cyrill Gorcunov [this message]
2016-04-13 12:40 ` Cyrill Gorcunov
2016-04-13 11:43 ` [PATCH 2/2] x86: Wire up new getumask system call on x86 Richard W.M. Jones
[not found] ` <1460547786-16766-3-git-send-email-rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-04-13 12:36 ` kbuild test robot
2016-04-13 12:36 ` kbuild test robot
2016-04-13 12:05 ` [PATCH 0/2] vfs: Define new syscall getumask Pavel Emelyanov
2016-04-13 12:05 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413124034.GI2000@uranus.lan \
--to=gorcunov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org \
--cc=dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=emunson-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org \
--cc=fw-d32yF4oPJVt0XxTmqZlbVQ@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=iulia.manda21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org \
--cc=mguzik-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
--cc=xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.