From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: axboe@kernel.dk, hch@infradead.org, tytso@mit.edu,
martin.petersen@oracle.com, snitzer@redhat.com,
linux-api@vger.kernel.org, bfoster@redhat.com, xfs@oss.sgi.com,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size
Date: Wed, 13 Apr 2016 07:23:08 -0700 [thread overview]
Message-ID: <20160413142308.GA8429@infradead.org> (raw)
In-Reply-To: <20160413040135.10562.74550.stgit@birch.djwong.org>
On Tue, Apr 12, 2016 at 09:01:35PM -0700, Darrick J. Wong wrote:
> Make sure that the offset and length arguments that we're using to
> construct WRITE SAME and DISCARD requests are actually aligned to the
> logical block size. Failure to do this causes other errors in other
> parts of the block layer or the SCSI layer because disks don't support
> partial logical block writes.
FYI, Bart has just been posting a patchset in that includes this, but
goes further. Can you take a look at it?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, tytso@mit.edu,
martin.petersen@oracle.com, snitzer@redhat.com,
linux-api@vger.kernel.org, bfoster@redhat.com, xfs@oss.sgi.com,
hch@infradead.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size
Date: Wed, 13 Apr 2016 07:23:08 -0700 [thread overview]
Message-ID: <20160413142308.GA8429@infradead.org> (raw)
In-Reply-To: <20160413040135.10562.74550.stgit@birch.djwong.org>
On Tue, Apr 12, 2016 at 09:01:35PM -0700, Darrick J. Wong wrote:
> Make sure that the offset and length arguments that we're using to
> construct WRITE SAME and DISCARD requests are actually aligned to the
> logical block size. Failure to do this causes other errors in other
> parts of the block layer or the SCSI layer because disks don't support
> partial logical block writes.
FYI, Bart has just been posting a patchset in that includes this, but
goes further. Can you take a look at it?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-13 14:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 4:01 [RFC DONOTMERGE v8 0/3] fallocate for block devices Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 4:01 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 14:23 ` Christoph Hellwig [this message]
2016-04-13 14:23 ` Christoph Hellwig
[not found] ` <20160413040121.10562.98998.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-04-13 4:01 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 4:01 ` [PATCH 3/3] block: implement (some of) fallocate for block devices Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 4:04 ` [PATCH 4/3] block: test " Darrick J. Wong
2016-04-13 4:04 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2016-09-29 21:16 [PATCH v11 0/3] " Darrick J. Wong
2016-09-29 21:16 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-09-29 21:16 ` Darrick J. Wong
2016-09-29 0:39 [PATCH v10 0/3] fallocate for block devices Darrick J. Wong
2016-09-29 0:39 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-09-29 0:39 ` Darrick J. Wong
[not found] ` <147510958448.8940.14280630935441533825.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-09-29 5:56 ` Hannes Reinecke
2016-09-29 5:56 ` Hannes Reinecke
2016-09-29 5:56 ` Hannes Reinecke
2016-08-26 0:02 [PATCH v10 0/3] fallocate for block devices Darrick J. Wong
2016-08-26 0:02 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-08-26 0:02 ` Darrick J. Wong
2016-06-17 1:17 [PATCH v9 0/3] fallocate for block devices Darrick J. Wong
[not found] ` <146612624734.12764.4316680863289411106.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-06-17 1:17 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-06-17 1:17 ` Darrick J. Wong
2016-06-17 1:17 ` Darrick J. Wong
2016-06-20 12:37 ` Bart Van Assche
2016-06-20 12:37 ` Bart Van Assche
2016-06-29 4:58 ` Martin K. Petersen
2016-06-29 4:58 ` Martin K. Petersen
2016-03-15 19:42 [PATCH v7 0/3] fallocate for block devices to provide zero-out Darrick J. Wong
2016-03-15 19:42 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-03-05 0:55 [PATCH v6 0/3] fallocate for block devices to provide zero-out Darrick J. Wong
2016-03-05 0:56 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-03-05 3:02 ` Linus Torvalds
2016-03-15 7:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413142308.GA8429@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.