All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32
Date: Wed, 13 Apr 2016 11:19:33 -0600	[thread overview]
Message-ID: <20160413171933.GA24879@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4hDLN1F-A3bsQdBdksFP6hWnpw_KkgWwLC5UcfcmcSr-Q@mail.gmail.com>

On Tue, Apr 12, 2016 at 10:24:25PM -0700, Dan Williams wrote:
> On Tue, Apr 12, 2016 at 5:10 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> > After 'commit fc0c2028135c ("x86, pmem: use memcpy_mcsafe()
> > for memcpy_from_pmem()")', probing a PMEM device hits the BUG()
> > error below on X86_32 kernel.
> >
> >  kernel BUG at include/linux/pmem.h:48!
> >
> > memcpy_from_pmem() calls arch_memcpy_from_pmem(), which is
> > unimplemented since CONFIG_ARCH_HAS_PMEM_API is undefined on
> > X86_32.
> >
> > Fix the BUG() error by adding default_memcpy_from_pmem().
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> 
> Whoops, I'll add a 32-bit boot test to my release criteria.  Thanks Toshi!

Yep, this patch looks correct to me.

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Toshi Kani <toshi.kani@hpe.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32
Date: Wed, 13 Apr 2016 11:19:33 -0600	[thread overview]
Message-ID: <20160413171933.GA24879@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4hDLN1F-A3bsQdBdksFP6hWnpw_KkgWwLC5UcfcmcSr-Q@mail.gmail.com>

On Tue, Apr 12, 2016 at 10:24:25PM -0700, Dan Williams wrote:
> On Tue, Apr 12, 2016 at 5:10 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> > After 'commit fc0c2028135c ("x86, pmem: use memcpy_mcsafe()
> > for memcpy_from_pmem()")', probing a PMEM device hits the BUG()
> > error below on X86_32 kernel.
> >
> >  kernel BUG at include/linux/pmem.h:48!
> >
> > memcpy_from_pmem() calls arch_memcpy_from_pmem(), which is
> > unimplemented since CONFIG_ARCH_HAS_PMEM_API is undefined on
> > X86_32.
> >
> > Fix the BUG() error by adding default_memcpy_from_pmem().
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> 
> Whoops, I'll add a 32-bit boot test to my release criteria.  Thanks Toshi!

Yep, this patch looks correct to me.

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

  reply	other threads:[~2016-04-13 17:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  0:10 [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32 Toshi Kani
2016-04-13  0:10 ` Toshi Kani
2016-04-13  5:24 ` Dan Williams
2016-04-13  5:24   ` Dan Williams
2016-04-13 17:19   ` Ross Zwisler [this message]
2016-04-13 17:19     ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413171933.GA24879@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.