From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shaohua Li <shli@kernel.org>
Cc: Krzysztof Wojcik <krzysztof.wojcik@intel.com>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] md/raid0: check for create_strip_zones() errors
Date: Wed, 13 Apr 2016 17:53:57 +0000 [thread overview]
Message-ID: <20160413175356.GE4247@mwanda> (raw)
In-Reply-To: <20160413170240.GB6186@kernel.org>
On Wed, Apr 13, 2016 at 10:02:40AM -0700, Shaohua Li wrote:
> On Wed, Apr 13, 2016 at 09:46:45AM +0300, Dan Carpenter wrote:
> > My static checker complains that if create_strip_zones() fails then we
> > use "priv_conf" without initializing it. Fix this by checking for
> > failure.
>
> It's more convenient setting '*private_conf = ERR_PTR(-ENOMEM);' at the
> begining of create_strip_zones() when it returns -ENOMEM. create_strip_zones
> already sets private_conf correctly in other cases.
>
Yeah. I'll send v2.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shaohua Li <shli@kernel.org>
Cc: Krzysztof Wojcik <krzysztof.wojcik@intel.com>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] md/raid0: check for create_strip_zones() errors
Date: Wed, 13 Apr 2016 20:53:57 +0300 [thread overview]
Message-ID: <20160413175356.GE4247@mwanda> (raw)
In-Reply-To: <20160413170240.GB6186@kernel.org>
On Wed, Apr 13, 2016 at 10:02:40AM -0700, Shaohua Li wrote:
> On Wed, Apr 13, 2016 at 09:46:45AM +0300, Dan Carpenter wrote:
> > My static checker complains that if create_strip_zones() fails then we
> > use "priv_conf" without initializing it. Fix this by checking for
> > failure.
>
> It's more convenient setting '*private_conf = ERR_PTR(-ENOMEM);' at the
> begining of create_strip_zones() when it returns -ENOMEM. create_strip_zones
> already sets private_conf correctly in other cases.
>
Yeah. I'll send v2.
regards,
dan carpenter
next prev parent reply other threads:[~2016-04-13 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 6:46 [patch] md/raid0: check for create_strip_zones() errors Dan Carpenter
2016-04-13 6:46 ` Dan Carpenter
2016-04-13 17:02 ` Shaohua Li
2016-04-13 17:02 ` Shaohua Li
2016-04-13 17:53 ` Dan Carpenter [this message]
2016-04-13 17:53 ` Dan Carpenter
2016-04-14 9:31 ` [patch v2] md/raid0: fix uninitialized variable bug Dan Carpenter
2016-04-14 9:31 ` Dan Carpenter
2016-04-14 16:57 ` Shaohua Li
2016-04-14 16:57 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413175356.GE4247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.wojcik@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.