From: Stephen Boyd <sboyd@codeaurora.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-mips@linux-mips.org, linux-sh@vger.kernel.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Ungerer <gerg@uclinux.org>, Ryan Mallon <rmallon@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Steven Miao <realmz6@gmail.com>,
Simon Horman <horms@verge.net.au>,
Wan ZongShun <mcuos.com@gmail.com>, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
adi-buildroot-devel@lists.sourceforge.net,
Russell King <linux@arm.linux.org.uk>,
linux-m68k@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
John Crispin <blogic@openwrt.org>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>
Subject: Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error
Date: Wed, 13 Apr 2016 17:40:50 -0700 [thread overview]
Message-ID: <20160414004050.GJ14441@codeaurora.org> (raw)
In-Reply-To: <20160408100600.GI1668@linux-mips.org>
On 04/08, Ralf Baechle wrote:
>
> While your argument makes perfect sense, Many clk_disable implementations
> are already doing similar checks, for example:
>
> arch/arm/mach-davinci/clock.c:
>
[...]
>
> So should we go and weed out these checks?
Yes, it would be nice to at least make the differing
implementations of the clk API consistent. Of course, we should
really put our efforts towards getting rid of the non-CCF
implementations instead so that there's less confusion overall.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-mips@linux-mips.org, linux-sh@vger.kernel.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Ungerer <gerg@uclinux.org>, Ryan Mallon <rmallon@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Steven Miao <realmz6@gmail.com>,
Simon Horman <horms@verge.net.au>,
Wan ZongShun <mcuos.com@gmail.com>, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
adi-buildroot-devel@lists.sourceforge.net,
Russell King <linux@arm.linux.org.uk>,
linux-m68k@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
John Crispin <blogic@openwrt.org>H
Subject: Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error
Date: Wed, 13 Apr 2016 17:40:50 -0700 [thread overview]
Message-ID: <20160414004050.GJ14441@codeaurora.org> (raw)
In-Reply-To: <20160408100600.GI1668@linux-mips.org>
On 04/08, Ralf Baechle wrote:
>
> While your argument makes perfect sense, Many clk_disable implementations
> are already doing similar checks, for example:
>
> arch/arm/mach-davinci/clock.c:
>
[...]
>
> So should we go and weed out these checks?
Yes, it would be nice to at least make the differing
implementations of the clk API consistent. Of course, we should
really put our efforts towards getting rid of the non-CCF
implementations instead so that there's less confusion overall.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error
Date: Thu, 14 Apr 2016 00:40:50 +0000 [thread overview]
Message-ID: <20160414004050.GJ14441@codeaurora.org> (raw)
In-Reply-To: <20160408100600.GI1668@linux-mips.org>
On 04/08, Ralf Baechle wrote:
>
> While your argument makes perfect sense, Many clk_disable implementations
> are already doing similar checks, for example:
>
> arch/arm/mach-davinci/clock.c:
>
[...]
>
> So should we go and weed out these checks?
Yes, it would be nice to at least make the differing
implementations of the clk API consistent. Of course, we should
really put our efforts towards getting rid of the non-CCF
implementations instead so that there's less confusion overall.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error
Date: Wed, 13 Apr 2016 17:40:50 -0700 [thread overview]
Message-ID: <20160414004050.GJ14441@codeaurora.org> (raw)
In-Reply-To: <20160408100600.GI1668@linux-mips.org>
On 04/08, Ralf Baechle wrote:
>
> While your argument makes perfect sense, Many clk_disable implementations
> are already doing similar checks, for example:
>
> arch/arm/mach-davinci/clock.c:
>
[...]
>
> So should we go and weed out these checks?
Yes, it would be nice to at least make the differing
implementations of the clk API consistent. Of course, we should
really put our efforts towards getting rid of the non-CCF
implementations instead so that there's less confusion overall.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-14 0:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 1:51 [PATCH v2] clk: let clk_disable() return immediately if clk is NULL or error Masahiro Yamada
2016-04-05 1:51 ` Masahiro Yamada
2016-04-05 1:51 ` Masahiro Yamada
2016-04-05 1:51 ` Masahiro Yamada
2016-04-08 0:33 ` Stephen Boyd
2016-04-08 0:33 ` Stephen Boyd
2016-04-08 0:33 ` Stephen Boyd
2016-04-08 0:33 ` Stephen Boyd
2016-04-08 0:33 ` Stephen Boyd
2016-04-08 1:52 ` Masahiro Yamada
2016-04-08 1:52 ` Masahiro Yamada
2016-04-08 1:52 ` Masahiro Yamada
2016-04-08 1:52 ` Masahiro Yamada
2016-04-08 1:52 ` Masahiro Yamada
2016-04-14 0:33 ` Stephen Boyd
2016-04-14 0:33 ` Stephen Boyd
2016-04-14 0:33 ` Stephen Boyd
2016-04-14 0:33 ` Stephen Boyd
2016-04-14 0:33 ` Stephen Boyd
2016-04-14 1:49 ` Masahiro Yamada
2016-04-14 1:49 ` Masahiro Yamada
2016-04-14 1:49 ` Masahiro Yamada
2016-04-14 1:49 ` Masahiro Yamada
2016-04-16 0:04 ` Stephen Boyd
2016-04-16 0:04 ` Stephen Boyd
2016-04-16 0:04 ` Stephen Boyd
2016-04-16 0:04 ` Stephen Boyd
2016-04-16 0:04 ` Stephen Boyd
2016-04-14 1:49 ` Masahiro Yamada
2016-04-08 10:06 ` Ralf Baechle
2016-04-08 10:06 ` Ralf Baechle
2016-04-08 10:06 ` Ralf Baechle
2016-04-08 10:06 ` Ralf Baechle
2016-04-08 11:15 ` Masahiro Yamada
2016-04-08 11:15 ` Masahiro Yamada
2016-04-08 11:15 ` Masahiro Yamada
2016-04-08 11:15 ` Masahiro Yamada
2016-04-14 0:40 ` Stephen Boyd [this message]
2016-04-14 0:40 ` Stephen Boyd
2016-04-14 0:40 ` Stephen Boyd
2016-04-14 0:40 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2016-04-05 1:51 Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414004050.GJ14441@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=blogic@openwrt.org \
--cc=dalias@libc.org \
--cc=egtvedt@samfundet.no \
--cc=eric.y.miao@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=haojian.zhuang@gmail.com \
--cc=horms@verge.net.au \
--cc=hskinnemoen@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mcuos.com@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=ralf@linux-mips.org \
--cc=realmz6@gmail.com \
--cc=rmallon@gmail.com \
--cc=tony@atomide.com \
--cc=yamada.masahiro@socionext.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.