All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Petr Mladek <pmladek-IBi9RG/b67k@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Cyril Hrubis <chrubis-AlSwsSmVLrQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Subject: Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups
Date: Thu, 14 Apr 2016 09:06:23 +0200	[thread overview]
Message-ID: <20160414070623.GC2850@dhcp22.suse.cz> (raw)
In-Reply-To: <20160413194820.GC30260-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

On Wed 13-04-16 21:48:20, Michal Hocko wrote:
[...]
> I was thinking about something like flush_per_cpu_work() which would
> assert on group_threadgroup_rwsem held for write.

I have thought about this some more and I guess this is not limitted to
per cpu workers. Basically any flush_work with group_threadgroup_rwsem
held for write is dangerous, right?
-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
	cgroups@vger.kernel.org, Cyril Hrubis <chrubis@suse.cz>,
	linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [BUG] cgroup/workques/fork: deadlock when moving cgroups
Date: Thu, 14 Apr 2016 09:06:23 +0200	[thread overview]
Message-ID: <20160414070623.GC2850@dhcp22.suse.cz> (raw)
In-Reply-To: <20160413194820.GC30260@dhcp22.suse.cz>

On Wed 13-04-16 21:48:20, Michal Hocko wrote:
[...]
> I was thinking about something like flush_per_cpu_work() which would
> assert on group_threadgroup_rwsem held for write.

I have thought about this some more and I guess this is not limitted to
per cpu workers. Basically any flush_work with group_threadgroup_rwsem
held for write is dangerous, right?
-- 
Michal Hocko
SUSE Labs

  parent reply	other threads:[~2016-04-14  7:06 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  9:42 [BUG] cgroup/workques/fork: deadlock when moving cgroups Petr Mladek
     [not found] ` <20160413094216.GC5774-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2016-04-13 18:33   ` Tejun Heo
2016-04-13 18:33     ` Tejun Heo
     [not found]     ` <20160413183309.GG3676-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-04-13 18:57       ` Tejun Heo
2016-04-13 18:57         ` Tejun Heo
2016-04-13 19:23       ` Michal Hocko
2016-04-13 19:23         ` Michal Hocko
     [not found]         ` <20160413192313.GA30260-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-13 19:28           ` Michal Hocko
2016-04-13 19:28             ` Michal Hocko
2016-04-13 19:37         ` Tejun Heo
2016-04-13 19:48           ` Michal Hocko
     [not found]             ` <20160413194820.GC30260-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-14  7:06               ` Michal Hocko [this message]
2016-04-14  7:06                 ` Michal Hocko
     [not found]                 ` <20160414070623.GC2850-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-14 15:32                   ` Tejun Heo
2016-04-14 15:32                     ` Tejun Heo
2016-04-14 17:50         ` Johannes Weiner
2016-04-15  7:06           ` Michal Hocko
     [not found]             ` <20160415070601.GA32377-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-15 14:38               ` Tejun Heo
2016-04-15 14:38                 ` Tejun Heo
     [not found]                 ` <20160415143815.GH12583-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-04-15 15:08                   ` Michal Hocko
2016-04-15 15:08                     ` Michal Hocko
     [not found]                     ` <20160415150815.GM32377-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-15 15:25                       ` Tejun Heo
2016-04-15 15:25                         ` Tejun Heo
     [not found]                         ` <20160415152526.GJ12583-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-04-17 12:00                           ` Michal Hocko
2016-04-17 12:00                             ` Michal Hocko
2016-04-18 14:40                   ` Petr Mladek
2016-04-18 14:40                     ` Petr Mladek
     [not found]                     ` <20160418144023.GG6862-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2016-04-19 14:01                       ` Michal Hocko
2016-04-19 14:01                         ` Michal Hocko
2016-04-19 15:39                         ` Petr Mladek
2016-04-15 19:17           ` [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge() Tejun Heo
     [not found]             ` <20160415191719.GK12583-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-04-17 12:07               ` Michal Hocko
2016-04-17 12:07                 ` Michal Hocko
     [not found]                 ` <20160417120747.GC21757-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-20 21:29                   ` Tejun Heo
2016-04-20 21:29                     ` Tejun Heo
     [not found]                     ` <20160420212922.GH4775-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-04-21  3:27                       ` Michal Hocko
2016-04-21  3:27                         ` Michal Hocko
     [not found]                         ` <20160421032704.GA15585-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-21 15:00                           ` Petr Mladek
2016-04-21 15:00                             ` Petr Mladek
2016-04-21 15:51                             ` Tejun Heo
2016-04-21 23:06                   ` [PATCH 1/2] cgroup, cpuset: replace cpuset_post_attach_flush() with cgroup_subsys->post_attach callback Tejun Heo
2016-04-21 23:06                     ` Tejun Heo
     [not found]                     ` <20160421230648.GI4775-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-04-21 23:09                       ` [PATCH 2/2] memcg: relocate charge moving from ->attach to ->post_attach Tejun Heo
2016-04-21 23:09                         ` Tejun Heo
     [not found]                         ` <20160421230902.GJ4775-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-04-22 13:57                           ` Petr Mladek
2016-04-22 13:57                             ` Petr Mladek
2016-04-25  8:25                           ` Michal Hocko
2016-04-25  8:25                             ` Michal Hocko
     [not found]                             ` <20160425082542.GB23933-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2016-04-25 19:42                               ` Tejun Heo
2016-04-25 19:42                                 ` Tejun Heo
2016-04-25 19:44                           ` Tejun Heo
2016-04-25 19:44                             ` Tejun Heo
2016-04-21 23:11                       ` [PATCH 1/2] cgroup, cpuset: replace cpuset_post_attach_flush() with cgroup_subsys->post_attach callback Tejun Heo
2016-04-21 23:11                         ` Tejun Heo
2016-04-21 15:56               ` [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge() Tejun Heo
2016-04-21 15:56                 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160414070623.GC2850@dhcp22.suse.cz \
    --to=mhocko-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=chrubis-AlSwsSmVLrQ@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pmladek-IBi9RG/b67k@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.