* [patch] target: Silence an uninitialized variable warning
@ 2016-04-14 9:33 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-04-14 9:33 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: linux-scsi, target-devel, linux-kernel, kernel-janitors
I'm getting a static checker warning:
drivers/target/target_core_sbc.c:1150 sbc_parse_cdb()
error: uninitialized variable 'size'.
It looks like a possible bug but wouldn't it have shown up in testing?
Anyway let's just silence it by setting size to zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index a9057aa..0c6e55f 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -828,7 +828,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
{
struct se_device *dev = cmd->se_dev;
unsigned char *cdb = cmd->t_task_cdb;
- unsigned int size;
+ unsigned int size = 0;
u32 sectors = 0;
sense_reason_t ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] target: Silence an uninitialized variable warning
@ 2016-04-14 9:33 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-04-14 9:33 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: linux-scsi, target-devel, linux-kernel, kernel-janitors
I'm getting a static checker warning:
drivers/target/target_core_sbc.c:1150 sbc_parse_cdb()
error: uninitialized variable 'size'.
It looks like a possible bug but wouldn't it have shown up in testing?
Anyway let's just silence it by setting size to zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index a9057aa..0c6e55f 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -828,7 +828,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
{
struct se_device *dev = cmd->se_dev;
unsigned char *cdb = cmd->t_task_cdb;
- unsigned int size;
+ unsigned int size = 0;
u32 sectors = 0;
sense_reason_t ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-14 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-14 9:33 [patch] target: Silence an uninitialized variable warning Dan Carpenter
2016-04-14 9:33 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.