From: Dan Carpenter <dan.carpenter@oracle.com>
To: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Ewan Milne <emilne@redhat.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] scsi_dh_alua: uninitialized variable in alua_rtpg()
Date: Thu, 14 Apr 2016 09:39:17 +0000 [thread overview]
Message-ID: <20160414093917.GA16891@mwanda> (raw)
In-Reply-To: <20160311101756.GA9384@mwanda>
It's possible to use "err" without initializing it. If it happens to be
a 2 which is SCSI_DH_RETRY then that could cause a bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 8eaed05..f3c994f 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -513,7 +513,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
struct alua_port_group *tmp_pg;
int len, k, off, valid_states = 0, bufflen = ALUA_RTPG_SIZE;
unsigned char *desc, *buff;
- unsigned err, retval;
+ unsigned int err = 0;
+ unsigned int retval;
unsigned int tpg_desc_tbl_off;
unsigned char orig_transition_tmo;
unsigned long flags;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Ewan Milne <emilne@redhat.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] scsi_dh_alua: uninitialized variable in alua_rtpg()
Date: Thu, 14 Apr 2016 12:39:17 +0300 [thread overview]
Message-ID: <20160414093917.GA16891@mwanda> (raw)
It's possible to use "err" without initializing it. If it happens to be
a 2 which is SCSI_DH_RETRY then that could cause a bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 8eaed05..f3c994f 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -513,7 +513,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
struct alua_port_group *tmp_pg;
int len, k, off, valid_states = 0, bufflen = ALUA_RTPG_SIZE;
unsigned char *desc, *buff;
- unsigned err, retval;
+ unsigned int err = 0;
+ unsigned int retval;
unsigned int tpg_desc_tbl_off;
unsigned char orig_transition_tmo;
unsigned long flags;
next prev parent reply other threads:[~2016-04-14 9:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 10:17 [patch] scsi_dh_alua: uninitialized variable in alua_check_vpd() Dan Carpenter
2016-03-11 10:17 ` Dan Carpenter
2016-03-11 10:50 ` Hannes Reinecke
2016-03-11 10:50 ` Hannes Reinecke
2016-03-11 10:50 ` Hannes Reinecke
2016-03-11 11:19 ` [patch v2] " Dan Carpenter
2016-03-11 11:19 ` Dan Carpenter
2016-03-11 11:48 ` Hannes Reinecke
2016-03-11 11:48 ` Hannes Reinecke
2016-03-11 11:48 ` Hannes Reinecke
2016-03-11 14:40 ` Manoj Kumar
2016-03-11 14:40 ` Manoj Kumar
2016-03-14 20:02 ` Martin K. Petersen
2016-03-14 20:02 ` Martin K. Petersen
2016-03-11 11:19 ` [patch] " Dan Carpenter
2016-03-11 11:19 ` Dan Carpenter
2016-04-14 9:39 ` Dan Carpenter [this message]
2016-04-14 9:39 ` [patch] scsi_dh_alua: uninitialized variable in alua_rtpg() Dan Carpenter
2016-04-14 15:45 ` Bart Van Assche
2016-04-14 15:45 ` Bart Van Assche
2016-04-14 15:45 ` Bart Van Assche
2016-04-14 18:20 ` [patch v2] " Dan Carpenter
2016-04-14 18:20 ` Dan Carpenter
2016-04-14 18:55 ` Bart Van Assche
2016-04-14 18:55 ` Bart Van Assche
2016-04-14 18:55 ` Bart Van Assche
2016-04-15 5:59 ` Hannes Reinecke
2016-04-15 5:59 ` Hannes Reinecke
2016-04-15 5:59 ` Hannes Reinecke
2016-04-15 20:26 ` Martin K. Petersen
2016-04-15 20:26 ` Martin K. Petersen
2016-04-14 18:20 ` [patch] " Dan Carpenter
2016-04-14 18:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414093917.GA16891@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.