All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mfd: wm8400-core: signedness bug in wm8400_reg_read()
Date: Thu, 14 Apr 2016 10:01:35 +0000	[thread overview]
Message-ID: <20160414100135.GS31814@localhost.localdomain> (raw)
In-Reply-To: <20160414094055.GC16891@mwanda>

On Thu, Apr 14, 2016 at 12:40:55PM +0300, Dan Carpenter wrote:
> This is harmless because the function is not called, but we're trying to
> return negative error codes so the function needs to return an int
> instead of a u16.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

That patch looks fine, but the function appears to be completely
unused, perhaps just a patch to remove it would be better?

Thanks,
Charles

WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	<patches@opensource.wolfsonmicro.com>,
	<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [patch] mfd: wm8400-core: signedness bug in wm8400_reg_read()
Date: Thu, 14 Apr 2016 11:01:35 +0100	[thread overview]
Message-ID: <20160414100135.GS31814@localhost.localdomain> (raw)
In-Reply-To: <20160414094055.GC16891@mwanda>

On Thu, Apr 14, 2016 at 12:40:55PM +0300, Dan Carpenter wrote:
> This is harmless because the function is not called, but we're trying to
> return negative error codes so the function needs to return an int
> instead of a u16.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

That patch looks fine, but the function appears to be completely
unused, perhaps just a patch to remove it would be better?

Thanks,
Charles

  reply	other threads:[~2016-04-14 10:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14  9:40 [patch] mfd: wm8400-core: signedness bug in wm8400_reg_read() Dan Carpenter
2016-04-14  9:40 ` Dan Carpenter
2016-04-14 10:01 ` Charles Keepax [this message]
2016-04-14 10:01   ` Charles Keepax
2016-04-15 14:44   ` [patch v2] mfd: wm8400-core: delete wm8400_reg_read() Dan Carpenter
2016-04-15 14:44     ` Dan Carpenter
2016-04-15 15:15     ` Charles Keepax
2016-04-15 15:15       ` Charles Keepax
2016-04-25 11:00     ` Lee Jones
2016-04-25 11:00       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160414100135.GS31814@localhost.localdomain \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.