All of lore.kernel.org
 help / color / mirror / Atom feed
From: atomlin@redhat.com (Aaron Tomlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods
Date: Thu, 14 Apr 2016 16:17:05 +0100	[thread overview]
Message-ID: <20160414151705.GE20425@atomlin.usersys.redhat.com> (raw)
In-Reply-To: <1459877208-15119-2-git-send-email-cmetcalf@mellanox.com>

On Tue 2016-04-05 13:26 -0400, Chris Metcalf wrote:
> Currently you can only request a backtrace of either all cpus, or
> all cpus but yourself.  It can also be helpful to request a remote
> backtrace of a single cpu, and since we want that, the logical
> extension is to support a cpumask as the underlying primitive.
> 
> This change modifies the existing lib/nmi_backtrace.c code to take
> a cpumask as its basic primitive, and modifies the linux/nmi.h code
> to use either the old "all/all_but_self" arch methods, or the new
> "cpumask" method, depending on which is available.
> 
> The existing clients of nmi_backtrace (arm and x86) are converted
> to using the new cpumask approach in this change.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
> ---
>  arch/arm/include/asm/irq.h    |  4 +--
>  arch/arm/kernel/smp.c         |  4 +--
>  arch/x86/include/asm/irq.h    |  4 +--
>  arch/x86/kernel/apic/hw_nmi.c |  6 ++---
>  include/linux/nmi.h           | 63 ++++++++++++++++++++++++++++++++++---------
>  lib/nmi_backtrace.c           | 15 +++++------
>  6 files changed, 65 insertions(+), 31 deletions(-)

Looks good to me.

Reviewed-by: Aaron Tomlin <atomlin@redhat.com>

-- 
Aaron Tomlin

WARNING: multiple messages have this Message-ID (diff)
From: Aaron Tomlin <atomlin@redhat.com>
To: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Petr Mladek <pmladek@suse.com>,
	Russell King <linux@arm.linux.org.uk>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Andrew Morton <akpm@osdl.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	x86@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods
Date: Thu, 14 Apr 2016 16:17:05 +0100	[thread overview]
Message-ID: <20160414151705.GE20425@atomlin.usersys.redhat.com> (raw)
In-Reply-To: <1459877208-15119-2-git-send-email-cmetcalf@mellanox.com>

On Tue 2016-04-05 13:26 -0400, Chris Metcalf wrote:
> Currently you can only request a backtrace of either all cpus, or
> all cpus but yourself.  It can also be helpful to request a remote
> backtrace of a single cpu, and since we want that, the logical
> extension is to support a cpumask as the underlying primitive.
> 
> This change modifies the existing lib/nmi_backtrace.c code to take
> a cpumask as its basic primitive, and modifies the linux/nmi.h code
> to use either the old "all/all_but_self" arch methods, or the new
> "cpumask" method, depending on which is available.
> 
> The existing clients of nmi_backtrace (arm and x86) are converted
> to using the new cpumask approach in this change.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
> ---
>  arch/arm/include/asm/irq.h    |  4 +--
>  arch/arm/kernel/smp.c         |  4 +--
>  arch/x86/include/asm/irq.h    |  4 +--
>  arch/x86/kernel/apic/hw_nmi.c |  6 ++---
>  include/linux/nmi.h           | 63 ++++++++++++++++++++++++++++++++++---------
>  lib/nmi_backtrace.c           | 15 +++++------
>  6 files changed, 65 insertions(+), 31 deletions(-)

Looks good to me.

Reviewed-by: Aaron Tomlin <atomlin@redhat.com>

-- 
Aaron Tomlin

  reply	other threads:[~2016-04-14 15:17 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201604031905.WLWlnyKg%fengguang.wu@intel.com>
2016-04-05 17:26 ` [PATCH v5 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-04-05 17:26   ` Chris Metcalf
2016-04-05 17:26   ` Chris Metcalf
2016-04-05 17:26   ` Chris Metcalf
2016-04-05 17:26   ` [PATCH v5 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-04-05 17:26     ` Chris Metcalf
2016-04-14 15:17     ` Aaron Tomlin [this message]
2016-04-14 15:17       ` Aaron Tomlin
2016-04-05 17:26   ` [PATCH v5 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-04-05 17:26     ` Chris Metcalf
2016-04-14 15:19     ` Aaron Tomlin
2016-04-14 15:19       ` Aaron Tomlin
2016-04-05 17:26   ` [PATCH v5 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-04-05 17:26   ` [PATCH v5 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-04-05 17:26     ` Chris Metcalf
2016-04-05 17:26     ` Chris Metcalf
2016-07-13 18:44   ` [PATCH v5 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-07-13 18:44     ` Chris Metcalf
2016-07-13 18:44     ` Chris Metcalf
2016-07-14 20:50     ` [PATCH v6 " Chris Metcalf
2016-07-14 20:50       ` Chris Metcalf
2016-07-14 20:50       ` Chris Metcalf
2016-07-14 20:50       ` Chris Metcalf
2016-07-14 20:50       ` [PATCH v6 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-07-14 20:50         ` Chris Metcalf
2016-08-08 13:57         ` Petr Mladek
2016-08-08 13:57           ` Petr Mladek
2016-08-08 15:49           ` Chris Metcalf
2016-08-08 15:49             ` Chris Metcalf
2016-07-14 20:50       ` [PATCH v6 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-07-14 20:50         ` Chris Metcalf
2016-07-14 20:50       ` [PATCH v6 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-07-14 20:50       ` [PATCH v6 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-07-14 20:50         ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160414151705.GE20425@atomlin.usersys.redhat.com \
    --to=atomlin@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.