From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] ARM: xen: Register with kernel restart handler
Date: Fri, 15 Apr 2016 12:35:44 -0700 [thread overview]
Message-ID: <20160415193544.GA2005@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1604151122090.3433@sstabellini-ThinkPad-X260>
On Fri, Apr 15, 2016 at 11:22:36AM -0700, Stefano Stabellini wrote:
> On Thu, 14 Apr 2016, Guenter Roeck wrote:
> > Register with kernel restart handler instead of setting arm_pm_restart
> > directly.
> >
> > Select a high priority of 192 to ensure that default restart handlers
> > are replaced if Xen is running.
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks. I assume this is going to go in via Russell or Catalin's tree
> with the rest of your series?
>
I would suggest Russell, if he is willing to pick it up, since it mostly
affects arm.
Guenter
>
> > v2: Rebased to v4.6-rc3, added Reviewed/by/Acked-by tags
> >
> > arch/arm/xen/enlighten.c | 13 +++++++++++--
> > 1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> > index 75cd7345c654..76a1d12fd27e 100644
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -27,6 +27,7 @@
> > #include <linux/cpu.h>
> > #include <linux/console.h>
> > #include <linux/pvclock_gtod.h>
> > +#include <linux/reboot.h>
> > #include <linux/time64.h>
> > #include <linux/timekeeping.h>
> > #include <linux/timekeeper_internal.h>
> > @@ -193,14 +194,22 @@ after_register_vcpu_info:
> > put_cpu();
> > }
> >
> > -static void xen_restart(enum reboot_mode reboot_mode, const char *cmd)
> > +static int xen_restart(struct notifier_block *nb, unsigned long action,
> > + void *data)
> > {
> > struct sched_shutdown r = { .reason = SHUTDOWN_reboot };
> > int rc;
> > rc = HYPERVISOR_sched_op(SCHEDOP_shutdown, &r);
> > BUG_ON(rc);
> > +
> > + return NOTIFY_DONE;
> > }
> >
> > +static struct notifier_block xen_restart_nb = {
> > + .notifier_call = xen_restart,
> > + .priority = 192,
> > +};
> > +
> > static void xen_power_off(void)
> > {
> > struct sched_shutdown r = { .reason = SHUTDOWN_poweroff };
> > @@ -370,7 +379,7 @@ static int __init xen_pm_init(void)
> > return -ENODEV;
> >
> > pm_power_off = xen_power_off;
> > - arm_pm_restart = xen_restart;
> > + register_restart_handler(&xen_restart_nb);
> > if (!xen_initial_domain()) {
> > struct timespec64 ts;
> > xen_read_wallclock(&ts);
> > --
> > 2.5.0
> >
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 2/6] ARM: xen: Register with kernel restart handler
Date: Fri, 15 Apr 2016 12:35:44 -0700 [thread overview]
Message-ID: <20160415193544.GA2005@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1604151122090.3433@sstabellini-ThinkPad-X260>
On Fri, Apr 15, 2016 at 11:22:36AM -0700, Stefano Stabellini wrote:
> On Thu, 14 Apr 2016, Guenter Roeck wrote:
> > Register with kernel restart handler instead of setting arm_pm_restart
> > directly.
> >
> > Select a high priority of 192 to ensure that default restart handlers
> > are replaced if Xen is running.
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks. I assume this is going to go in via Russell or Catalin's tree
> with the rest of your series?
>
I would suggest Russell, if he is willing to pick it up, since it mostly
affects arm.
Guenter
>
> > v2: Rebased to v4.6-rc3, added Reviewed/by/Acked-by tags
> >
> > arch/arm/xen/enlighten.c | 13 +++++++++++--
> > 1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> > index 75cd7345c654..76a1d12fd27e 100644
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -27,6 +27,7 @@
> > #include <linux/cpu.h>
> > #include <linux/console.h>
> > #include <linux/pvclock_gtod.h>
> > +#include <linux/reboot.h>
> > #include <linux/time64.h>
> > #include <linux/timekeeping.h>
> > #include <linux/timekeeper_internal.h>
> > @@ -193,14 +194,22 @@ after_register_vcpu_info:
> > put_cpu();
> > }
> >
> > -static void xen_restart(enum reboot_mode reboot_mode, const char *cmd)
> > +static int xen_restart(struct notifier_block *nb, unsigned long action,
> > + void *data)
> > {
> > struct sched_shutdown r = { .reason = SHUTDOWN_reboot };
> > int rc;
> > rc = HYPERVISOR_sched_op(SCHEDOP_shutdown, &r);
> > BUG_ON(rc);
> > +
> > + return NOTIFY_DONE;
> > }
> >
> > +static struct notifier_block xen_restart_nb = {
> > + .notifier_call = xen_restart,
> > + .priority = 192,
> > +};
> > +
> > static void xen_power_off(void)
> > {
> > struct sched_shutdown r = { .reason = SHUTDOWN_poweroff };
> > @@ -370,7 +379,7 @@ static int __init xen_pm_init(void)
> > return -ENODEV;
> >
> > pm_power_off = xen_power_off;
> > - arm_pm_restart = xen_restart;
> > + register_restart_handler(&xen_restart_nb);
> > if (!xen_initial_domain()) {
> > struct timespec64 ts;
> > xen_read_wallclock(&ts);
> > --
> > 2.5.0
> >
next prev parent reply other threads:[~2016-04-15 19:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 2:42 [PATCH v2 0/6] ARM/ARM64: Drop arm_pm_restart Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
2016-04-15 2:42 ` [PATCH v2 1/6] ARM: prima2: Register with kernel restart handler Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
2016-04-15 2:42 ` [PATCH v2 2/6] ARM: xen: " Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
2016-04-15 18:22 ` Stefano Stabellini
2016-04-15 18:22 ` Stefano Stabellini
2016-04-15 19:35 ` Guenter Roeck
2016-04-15 19:35 ` Guenter Roeck [this message]
2016-04-15 19:35 ` Guenter Roeck
2016-04-15 21:10 ` Stefano Stabellini
2016-04-15 21:10 ` Stefano Stabellini
2016-04-15 21:10 ` Stefano Stabellini
2016-04-15 18:22 ` Stefano Stabellini
2016-04-15 2:42 ` [PATCH v2 3/6] ARM: PSCI: " Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
2016-04-19 15:47 ` Lorenzo Pieralisi
2016-04-19 15:47 ` Lorenzo Pieralisi
2016-04-15 2:42 ` [PATCH v2 4/6] ARM: " Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
2016-04-15 2:42 ` [PATCH v2 5/6] ARM64: Remove arm_pm_restart Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
2016-04-15 2:42 ` [PATCH v2 6/6] ARM: " Guenter Roeck
2016-04-15 2:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415193544.GA2005@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.